Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Use an object of promises in Promise.all() #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use an object of promises in Promise.all() #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9125da
Now you can use an object of promises in Promise.all()
lukefx Dec 15, 2014
3f5ffc4
Better to specify what we expect
lukefx Dec 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 29 additions & 9 deletions src/com/codecatalyst/promise/Promise.as
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,16 @@ package com.codecatalyst.promise
return ( value != null && ( value is Object || value is Function ) && "then" in value && value.then is Function );
}

private static function numProperties(obj:Object): int
{
var count:int = 0;
for each ( var prop:Object in obj )
{
count++;
}
return count;
}

/**
* Returns a new Promise that will only fulfill once all the specified
* Promises and/or values have been fulfilled, and will reject if any
Expand All @@ -96,21 +106,31 @@ package com.codecatalyst.promise
*/
public static function all( promisesOrValues:* ):Promise
{
if ( ! ( promisesOrValues is Array || Promise.isThenable( promisesOrValues ) ) )
if ( ! ( promisesOrValues is Array || promisesOrValues is Object || Promise.isThenable( promisesOrValues ) ) )
{
throw new Error( "Invalid parameter: expected an Array or Promise of an Array." );
throw new Error( "Invalid parameter: expected an Array, an Object or Promise of an Array." );
}

function process( promisesOrValues:Array ):Promise
function process( promisesOrValues:* ):Promise
{
var remainingToResolve:uint = promisesOrValues.length;
var results:Array = new Array( promisesOrValues.length );
var remainingToResolve:uint;
var results:*;

// Array or Object
if (promisesOrValues is Array) {
remainingToResolve = promisesOrValues.length;
results = new Array( promisesOrValues.length );
}
else {
remainingToResolve = numProperties( promisesOrValues );
results = {};
}

var deferred:Deferred = new Deferred();

if ( remainingToResolve > 0 )
{
function resolve( item:*, index:uint ):Promise
function resolve( item:*, index:* ):Promise
{
function fulfill( value:* ):*
{
Expand All @@ -125,11 +145,11 @@ package com.codecatalyst.promise
return Promise.when( item ).then( fulfill, deferred.reject );
}

for ( var index:uint = 0; index < promisesOrValues.length; index++ )
for ( var key:* in promisesOrValues )
{
if ( index in promisesOrValues )
if ( key in promisesOrValues )
{
resolve( promisesOrValues[ index ], index );
resolve( promisesOrValues[ key ], key );
}
else
{
Expand Down