[22기_이연호] Spring Security & JWT 미션 제출합니다. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba2slk
reviewed
Sep 29, 2025
|
|
||
| @Getter | ||
| @Builder | ||
| public class ReasonDto { |
| throw new IllegalArgumentException("행이 올바르지 않습니다."); | ||
| } | ||
|
|
||
| return String.valueOf("A"+(row-1))+col.toString(); |
There was a problem hiding this comment.
저는 row를 String으로 선언했는데, 확장성 측면에서 Integer로 선언하고 변환하는 방식이 더 좋아 보이네요. 배우고 갑니다!
| .genre(movie.getGenre()) | ||
| .prolog(movie.getProlog()) | ||
| .build(); | ||
| return new MovieDetailDto( |
hayong39
reviewed
Sep 29, 2025
| public ResponseEntity<List<MovieResDto.MovieDetailDto>> getMovies(){ | ||
| @GetMapping("/movies") | ||
| @Operation(summary = "영화 리스트 조회하기",description = "") | ||
| public ResponseEntity<List<MovieResponseDto.MovieDetailDto>> getMovies(){ |
There was a problem hiding this comment.
요기에는 ApiResponse 안쓰고 ResponseEntity를 쓴 이유가 있을까요??
| public class Schedule extends BaseEntity { | ||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| @Column(name = "schedule_id") |
Comment on lines
+4
to
+7
| ALL(0,"전체연령가"), | ||
| OVER_12(12,"12세 이상"), | ||
| OVER_15(15,"15세 이상"), | ||
| OVER_18(18,"18세 이상"); |
| import org.springframework.data.jpa.repository.JpaRepository; | ||
| import org.springframework.stereotype.Repository; | ||
|
|
||
| @Repository |
There was a problem hiding this comment.
JpaRepository 상속하면 @repository 붙이지 않아도 되는 걸로 알아요! 가독성 때문에 붙이신걸까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.