Skip to content

fix: ignore sacct jobs with no jobid field #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2022
Merged

fix: ignore sacct jobs with no jobid field #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v1.0.0
v1.0.2
8 changes: 8 additions & 0 deletions internal/model/tabs/jobhisttab/jobhisttabtable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,14 @@ func (saList *SacctJSON) FilterSacctTable(f string, l *log.Logger) (*TableRows,

for _, v := range saList.Jobs {

// https://github.com/CLIP-HPC/SlurmCommander/issues/9
// Entry without JobId, log&discard
switch {
case v.JobId == nil:
l.Printf("FilterSacctTable: Found job with no JobId field, skipping...\n")
continue
}

line := strings.Join([]string{
strconv.Itoa(*v.JobId),
*v.Name,
Expand Down
5 changes: 3 additions & 2 deletions internal/model/view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,12 @@ func (m Model) tabAbout() string {

s += `
Petar Jager
CLIP-HPC @VBC

Contributors:
A special thank you goes to:

Seren Ümit
Kilian Cavalotti
Killian Murphy
`

return s
Expand Down