When removing aliases, the old value needs to be sent to the API #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While for `Labels` and `Descriptions` this is fine (those are `WbMonolingualTextCollection` – the language uniquely identifies the label/description to be removed), for `Aliases` this does not work (it is a `WbMonolingualTextsCollection`, and the language identifies a set of aliases, and the specific alias to be removed needs to be specified. Fixes CXuesong#123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While for
LabelsandDescriptionsthis is fine (those areWbMonolingualTextCollection– the language uniquely identifies the label/description to be removed), forAliasesthis does not work: it is aWbMonolingualTextsCollection, and the language identifies a set of aliases, and the specific alias to be removed needs to be specified.Fixes #123