Skip to content

refactor(layers) Some fine-tuning of layers refactoring, cleanup, comments #2957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Alex-NRCan
Copy link
Member

@Alex-NRCan Alex-NRCan commented Jun 19, 2025

Description

  • Moved updateGeojsonSource outside of map-event-processor to abstract the logic within the gvgeojson class itself
  • Adding layers management inside the GVGroupLayer class
  • Added a refresh and onRefresh functions in the AbstractBaseLayer for the all the GVLayers and GVGroupLayer classes.
  • Further cleanup of getAttributions, getExtentFromFeatures

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Hosted June 19 @ 12:15 : https://alex-nrcan.github.io/geoview

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@Alex-NRCan Alex-NRCan self-assigned this Jun 19, 2025
@Alex-NRCan Alex-NRCan changed the title refactor(layers) refactor(layers) Some fine-tuning of layers refactoring, cleanup, comments Jun 19, 2025
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 27 of 27 files at r1, 3 of 4 files at r2.
Reviewable status: 29 of 30 files reviewed, all discussions resolved (waiting on @Alex-NRCan)

Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Alex-NRCan)

…the logic within the gvgeojson class itself

Adding layers management inside the GVGroupLayer class
Just moving functions
Added a refresh and onRefresh functions in the AbstractBaseLayer for the all the GVLayers and GVGroupLayer classes.
Further cleanup of getAttributions, getExtentFromFeatures
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Alex-NRCan)

@jolevesq jolevesq merged commit 570ba18 into Canadian-Geospatial-Platform:develop Jun 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants