-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add support for clamping Vector 3D Tile point features to Terrain or 3d Tiles #11710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ggetz when you have time can you provide some feedback for this implementation? Thanks again for all of your help. |
|
Thanks @gdiehlEB, we'll do so shortly! |
|
@gdiehlEB Before we can review the code here, you'll need to have Contributor License Agreement covering you or the organization you are contributing on behalf of. Please ask EB to submit one and that you are listed on it. |
|
Thanks for the feedback @ggetz! I had the same thought and have been looking for an alternative to passing the scene in, but I couldn’t find anywhere that the viewer instance was already available to access. If the There may be another way that I am missing though. I saw that in the clamping sandcastle the Entity API is used and provides access to the viewer so no clues there. |
|
Thanks for the update and you patience @gdiehlEB.
Thanks for taking a look. Unfortunately, this may be the case given how Billboard and Label collections currently need to be constructed. Let's move forward with the approached provided here. |
ggetz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few suggestions— Most of these are comment on documentation types and wording for clarity. The code is looking good otherwise!
|
@gdiehlEB Would you be able to provide a working Sandcastle example for verification and testing purposes here? |
|
@ggetz thank you for the feedback!
Not seeing any publicly available vector tiles with points in the sandcastles or Ion Asset Depot, I will share tilesets I was using to test but they are from a customer site so I will send directly. Let me know if that works and if you need anything else. sandcastle code: |
|
Thanks @gdiehlEB! You can send data to [email protected] and we can test and verify the fix. |
|
The only other change needed here is an item describing the update in |
|
We were able to validate with the data you sent over @gdiehlEB! All looking good for this PR. Thank you! |
|
Question: Can we apply per-feature styling and heightReference (like vector 3D tiles) to photogrammetry 3D tiles or terrain layers? Hi @ggetz Cesium Team 👋, I’ve been working with different types of 3D Tiles data in CesiumJS and wanted to confirm some capabilities. I know that vector 3D tilesets support:
However, I wanted to ask: 👉 Can similar features be applied to:
I would really appreciate clarity on whether those formats support such capabilities, or if it’s strictly limited to vector 3D tiles. Thanks for all your amazing work on Cesium! – pradip sable |
Fixes Issue #11544
Adds the global
heightReferencemember as an option forCesium3DTilesetto support clamping Billboards and Labels of Vector 3D Tiles point features to Terrain or 3D Tiles.TO-DO:
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change