chore: use new peer-discovery interface #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: emitted peer event now emits a peer data object with id and multiaddrs instead of a peer-info
Contributor
Author
|
In another context, I will open an issue in this repo to have the tests from EDIT: #52 |
wemeetagain
requested changes
Apr 23, 2020
Member
wemeetagain
left a comment
wemeetagain
left a comment
There was a problem hiding this comment.
LGTM!
Would you mind removing package-lock.json?
Contributor
Author
|
Yes, sorry about that. I did not realize that you were using Meanwhile, I added the |
Member
|
v0.2.0 released under beta tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of deprecating
peer-infoas described on libp2p/js-libp2p#589, this PR changes thepeer-discoveryinterface to emit an object containing anidproperty and amultiaddrsproperty.Note: This should be released with a beta tag until we have everything released, otherwise when people try to install this with
js-libp2pthey will have this as the latest code, which will not work until0.28.BREAKING CHANGE: peer event emits an object with id and multiaddr instead of a peer-info
cc @wemeetagain