refactor: default cookie path to CHAINLIT_ROOT_PATH if set #2311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
hayescode
reviewed
Jul 23, 2025
asvishnyakov
changed the title
|
@hayescode @dominpm Before you merge and release this, keep in mind Chainlit set multiple cookies (I know at least about the one for affinity sessions) which DOES NOT respect auth cookie settings (which is a separate issue). So I think the proper name for variable is |
|
Hi @hayescode , just edited the change for the env var name in the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR follows up on #2207 to refine how the authentication cookie path is determined.
What's Changed
CHAINLIT_ROOT_PATHis defined, it is now used as the default value for the cookie path.CHAINLIT_COOKIE_PATHenv var (which still remains configurable)./.Why
In deployments where
CHAINLIT_ROOT_PATHis used to scope all routes, it makes more sense for cookies to follow the same base path by default — ensuring consistent scoping without requiring extra configuration.Notes
@hayescode as discussed in #2207 — this follows up. (The other PR was automatically merged and closed) Let me know if you'd like to adjust anything further!