Skip to content

upgrade to node 12 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2020
Merged

upgrade to node 12 #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b510e6c
upgrade to node 12
renatoprime Jan 15, 2020
0cdc491
update to the latest node 12 types
renatoprime Jan 15, 2020
e60e819
include .nvmrc file and specify node 12
renatoprime Jan 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ jobs:
build:
working_directory: ~/Clever/{{.AppName}}
docker:
- image: circleci/node:10.12.0-stretch
- image: circleci/node:12-stretch
environment:
CIRCLE_ARTIFACTS: /tmp/circleci-artifacts
CIRCLE_TEST_REPORTS: /tmp/circleci-test-results
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
12
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:10-slim
FROM node:12-slim

WORKDIR /{{.AppName}}

Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
include node.mk

NODE_VERSION := "v10"
NODE_VERSION := "v12"
SHELL := /bin/bash

$(eval $(call node-version-check,$(NODE_VERSION)))
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"dependencies": {
"@types/body-parser": "0.0.34",
"@types/express": "^4.0.35",
"@types/node": "^10.12.0",
"@types/node": "^12.12.24",
"@types/react": "^16.7.8",
"body-parser": "^1.17.0",
"clever-components": "1.8.0",
Expand Down