This repository was archived by the owner on Mar 1, 2023. It is now read-only.
Fix artifacts race condition #1909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
bors try |
charleskawczynski
force-pushed
the
ck/artifacts_race
branch
2 times, most recently
from
958757e to
65e6719
Compare
Member
Author
|
bors try |
Contributor
tryAlready running a review |
Contributor
tryBuild failed: |
Member
Author
|
bors try |
Contributor
tryBuild failed: |
Member
Author
|
bors try |
Contributor
tryAlready running a review |
Contributor
charleskawczynski
force-pushed
the
ck/artifacts_race
branch
2 times, most recently
from
48c4b91 to
b0c9d99
Compare
Member
Author
|
bors try |
jakebolewski
approved these changes
Jan 8, 2021
charleskawczynski
force-pushed
the
ck/artifacts_race
branch
from
b0c9d99 to
dd7db9a
Compare
Member
Author
|
bors r+ |
Contributor
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a field
local_runto theArtifactsWrapper, and iffalse(meaning running CI), then data files are only downloaded to the given directory--hashes / toml files are not created. My hope is that this closes #1678.