DataFusion v33 update and add benchmark for partitioned parquet #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickitat
reviewed
Nov 29, 2023
There was a problem hiding this comment.
diff here is unjustifiably large, I cannot verify that everything is ok.
could you pls fix it.
There was a problem hiding this comment.
fixed! I used the script but extracted just the update for DataFusion for index.html.
Dandandan
reviewed
Nov 29, 2023
datafusion/results/single.json
Outdated
| [3.672, 2.539, 2.496], | ||
| [1.627, 0.344, 0.330], | ||
| [1.885, 0.366, 0.369], | ||
| [2.679, 1.253, 1.236], |
There was a problem hiding this comment.
I think it was gp3 storage actually, which is what new instances default to. let me re-run this again and confirm the gp2 500gb storage. I'll put this in draft until I update this and for nickitat's comment.
There was a problem hiding this comment.
definitely was gp3 previously. rebuilt with gp2 500gb, results more in line with expectations.
kmitchener
changed the title
nickitat
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated for DataFusion v33