Improved test_storage_s3_get_unstable
#23976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-not-for-changelog
There was a problem hiding this comment.
Mysterious variable name.
There was a problem hiding this comment.
What's the logic behind this?
Please write in comments in the code.
|
@alexey-milovidov This patch improves testing capabilities of the test, but I was unable to reproduce #23911 on it anyway. I guess that problem is only disk-related. |
|
@Mergifyio update |
|
Command
|
|
@excitoon You did not provide access to your fork. |
excitoon
force-pushed
the
s3unstablereads
branch
from
fc533e5 to
f16dd06
Compare
|
@alexey-milovidov Rebased it. |
|
Cool! |
This was referenced Aug 3, 2021
excitoon
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Aug 3, 2021
…tes/s3unstablereads Improved `test_storage_s3_get_unstable`" 7c048a9 to 21.3 ClickHouse#23976 Original-Pull-Request: 23976
This was referenced Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Progress on #23911