Skip to content

Fix no_sign_request config for S3 #83379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

Fix no_sign_request config for S3 #83379

merged 1 commit into from
Jul 7, 2025

Conversation

antonio2368
Copy link
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix no_sign_request for S3 client. It can be used to explicitly avoid signing S3 requests. It can also be defined for specific endpoints using endpoint-based settings.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@antonio2368 antonio2368 mentioned this pull request Jul 7, 2025
Merged
1 task
@clickhouse-gh ClickHouse-GH
Copy link

clickhouse-gh bot commented Jul 7, 2025 •
edited
Loading

Workflow [PR], commit [72dd305]

Summary: ❌

job_name test_name status info comment
Performance Comparison (amd_release, master_head, 1/3) failure
Check Results failure

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jul 7, 2025
@antonio2368 antonio2368 added pr-must-backport Pull request should be backported intentionally. Use this label with great care! and removed pr-bugfix Pull request with bugfix, not backported by default labels Jul 7, 2025
@kssenii kssenii self-assigned this Jul 7, 2025
@antonio2368 antonio2368 added this pull request to the merge queue Jul 7, 2025
Merged via the queue into master with commit 6f989a5 Jul 7, 2025
119 of 122 checks passed
@antonio2368 antonio2368 deleted the fix-no-sign-config branch July 7, 2025 15:09
This was referenced Jul 7, 2025
Merged
Merged
Merged
Merged
Merged
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 7, 2025
@robot-ch-test-poll robot-ch-test-poll added pr-backports-created-cloud pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Jul 7, 2025
robot-clickhouse added a commit that referenced this pull request Jul 7, 2025
@robot-clickhouse
Merge pull request #83392 from ClickHouse/cherrypick/24.8/83379
96496b3 
Cherry pick #83379 to 24.8: Fix no_sign_request config for S3
robot-clickhouse added a commit that referenced this pull request Jul 7, 2025
@robot-clickhouse
Backport #83379 to 24.8: Fix no_sign_request config for S3
21fb3ad
@robot-clickhouse robot-clickhouse mentioned this pull request Jul 7, 2025
Merged
robot-clickhouse added a commit that referenced this pull request Jul 7, 2025
@robot-clickhouse
Merge pull request #83393 from ClickHouse/cherrypick/25.3/83379
f0b0ba0 
Cherry pick #83379 to 25.3: Fix no_sign_request config for S3
robot-clickhouse added a commit that referenced this pull request Jul 7, 2025
@robot-clickhouse
Backport #83379 to 25.3: Fix no_sign_request config for S3
6e5d2d1
@robot-clickhouse robot-clickhouse mentioned this pull request Jul 7, 2025
Merged
robot-clickhouse added a commit that referenced this pull request Jul 7, 2025
@robot-clickhouse
Merge pull request #83394 from ClickHouse/cherrypick/25.4/83379
4bb36ad 
Cherry pick #83379 to 25.4: Fix no_sign_request config for S3
robot-clickhouse added a commit that referenced this pull request Jul 7, 2025
@robot-clickhouse
Backport #83379 to 25.4: Fix no_sign_request config for S3
471b19a
@robot-clickhouse robot-clickhouse mentioned this pull request Jul 7, 2025
Merged
robot-clickhouse added a commit that referenced this pull request Jul 7, 2025
@robot-clickhouse
Merge pull request #83395 from ClickHouse/cherrypick/25.5/83379
1a0c9d9 
Cherry pick #83379 to 25.5: Fix no_sign_request config for S3
robot-clickhouse added a commit that referenced this pull request Jul 7, 2025
@robot-clickhouse
Backport #83379 to 25.5: Fix no_sign_request config for S3
c1243d5
@robot-clickhouse robot-clickhouse mentioned this pull request Jul 7, 2025
Merged
robot-clickhouse added a commit that referenced this pull request Jul 7, 2025
@robot-clickhouse
Merge pull request #83396 from ClickHouse/cherrypick/25.6/83379
f252319 
Cherry pick #83379 to 25.6: Fix no_sign_request config for S3
robot-clickhouse added a commit that referenced this pull request Jul 7, 2025
@robot-clickhouse
Backport #83379 to 25.6: Fix no_sign_request config for S3
ecbb9cc
@robot-clickhouse robot-clickhouse mentioned this pull request Jul 7, 2025
Merged
@robot-clickhouse robot-clickhouse added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 7, 2025
clickhouse-gh bot added a commit that referenced this pull request Jul 7, 2025
@clickhouse-gh
Merge pull request #83405 from ClickHouse/backport/25.6/83379
f74a9b6 
Backport #83379 to 25.6: Fix no_sign_request config for S3
antonio2368 added a commit that referenced this pull request Jul 8, 2025
@antonio2368
Merge pull request #83403 from ClickHouse/backport/25.4/83379
4cf7cde 
Backport #83379 to 25.4: Fix no_sign_request config for S3
antonio2368 added a commit that referenced this pull request Jul 8, 2025
@antonio2368
Merge pull request #83404 from ClickHouse/backport/25.5/83379
6873369 
Backport #83379 to 25.5: Fix no_sign_request config for S3
antonio2368 added a commit that referenced this pull request Jul 8, 2025
@antonio2368
Merge pull request #83402 from ClickHouse/backport/25.3/83379
535d678 
Backport #83379 to 25.3: Fix no_sign_request config for S3
antonio2368 added a commit that referenced this pull request Jul 8, 2025
@antonio2368
Merge pull request #83401 from ClickHouse/backport/24.8/83379
9eb2d06 
Backport #83379 to 24.8: Fix no_sign_request config for S3
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Sep 2, 2025
@antonio2368 @zvonand
Merge pull request ClickHouse#83379 from ClickHouse/fix-no-sign-config
7aa67ed 
Fix no_sign_request config for S3
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Sep 2, 2025
@antonio2368 @zvonand
Merge pull request ClickHouse#83379 from ClickHouse/fix-no-sign-config
30799ca 
Fix no_sign_request config for S3
@zvonand zvonand mentioned this pull request Sep 3, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@antonio2368 @kssenii @robot-clickhouse @robot-ch-test-poll @robot-clickhouse-ci-2