feat: add non-flattened Nested(...) type support for RowBinaryWithNamesAndTypes
#282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvermeulen
force-pushed
the
rbwnat-nested
branch
from
7f2fe3e to
8ed55be
Compare
It now ensures that the brackets and quotes are balanced, and no longer consumes a trailing closing bracket if there's no matching opening bracket.
timvermeulen
force-pushed
the
rbwnat-nested
branch
from
8ed55be to
506e52d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ClickHouse usually flattens a column
x Nested(y T1, z T2)into separate columnsx.y Array(T1), x.z Array(T2), but this can be turned off and also only applies to top-level nested columns, not arbitrarily nested columns. This PR adds validation support for non-flattenedNested(...)columns (which are encoded asArray(Tuple(...))).Checklist
Delete items not relevant to your PR: