Skip to content

Implement ConnOpenAck datagrain in the ICS Connection spec #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 21, 2020
Merged

Implement ConnOpenAck datagrain in the ICS Connection spec #180

merged 3 commits into from
Feb 21, 2020

Conversation

majecty
Copy link
Contributor

@majecty majecty commented Feb 17, 2020

No description provided.

@majecty majecty added the ics Interchain standard label Feb 17, 2020
@majecty majecty mentioned this pull request Feb 17, 2020
Closed
6 tasks
@majecty majecty force-pushed the f/ics-conn-open-ack branch from db06e1e to b2ac1e0 Compare February 18, 2020 08:29
@majecty majecty requested a review from junha1 February 18, 2020 08:41
@majecty majecty changed the title [WIP] Implement ConnOpenAck datagrain in the ICS Connection spec Implement ConnOpenAck datagrain in the ICS Connection spec Feb 18, 2020
junha1
junha1 reviewed Feb 18, 2020
View reviewed changes
@majecty majecty mentioned this pull request Feb 18, 2020
Merged
@majecty
Remove duplicated context definition
b67da38
@majecty
Use Vec<u8> type for received proofs
52cc5fd 
Since only the light client know the encoding of the proof, we should
not decode the proof in other places.
@majecty majecty force-pushed the f/ics-conn-open-ack branch from b2ac1e0 to 2f2e518 Compare February 21, 2020 03:20
@majecty majecty force-pushed the f/ics-conn-open-ack branch from 2f2e518 to 63d8310 Compare February 21, 2020 03:22
@majecty
Copy link
Contributor Author

majecty commented Feb 21, 2020

@junha1 I added this commit: 52cc5fd

Other things are barely changed. I changed the type of proof to Vec<u8> from String. I changed the code that was using get_kv_store to use get_kv_store_mut.

@majecty majecty requested a review from junha1 February 21, 2020 03:25
junha1
junha1 reviewed Feb 21, 2020
View reviewed changes
@majecty majecty merged commit a06d73b into CodeChain-io:ics-poc Feb 21, 2020
@majecty majecty deleted the f/ics-conn-open-ack branch February 21, 2020 04:33
@junha1 junha1 added the experiment Experimental features label Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junha1 junha1 junha1 approved these changes

Assignees

No one assigned

Labels

experiment Experimental features ics Interchain standard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@majecty @junha1