Build a connection #232
Merged
Build a connection #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
majecty
force-pushed
the
f/ics-building-connection
branch
from
e4a2994 to
29dfe8b
Compare
Before:
``
{
result: {
raw: ["a", "b"]
}
}
```
After:
```
{
result: ["a", "b"]
}
```
Change the response of ConnectionIdentifiers
When add_connection_to_client is called, the connection should exist.
The relayer and scenario script sends transactions concurrently. To make sequence management easier, I prepared a new account for the scenario script.
`instance_id` is used in the Foundry log. It helps debugging.
Before: Always wait 3 seconds. Sometimes it takes more than 3 seconds. After: Send ping every second for 10 seconds. If a chain is initlaized, we can check it in a second.
* connOpenInit * connOpenTry * connOpenAck * connOpenConfirm
majecty
force-pushed
the
f/ics-building-connection
branch
from
29dfe8b to
c4c709c
Compare
junha1
reviewed
Mar 10, 2020
ibc.ts/src/relayer/index.ts
Outdated
| } | ||
| let currentBlockNumber = clientState!.data!.number; | ||
| while (currentBlockNumber < counterpartyChainHeight) { | ||
| // We can't get the best block's IBC header |
There was a problem hiding this comment.
I think FIXME is needed here, because there is FIXME in compose_header() for the same problem.
junha1
reviewed
Mar 10, 2020
| ); | ||
|
|
||
| // We can't update light client upto the best block. | ||
| height = height - 1; |
Since querying the current best block's seal is difficult, our PoC implementation does not implement it. Make the relayer use the information.
majecty
force-pushed
the
f/ics-building-connection
branch
from
c4c709c to
e927201
Compare
|
@junha1 I fixed them. |
junha1
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #231