-
Couldn't load subscription status.
- Fork 2
CU-869aa22g2 Add ElasticSearch bits from working_with_cogstack #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Looks good, the only thing can be add here is to use a specific docker image release for OS tests (3.2.0 for e.g) which we currently use on main cg in non-native-ES deployments, just so we know what behavior to expect in case we update these images in the future. |
So you're suggesting we explicitly set |
|
in this case, by OS I mean OpenSearch 😄 referenced in
|
That does make more sense! Yes, will do. Though I ran these with |
This PR adds only the ES parts from
working_with_cogstack.This is based on the newer
cogstack2.pyand relevant search notebook.Currently:
cogstack.pymoduleTODO later:
NOTE:
The "real world validation" was performed as follows:
tests/.e2e/run_es8_locally.shtests/.e2e/run_es9_locally.shtests/.e2e/run_os_locally.shpytest tests/.e2e/test_locally.pyLater changes to this PR makes a number of important changes:
Cogstackclass incogstack.pywill now be distributed through PyPI ascogstack-esfrom cogstack import CogStackES8,ES9, orOSfor v8 or v9 of Elasticsearch or Opensearch (v2)pip install cogstack-es[ES9]cogstack.esand the OS specified code incogstack.oscredentials.pyis no longersrc/cogstack/read_creds.pyfor details