SWA component #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronpowell
force-pushed
the
swa-component
branch
from
eecc6a4 to
8724d8a
Compare
aaronpowell
added a commit
that referenced
this pull request
May 23, 2025
Update project references and improve app setup - Added project reference for `CommunityToolkit.Aspire.Hosting.NodeJS.Extensions.csproj` in `CommunityToolkit.Aspire.StaticWebApps.AppHost.csproj`. - Changed web app setup in `Program.cs` from `.AddNpmApp` to `.AddViteApp` with `.WithNpmPackageInstallation()`. - Modified `Port` property in `SwaResourceOptions.cs` to use a random port between 4280 and 5280. - Updated tests in `SwaHostingComponentTests.cs` to utilize `CancellationToken` for better control over async operations. Related Work Items: #6, #677
aaronpowell
added a commit
that referenced
this pull request
May 24, 2025
* Fixes #677 Update project references and improve app setup - Added project reference for `CommunityToolkit.Aspire.Hosting.NodeJS.Extensions.csproj` in `CommunityToolkit.Aspire.StaticWebApps.AppHost.csproj`. - Changed web app setup in `Program.cs` from `.AddNpmApp` to `.AddViteApp` with `.WithNpmPackageInstallation()`. - Modified `Port` property in `SwaResourceOptions.cs` to use a random port between 4280 and 5280. - Updated tests in `SwaHostingComponentTests.cs` to utilize `CancellationToken` for better control over async operations. Related Work Items: #6, #677 * reverting port change and disabling tests * Deprecating the SWA emulator integration Contributes to #698 * Updating readmie * forcing the dev certs install for SWA * Revert "forcing the dev certs install for SWA" This reverts commit 15475a6. * Commenting out the tests completely This precents the test app host from actually starting up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the
CommunityToolkit.Aspireproject, including the addition of a new projectCommunityToolkit.Aspire.Hosting.Azure.StaticWebApps, changes to the solution file, and the addition of tests for the new project. The changes also include the creation of new classes and methods within the new project and modifications to theDirectory.Packages.propsandtests/CommunityToolkit.Aspire.Java.Hosting.EndToEndTests/CommunityToolkit.Aspire.Java.Hosting.EndToEndTests.csprojfiles.Project and Solution Changes:
CommunityToolkit.Aspire.sln: Added a new projectCommunityToolkit.Aspire.Hosting.Azure.StaticWebAppsand its corresponding tests projectCommunityToolkit.Aspire.Hosting.Azure.StaticWebApps.Tests. Also, the path of theCommunityToolkit.Aspire.Java.Hosting.EndToEndTestsproject has been updated. [1] [2]New Project and Code Additions:
src/CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps/CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps.csproj: New project file added.src/CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps/SwaApiEndpointAnnotation.cs,src/CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps/SwaAppEndpointAnnotation.cs,src/CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps/SwaAppHostingExtension.cs,src/CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps/SwaResource.cs: New classes added to the new project. [1] [2] [3] [4]Test Additions:
tests/CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps.Tests/CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps.Tests.csproj: New test project file added.tests/CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps.Tests/ResourceCreationTests.cs: New test class added to the new test project.File Modifications:
Directory.Packages.props: Removed unnecessary line breaks.tests/CommunityToolkit.Aspire.Java.Hosting.EndToEndTests/CommunityToolkit.Aspire.Java.Hosting.EndToEndTests.csproj: Removed the package reference toAspire.Hosting.Testing.tests/Directory.Build.props: Added a package reference toAspire.Hosting.Testing.