Skip to content

Conversation

@michael-hawker
Copy link
Member

Draft request to test CI, needs to wait for #403 to be merged first (and then this PR needs to be rebased).

This PR:

  • moves common to tooling
  • creates a ToolingDirectory property
  • creates a couple of env in build.yml

Basically makes it easier to configure/change later without having to be hard-coded, but not completely yet. But enough while I was swapping many things out anyway.

@michael-hawker
Copy link
Member Author

michael-hawker commented Mar 13, 2023

Looks like I missed something somewhere:

Run ./tooling/GenerateAllSolution.ps1
GenerateAllSolution.ps1: /home/runner/work/_temp/[12](https://github.com/CommunityToolkit/Labs-Windows/actions/runs/4409554861/jobs/7725992269#step:6:13)7296b3-46ca-4774-bb0c-8f97dc817ab7.ps1:2
Line |
   2 |  ./tooling/GenerateAllSolution.ps1
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | The term './common/MultiTarget/GenerateAllProjectReferences.ps1' is not
     | recognized as a name of a cmdlet, function, script file, or executable
     | program. Check the spelling of the name, or if a path was included,
     | verify that the path is correct and try again.
8s
Run powershell -version 5.[1](https://github.com/CommunityToolkit/Labs-Windows/actions/runs/4409554861/jobs/7726023837#step:9:1) -command "./tooling/GenerateAllSolution.ps1 -IncludeHeads UWP" -ErrorAction Stop
D:\a\Labs-Windows\Labs-Windows\tooling\GenerateAllSolution.ps1 : The term 
'./common/MultiTarget/GenerateAllProjectReferences.ps1' is not recognized as the name of a cmdlet, function, script 
file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct 
and try again.
At line:1 char:1
+ ./tooling/GenerateAllSolution.ps1 -IncludeHeads UWP -ErrorAction Stop
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (./common/MultiT...tReferences.ps1:String) [GenerateAllSolution.ps1], Co 
   mmandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException,GenerateAllSolution.ps1

Found it, not sure how that didn't show up in the rename I did... whatever

@michael-hawker
Copy link
Member Author

Error was the .NET Native memory one in the pipeline... need to rebase anyway, doing that now.

Add a ToolingDirectory property for simplifying naming in future
Abstract a few directories in build.yml to make simpler to change later too
@michael-hawker michael-hawker marked this pull request as ready for review March 13, 2023 23:14
Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, looks good as long as CI passes! Glad to see we parameterized the tooling directory as well 🙂

@michael-hawker
Copy link
Member Author

Approved, looks good as long as CI passes! Glad to see we parameterized the tooling directory as well 🙂

Awesome, thanks! Yeah, it's not completely parameterized yet, but figured I'd start us down that path, that way in the future eventually it'll just be something that's a prop variable somewhere or something and can be changed. At least until we get to a package or something setup instead.

@michael-hawker
Copy link
Member Author

michael-hawker commented Mar 14, 2023

Hitting CommunityToolkit/Tooling-Windows-Submodule#9 with this constantly for some reason, spun up #406 off main to see if that helps there at all...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants