-
Couldn't load subscription status.
- Fork 78
Rename common directory to tooling #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename common directory to tooling #405
Conversation
|
Looks like I missed something somewhere: Found it, not sure how that didn't show up in the rename I did... whatever |
527a51c to
ea60199
Compare
|
Error was the .NET Native memory one in the pipeline... need to rebase anyway, doing that now. |
Add a ToolingDirectory property for simplifying naming in future Abstract a few directories in build.yml to make simpler to change later too
ea60199 to
d6c7477
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, looks good as long as CI passes! Glad to see we parameterized the tooling directory as well 🙂
Awesome, thanks! Yeah, it's not completely parameterized yet, but figured I'd start us down that path, that way in the future eventually it'll just be something that's a prop variable somewhere or something and can be changed. At least until we get to a package or something setup instead. |
|
Hitting CommunityToolkit/Tooling-Windows-Submodule#9 with this constantly for some reason, spun up #406 off |
Draft request to test CI, needs to wait for #403 to be merged first (and then this PR needs to be rebased).
This PR:
commontotoolingToolingDirectorypropertyBasically makes it easier to configure/change later without having to be hard-coded, but not completely yet. But enough while I was swapping many things out anyway.