Skip to content

Conversation

@Rosuavio
Copy link
Contributor

InheritDoc fails when there are more than one source xml doc for a specified target.
This is from "Nerdbank.GitVersioning" project and is not an issue here.

Fixes InheritDoc build issue

The inherit doc step started to fail, this fixes it.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Build or CI related changes

What is the current behavior?

All branches without this change are failing the inherit doc build step.

What is the new behavior?

Inherit doc build step doesn't fail

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

InheritDoc fails when there are more than one source xml doc for a specified target.
This is from "Nerdbank.GitVersioning" project and is not an issue here.
@ghost
Copy link

ghost commented Apr 12, 2021

Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from Kyaa-dost, azchohfi and michael-hawker April 12, 2021 14:21
@Rosuavio
Copy link
Contributor Author

@azchohfi @Kyaa-dost If you guys don't mind getting to this one quickly, this issue is blocking multiple branches.

@ghost
Copy link

ghost commented Apr 12, 2021

Hello @RosarioPulella!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 5 hours 54 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@Rosuavio Rosuavio merged commit 095c7cb into CommunityToolkit:master Apr 12, 2021
@Rosuavio Rosuavio deleted the inheritDoc-fix branch April 12, 2021 16:28
@michael-hawker michael-hawker added this to the 7.0.2 milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants