Skip to content

Check style.Ignore if style is not null. #4095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Check style.Ignore if style is not null. #4095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 32 additions & 30 deletions Microsoft.Toolkit.Uwp.SampleApp/Controls/SampleAppMarkdownRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,44 +270,46 @@ protected override void RenderQuote(QuoteBlock element, IRenderContext context)
else if (firstInline is TextRunInline textRunInline)
{
var key = textRunInline.Text.Split(' ').FirstOrDefault();
if (styles.TryGetValue(key, out var style) && !style.Ignore)
if (styles.TryGetValue(key, out var style))
{
noteType = style;
header = style.IdentifierReplacement;
symbolGlyph = style.Glyph;
if (!style.Ignore)
{
noteType = style;
header = style.IdentifierReplacement;
symbolGlyph = style.Glyph;

// Removes the identifier from the text
textRunInline.Text = textRunInline.Text.Replace(key, string.Empty);
// Removes the identifier from the text
textRunInline.Text = textRunInline.Text.Replace(key, string.Empty);

if (theme == ElementTheme.Light)
{
localForeground = style.LightForeground;
localBackground = style.LightBackground;
}
else
{
localForeground = new SolidColorBrush(Colors.White);
localBackground = style.DarkBackground;
}
if (theme == ElementTheme.Light)
{
localForeground = style.LightForeground;
localBackground = style.LightBackground;
}
else
{
localForeground = new SolidColorBrush(Colors.White);
localBackground = style.DarkBackground;
}

// Apply special formatting context.
if (noteType != null)
{
if (localContext?.Clone() is UIElementCollectionRenderContext newContext)
// Apply special formatting context.
if (noteType != null)
{
localContext = newContext;
if (localContext?.Clone() is UIElementCollectionRenderContext newContext)
{
localContext = newContext;

localContext.TrimLeadingWhitespace = true;
QuoteForeground = Foreground;
LinkForeground = localForeground;
localContext.TrimLeadingWhitespace = true;
QuoteForeground = Foreground;
LinkForeground = localForeground;
}
}
}
}

if (style.Ignore)
{
// Blank entire block
textRunInline.Text = string.Empty;
else
{
// Blank entire block
textRunInline.Text = string.Empty;
}
}
}
}
Expand Down