feat: utilise parameterised zkevm.bin #615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need to build distinct zkevm.bin files for different chains (e.g. linea vs ethereum vs old linea). Specifically, the GAS_LIMIT_MAXIMUM and GAS_LIMIT_MINIMUM are converted into externalised constants. This means they can be assigned different values by go-corset when checking.
letypequividelespoubelles
approved these changes
Mar 11, 2025
| $(wildcard blockdata/processing/gaslimit/common.lisp) \ | ||
| $(wildcard blockdata/processing/gaslimit/ethereum.lisp) \ | ||
| $(wildcard blockdata/lookups/*.lisp) | ||
| BLOCKDATA := $(wildcard blockdata/*.lisp) \ |
Collaborator
There was a problem hiding this comment.
shouldn't it be just := blockdata ?
Collaborator
Author
There was a problem hiding this comment.
Oops, merged before I saw this. Yes, I guess it could be. Feel free to change that when you're next updating the repo!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need to build distinct zkevm.bin files for different chains (e.g. linea vs ethereum vs old linea). Specifically, the GAS_LIMIT_MAXIMUM and GAS_LIMIT_MINIMUM are converted into externalised constants. This means they can be assigned different values by go-corset when checking.