`MXP` redesign #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

amkCha merged 75 commits into master from MXP-redesign

Jun 26, 2025

Collaborator

OlivierBBB commented Mar 22, 2025

Implementation of Consensys/linea-specification#103

OlivierBBB added the London to Prague label

OlivierBBB self-assigned this

OlivierBBB marked this pull request as ready for review

March 24, 2025 21:21

OlivierBBB requested review from letypequividelespoubelles and lorenzogentile404

March 24, 2025 21:21

OlivierBBB mentioned this pull request

MXP redesign Consensys/linea-specification#60

Closed

9 tasks

lorenzogentile404 reviewed

View reviewed changes

mxp_v3/generalities/shorthands.lisp Outdated Show resolved Hide resolved

lorenzogentile404 reviewed

View reviewed changes

mxp_v3/computations/state_update_byte_pricing.lisp Outdated Show resolved Hide resolved

mxp_v3/computations/state_update_byte_pricing.lisp Outdated Show resolved Hide resolved

amkCha force-pushed the MXP-redesign branch from 86345af to 459c75a Compare

May 13, 2025 10:27

amkCha force-pushed the MXP-redesign branch 5 times, most recently from bb05614 to 73fff22 Compare

June 18, 2025 14:38

amkCha reviewed

View reviewed changes

hub/cancun/lookups/hub_into_mxp.lisp Show resolved Hide resolved

amkCha reviewed

View reviewed changes

reftables/cancun/inst_decoder.lisp Show resolved Hide resolved

amkCha force-pushed the MXP-redesign branch 2 times, most recently from 7810464 to 9427591 Compare

June 19, 2025 11:46

amkCha reviewed

View reviewed changes

mxp/cancun/columns/macro.lisp Outdated Show resolved Hide resolved

amkCha reviewed

View reviewed changes

mxp/cancun/lookups/mxp_into_instruction_decoder.lisp Show resolved Hide resolved

amkCha reviewed

View reviewed changes

mxp/cancun/generalities/_constants_and_shorthands.lisp Show resolved Hide resolved

amkCha reviewed

View reviewed changes

mxp/cancun/generalities/heartbeat.lisp Show resolved Hide resolved

amkCha reviewed

View reviewed changes

mxp/cancun/generalities/perspectives/decoder.lisp Outdated Show resolved Hide resolved

amkCha reviewed

View reviewed changes

mxp/cancun/generalities/perspectives/decoder.lisp Outdated Show resolved Hide resolved

amkCha reviewed

View reviewed changes

mxp/cancun/generalities/perspectives/computations.lisp Outdated Show resolved Hide resolved

amkCha reviewed

View reviewed changes

mxp/cancun/computations/msize.lisp Show resolved Hide resolved

amkCha reviewed

View reviewed changes

mxp/cancun/computations/non_msize.lisp Show resolved Hide resolved

amkCha reviewed

View reviewed changes

mxp/cancun/computations/non_msize_non_trivial.lisp Show resolved Hide resolved

amkCha reviewed

View reviewed changes

mxp/cancun/computations/non_msize.lisp Outdated Show resolved Hide resolved

amkCha reviewed

View reviewed changes

mxp/cancun/computations/state_update.lisp Show resolved Hide resolved

OlivierBBB and others added 24 commits

June 26, 2025 11:10


          feat: retire MXP instruction of TYPE_5 (for CALL family)

8c2296d


          feat: retire MXP instruction of TYPE_4 (for COPY family)

1f56bcc


          feat: retire MXP instruction of TYPE_4 (for CREATE family)

7f4269e


          feat: retire MXP instruction of TYPE_4 (for RETURN opcode)

e79dd2b


          feat: retire MXP instruction of TYPE_4 (for KEC family)

72b0d6a


          feat: retire MXP instruction of TYPE_4 (for LOG family)

6c110af


          feat: retire MXP instruction of TYPE_2/3 (for STACKRAM family)

ce6651e

- unified treatment for MLOAD, MSTORE, MSTORE8
  - they all use (set-MXP-instruction---single-mxp-offset-instructions)
- does not apply to CALLDATALOAD
- new shorthand (stack-ram---fixed-size) which is 32, 32, 1 depending on
the case


          feat: duplicate + update lookup HUB -> MXP

1c2bff1

hub_into_mxp  -->  hub_into_mxp_london
                   hub_into_mxp_cancun

also removed MTNTOP from the cancun version


          feat: retire MXP instruction of TYPE_4 (for REVERT opcode)

39f04eb


          ras: formatting for REVERT opcode

b15d577


          feat: remove deprecated TYPE_1/2/3/4/5 MXP instructions

1db730a

ras

0ffc721


          rebase + use folders for mxp fork + merge hub files

0c5b416


          fix module mxp names

bd122a7


          fix rebase issues: mtntop, type-4, extra files

4c7e1b9


          hub into mxp pending

4e1fa22


          fix makefile

0fc86d0


          fix: Makefile

ec6b376


          rebase master

598d0c1


          update Makefile

1c4a62b


          fix: typos, computation naming, may_trigger_mmu removal

31e8852


          fix: guard for byte pricing

f96e50c


          feat: hub_into_mxp cancun and lookup cleanup

7f2b445


          feat: update hub_into_instruction_decoder

09804fb

amkCha force-pushed the MXP-redesign branch from 411c3fb to 09804fb Compare

June 26, 2025 09:10


          fix: shorthand naming, rearrange constants

307c929

amkCha force-pushed the MXP-redesign branch from a1900a3 to 307c929 Compare

June 26, 2025 12:56

amkCha approved these changes

View reviewed changes

amkCha merged commit e6c09e3 into master

3 checks passed

amkCha deleted the MXP-redesign branch

June 26, 2025 13:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

London to Prague