use defclookup in place of deflookup #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavePearce
force-pushed
the
679-feat-make-use-of-defclookup
branch
2 times, most recently
from
107dc39 to
7ddada2
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
letypequividelespoubelles
approved these changes
Jul 2, 2025
This replaces lookups with conditional lookups where it makes sense to do so in the LONDON fork. Conditional lookups offer performance benefits, as they do not generated computed columns to implement selectors.
This update paris-specific lookups to use defclookup where appropriate.
This replaces occurences of deflookup with manual selectors with instances of defclookup (where it makes sense to do so) in the Shanghai fork.
This updates occurences of deflookup to use defclookup instead (when this is makes sense) for the cancun fork.
This updates various lispX files to use defclookup (when appropriate).
This fixes a typo made during the translation of deflookup into defclookup.
DavePearce
force-pushed
the
679-feat-make-use-of-defclookup
branch
from
8d12b80 to
7d79602
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
DavePearce
force-pushed
the
679-feat-make-use-of-defclookup
branch
from
81d131c to
375c194
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This function is part of the lookup constraint `hub-into-wcp-for-sox`. It computes a negative number for a given field which, previously, was being hidden by the fact that the selector was not active (i.e. so -1 * 0 gave 0). Since the selector multiplication is no longer present, this value was remaining as -1. The solution here is to put back a multiplication which ensures the negative value does not arise in practice.
DavePearce
force-pushed
the
679-feat-make-use-of-defclookup
branch
from
375c194 to
bb8cb73
Compare
DavePearce
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces lookups with conditional lookups where it makes sense to do so in the LONDON fork. Conditional lookups offer performance benefits, as they do not generated computed columns to implement selectors.