feat: prepare for cancun oob #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F Bojarski <[email protected]>
Closed
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| (begin (eq! (prc---ram-success) | ||
| (* (prc-blake-params---sufficient-gas) (prc-blake-params---f-is-a-bit))) | ||
| (if-not-zero (prc---ram-success) | ||
| (eq! (prc---return-gas) (- (prc---callee-gas) (prc-blake-params---blake-r))) |
There was a problem hiding this comment.
Bug: BLAKE2F Precompile Gas Calculation Error
The BLAKE2F precompile's return gas calculation incorrectly subtracts only the number of rounds (blake-r) from callee-gas. It should instead subtract the total cost (GAS_CONST_BLAKE2_PER_ROUND * blake-r), as correctly used in the gas sufficiency check. This inconsistency leads to an overestimation of returned gas.
Locations (1)
| (defun (rdc---rdc-soob) (shift OUTGOING_RES_LO 2)) | ||
|
|
||
| (defconstraint rdc---check-offset-is-zero (:guard (* (assumption---fresh-new-stamp) (rdc---standard-precondition))) | ||
| (call-to-ISZERO 0 (rdc---offset-hi) (rdc---size-hi))) |
There was a problem hiding this comment.
Bug: Incorrect Offset Check in Constraint
The rdc---check-offset-is-zero constraint incorrectly calls call-to-ISZERO with (rdc---offset-hi) and (rdc---size-hi). To properly check if the offset is zero, it should use (rdc---offset-hi) and (rdc---offset-lo).
Locations (1)
lorenzogentile404
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.