fix: add guard on finalization constraint for access list #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amkCha
force-pushed
the
fix/rlp-txn-access-list-finalization-constraint-guard
branch
from
38b109d to
490789b
Compare
lorenzogentile404
approved these changes
Aug 20, 2025
Contributor
lorenzogentile404
left a comment
lorenzogentile404
left a comment
There was a problem hiding this comment.
LGTM, can we actually use :guard to define that precondition however?
Contributor
Author
|
I wanted to stay consistent with the constraints written above. Should we switch it to a guard ? If you think it's better I don't mind :) |
amkCha
deleted the
fix/rlp-txn-access-list-finalization-constraint-guard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.