fix: resA and resB can be > i32 #730
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxOffset can be 2³² (MXPX_THRESHOLD)
in row i + 8, when divided by 32, ie 2⁵, res can be 2²⁷
in row i + 9, previous res is squared and divided by 512, ie 2^9, so resA can be 2^45
We need to replace the definition of resA as an i64 i/o i32
For resB,
in row i + 9, previous res is squared and divided by 512, ie 2^9, so resA can be 2^45
in the case where the remainder is 0, the ceiling == the quotient, ie resB = resA so resB can also be 2^45