Skip to content

Conversation

kasemir
Copy link
Collaborator

@kasemir kasemir commented Dec 17, 2019

Initial writeup for #894, also mentioning file locations, naming of tests etc. which had been discussed in hangouts but should be documented with the code base.

@georgweiss
Copy link
Collaborator

Do not quite agree that we should label the following as discouraged:
if(){ } else{ }

IDEs are capable of highlighting opening braces so finding them should not be a problem.

@kasemir
Copy link
Collaborator Author

kasemir commented Dec 17, 2019

I thought in #894 and hangouts we had already agreed on balanced braces.

@georgweiss
Copy link
Collaborator

Maybe, do not quite recall. But how are we to enforce it? Are we do change all source?

@kasemir
Copy link
Collaborator Author

kasemir commented Dec 17, 2019

We don't enforce it by blindly applying some source code formatter, that's kind of the point, because it would break all the manual formatting that people already put it.
These are suggestions for humans to follow as they add code or update some existing code.
Step one is to document it.
Step two might be enabling IDE support for removing trailing white space, or 4-spaces-instead-of-tabs. But no blind overall reformatting.

@georgweiss
Copy link
Collaborator

That's fine, but I still do not agree with the statement of discouraged use of braces.

@kasemir
Copy link
Collaborator Author

kasemir commented Dec 17, 2019

OK, then we scratch this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants