Use Kafka properties when creating AdminClient #3626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
AlarmServerMain.ensureKafkaTopicsto actually make use of thekafka_props_fileparameter, so that custom Kafka properties are used when creating theAdminClient.Fixes #3625.
@shroffk As you wrote the original code that introduced this problem, you might be the right one to review this PR.
Checklist
I started the alarm server with the changes and found that the
AdminClientnow correctly uses the settings set in the Kafka properties file. I checked this by increasing the log level fororg.apache.kafkatoINFO, so that configuration settings are logged.