Show Backup Progress #1466
Merged
Show Backup Progress #1466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Hirobreak
commented
Jun 8, 2020
Hirobreak
commented
- Showing backup progress in a snackbar
javiteri95
suggested changes
Jun 8, 2020
| errorTitle: '', | ||
| errorInfo: '', | ||
| counter: 11 | ||
| counter: 200 |
Contributor
There was a problem hiding this comment.
actually you change it from 1100 to 11
email_mailbox/src/lang/es.json
Outdated
| "exporting_contacts": "Exporting Contacts...", | ||
| "saving_contacts": "Saving Contacts...", | ||
| "exporting_labels": "Exporting Labels...", | ||
| "saving_labels": "Saving Labels...", |
Contributor
There was a problem hiding this comment.
Not sure, but even es.json have to be in english?
Contributor
There was a problem hiding this comment.
No. It needs translations.
danieltigse
requested changes
Jun 9, 2020
|
|
||
| const customDomains = await exportCustomDomainsTable(accountId); | ||
|
|
||
| exportProgress += 100 / PROGRESS_TOTAL_STEPS; |
Contributor
There was a problem hiding this comment.
encapsulate this code 🙏🏻
| errorTitle: '', | ||
| errorInfo: '', | ||
| counter: 11 | ||
| counter: 200 |
Contributor
There was a problem hiding this comment.
actually you change it from 1100 to 11
email_mailbox/src/lang/es.json
Outdated
| "exporting_contacts": "Exporting Contacts...", | ||
| "saving_contacts": "Saving Contacts...", | ||
| "exporting_labels": "Exporting Labels...", | ||
| "saving_labels": "Saving Labels...", |
Contributor
There was a problem hiding this comment.
No. It needs translations.
Hirobreak
force-pushed
the
backup-progress
branch
from
20b6b92 to
e86a5f5
Compare
danieltigse
approved these changes
Jun 10, 2020
Hirobreak
force-pushed
the
backup-progress
branch
from
64bff56 to
1879315
Compare
Collaborator
Author
|
|
danieltigse
approved these changes
Jun 11, 2020
javiteri95
suggested changes
Jun 11, 2020
electron_app/src/ipc/backup.js
Outdated
| } | ||
| return backupSize; | ||
| } catch (error) { | ||
| console.error(error); |
Contributor
There was a problem hiding this comment.
merge the PR #1467, and then change this to logger.error
|
|
||
| backupDone(); | ||
| } catch (backupErr) { | ||
| log( |
Collaborator
Author
There was a problem hiding this comment.
This log function wraps all console logs in the file, I even use it in PR #1467
Hirobreak
force-pushed
the
backup-progress
branch
from
1879315 to
49114cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.