new parameters in data transfer file #1471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieltigse
requested changes
Jun 16, 2020
| ? accountObj.recipientId.split('@') | ||
| : myAccount.recipientId.split('@'); | ||
| const accountId = accountObj ? accountObj.id : myAccount.id; | ||
| const signature = accountObj |
Contributor
There was a problem hiding this comment.
accountObj && accountObj.signature ? accountObj.signature : myAccount.signature
| checkDataStatus = async () => { | ||
| const { status, body } = await getDataReady(myAccount.recipientId); | ||
| if (status === DATA_READY_STATUS) { | ||
| //here must exist a clear timeout |
Contributor
Author
There was a problem hiding this comment.
Not entirely sure, i will check again
Hirobreak
requested changes
Jun 16, 2020
| : myAccount.signature | ||
| : myAccount.signature; | ||
| const hasCriptextFooter = accountObj | ||
| ? accountObj.signFooter !== undefined |
javiteri95
force-pushed
the
newParametersDataTransfer
branch
from
84bf39e to
d06c900
Compare
javiteri95
force-pushed
the
newParametersDataTransfer
branch
from
d06c900 to
2dae608
Compare
danieltigse
approved these changes
Jun 18, 2020
Hirobreak
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new parameters in data transfer file