Update the discovery #187
Merged
Update the discovery #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oej
commented
Jun 18, 2025
oej
commented
- Add a note about avoiding guessing the TEI
- Add a note about "shared EAN codes" - those are not useful for creating unique TEIs for products that share EAN code. Each product needs a unique TEI.
Signed-off-by: Olle E. Johansson <[email protected]>
Signed-off-by: Olle E. Johansson <[email protected]>
madpah
reviewed
Jun 18, 2025
|
|
||
| The TEI can be shown in the software itself, in shipping documentation, in web pages and app stores. | ||
| TEI is unique for a product, not a version of a software. The TEI consist of three core parts | ||
| TEI is unique for a product, not a version of a product. |
Collaborator
There was a problem hiding this comment.
We also need to update the definition of Product in the beginning of this document as it does not cover physical (hardware) in my reading.
madpah
reviewed
Jun 18, 2025
Signed-off-by: Olle E. Johansson <[email protected]>
taleodor
reviewed
Jun 18, 2025
discovery/readme.md
Outdated
|
|
||
| ### TEI syntax | ||
|
|
||
| The TEI consist of three core parts |
Contributor
There was a problem hiding this comment.
consist -> consists (spelling)
Signed-off-by: Olle E. Johansson <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.