👷 fix MODULE_TYPELESS_PACKAGE_JSON warning

developer-extension/tsconfig.webpack.json

@@ -3,12 +3,14 @@
 
   "compilerOptions": {
     "baseUrl": ".",
-    "module": "ES6",
+    "module": "preserve",
     "target": "esnext",
     "jsx": "react",
     "lib": ["ES2022", "DOM"],
     "types": ["chrome", "react", "react-dom", "jasmine"],
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "allowImportingTsExtensions": true,
+    "noEmit": true
   },
 
   "include": ["src"]

eslint-local-rules/disallowEnumExports.js

@@ -1,4 +1,4 @@
-const { SymbolFlags } = require('typescript')
+import { SymbolFlags } from 'typescript'
 
 /**
  * This rule forbids exporting 'enums'.  It serves two purposes:
@@ -34,7 +34,7 @@ const { SymbolFlags } = require('typescript')
  * [1]: https://www.typescriptlang.org/tsconfig#isolatedModules
  * [2]: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export
  */
-module.exports = {
+export default {
   meta: {
     docs: {
       description: 'Disallow export of enums.',

eslint-local-rules/disallowGenericUtils.js

@@ -1,6 +1,6 @@
-const path = require('path')
+import path from 'path'
 
-module.exports = {
+export default {
   meta: {
     docs: {
       description: 'Disallow the use of too generic utility file names',

eslint-local-rules/disallowNonScripts.js

@@ -1,4 +1,4 @@
-module.exports = {
+export default {
   meta: {
     docs: {
       description: 'Disallow JS files that are not used as a "script"',

eslint-local-rules/disallowProtectedDirectoryImport.js

@@ -1,10 +1,15 @@
-const path = require('path')
-const { minimatch } = require('minimatch')
-const resolve = require('eslint-module-utils/resolve').default
-const moduleVisitor = require('eslint-module-utils/moduleVisitor').default
-const importType = require('eslint-plugin-import/lib/core/importType').default
+import path from 'node:path'
+import { minimatch } from 'minimatch'
 
-module.exports = {
+import resolvePackage from 'eslint-module-utils/resolve.js'
+import moduleVisitorPackage from 'eslint-module-utils/moduleVisitor.js'
+import importTypePackage from 'eslint-plugin-import/lib/core/importType.js'
+
+const moduleVisitor = moduleVisitorPackage.default
+const importType = importTypePackage.default
+const resolve = resolvePackage.default
+
+export default {
   meta: {
     docs: {
       description:

eslint-local-rules/disallowSideEffects.js

@@ -1,6 +1,6 @@
-const path = require('path')
+import path from 'path'
 
-module.exports = {
+export default {
   meta: {
     docs: {
       description:
@@ -22,7 +22,7 @@ module.exports = {
   },
 }
 
-const packagesRoot = path.resolve(__dirname, '..', 'packages')
+const packagesRoot = path.resolve(import.meta.dirname, '..', 'packages')
 
 // Those modules are known to have side effects when evaluated
 const pathsWithSideEffect = new Set([

eslint-local-rules/disallowSpecImport.js

@@ -1,4 +1,4 @@
-module.exports = {
+export default {
   meta: {
     docs: {
       description: 'Disallow importing spec file code to avoid to execute the tests from the imported spec file twice',

eslint-local-rules/disallowTestImportExportFromSrc.js

@@ -1,4 +1,4 @@
-module.exports = {
+export default {
   meta: {
     docs: {
       description:

eslint-local-rules/disallowUrlConstructorPatchValues.js

@@ -1,4 +1,4 @@
-module.exports = {
+export default {
   meta: {
     docs: {
       description: 'Disallow problematic URL constructor patched values.',

eslint-local-rules/disallowZoneJsPatchedValues.js

@@ -19,7 +19,7 @@ const PROBLEMATIC_IDENTIFIERS = {
   removeEventListener: 'Use `addEventListener().stop` from @datadog/browser-core instead',
 }
 
-module.exports = {
+export default {
   meta: {
     docs: {
       description: 'Disallow problematic ZoneJs patched values.',

eslint-local-rules/enforceProdDepsImports.js

@@ -1,7 +1,12 @@
-const fs = require('fs')
-const moduleVisitor = require('eslint-module-utils/moduleVisitor').default
-const importType = require('eslint-plugin-import/lib/core/importType').default
-const pkgUp = require('eslint-module-utils/pkgUp').default
+import fs from 'node:fs'
+
+import moduleVisitorPackage from 'eslint-module-utils/moduleVisitor.js'
+import importTypePackage from 'eslint-plugin-import/lib/core/importType.js'
+import pkgUpPackage from 'eslint-module-utils/pkgUp.js'
+
+const moduleVisitor = moduleVisitorPackage.default
+const pkgUp = pkgUpPackage.default
+const importType = importTypePackage.default
 
 // The import/no-extraneous-dependencies rule cannot catch this issue[1] where we imported an
 // aliased package in production code, because it resolves[2] the alias to the real package name, and
@@ -15,7 +20,7 @@ const pkgUp = require('eslint-module-utils/pkgUp').default
 
 const packageJsonCache = new Map()
 
-module.exports = {
+export default {
   meta: {
     docs: {
       description: 'Forbids importing non-prod dependencies in prod files',

eslint-local-rules/index.js

@@ -1,3 +1,16 @@
+import disallowSideEffects from './disallowSideEffects.js'
+import disallowEnumExports from './disallowEnumExports.js'
+import disallowSpecImport from './disallowSpecImport.js'
+import disallowProtectedDirectoryImport from './disallowProtectedDirectoryImport.js'
+import disallowTestImportExportFromSrc from './disallowTestImportExportFromSrc.js'
+import disallowZoneJsPatchedValues from './disallowZoneJsPatchedValues.js'
+import disallowUrlConstructorPatchValues from './disallowUrlConstructorPatchValues.js'
+import disallowGenericUtils from './disallowGenericUtils.js'
+import disallowNonScripts from './disallowNonScripts.js'
+import enforceProdDepsImports from './enforceProdDepsImports.js'
+import secureCommandExecution from './secureCommandExecution.js'
+import monitorUntilCommentRules from './monitorUntilCommentRules.js'
+
 // Declare the local rules used by the Browser SDK
 //
 // See https://eslint.org/docs/developer-guide/working-with-rules for documentation on how to write
@@ -6,17 +19,17 @@
 // You can use https://astexplorer.net/ to explore the parsed data structure of a code snippet.
 // Choose '@typescript-eslint/parser' as a parser to have the exact same structure as our ESLint
 // parser.
-module.exports = {
-  'disallow-side-effects': require('./disallowSideEffects'),
-  'disallow-enum-exports': require('./disallowEnumExports'),
-  'disallow-spec-import': require('./disallowSpecImport'),
-  'disallow-protected-directory-import': require('./disallowProtectedDirectoryImport'),
-  'disallow-test-import-export-from-src': require('./disallowTestImportExportFromSrc'),
-  'disallow-zone-js-patched-values': require('./disallowZoneJsPatchedValues'),
-  'disallow-url-constructor-patched-values': require('./disallowUrlConstructorPatchValues.js'),
-  'disallow-generic-utils': require('./disallowGenericUtils'),
-  'disallow-non-scripts': require('./disallowNonScripts'),
-  'enforce-prod-deps-imports': require('./enforceProdDepsImports.js'),
-  'secure-command-execution': require('./secureCommandExecution'),
-  ...require('./monitorUntilCommentRules'),
+export default {
+  'disallow-side-effects': disallowSideEffects,
+  'disallow-enum-exports': disallowEnumExports,
+  'disallow-spec-import': disallowSpecImport,
+  'disallow-protected-directory-import': disallowProtectedDirectoryImport,
+  'disallow-test-import-export-from-src': disallowTestImportExportFromSrc,
+  'disallow-zone-js-patched-values': disallowZoneJsPatchedValues,
+  'disallow-url-constructor-patched-values': disallowUrlConstructorPatchValues,
+  'disallow-generic-utils': disallowGenericUtils,
+  'disallow-non-scripts': disallowNonScripts,
+  'enforce-prod-deps-imports': enforceProdDepsImports,
+  'secure-command-execution': secureCommandExecution,
+  ...monitorUntilCommentRules,
 }

eslint-local-rules/monitorUntilCommentRules.js

@@ -1,7 +1,7 @@
 const METHODS_TO_CHECK = ['addTelemetryDebug', 'addTelemetryMetrics']
 const MONITOR_COMMENT_FORMAT = /^\s*monitor-until: (\d{4}-\d{2}-\d{2}|forever)/
 
-module.exports = {
+export default {
   'enforce-monitor-until-comment': {
     meta: {
       docs: {

eslint-local-rules/secureCommandExecution.js

@@ -1,4 +1,4 @@
-module.exports = {
+export default {
   meta: {
     docs: {
       description: 'Check command execution within nodejs scripts',

eslint.config.mjs

@@ -330,7 +330,7 @@ export default tseslint.config(
 
   {
     // JS files. Allow weaker typings since TS can't infer types as accurately as TS files.
-    files: ['**/*.js', '**/*.mjs'],
+    files: ['**/*.{js,mjs}'],
     rules: {
       '@typescript-eslint/no-unsafe-call': 'off',
       '@typescript-eslint/no-unsafe-return': 'off',
@@ -432,9 +432,9 @@ export default tseslint.config(
   },
 
   {
-    files: ['**/webpack.*.ts'],
+    files: ['**/webpack.*.{ts,mts}', 'eslint-local-rules/**/*.js'],
     rules: {
-      // Webpack configuration files are expected to use a default export.
+      // Webpack configuration files and eslint rules files are expected to use a default export.
       'import/no-default-export': 'off',
     },
   },

package.json

@@ -5,8 +5,10 @@
   "workspaces": [
     "packages/*",
     "developer-extension",
-    "performances"
+    "performances",
+    "test/e2e"
   ],
+  "type": "module",
   "scripts": {
     "postinstall": "scripts/cli init_submodule",
     "build": "lerna run build --stream",
@@ -15,7 +17,7 @@
     "build:docs:json": "typedoc --logLevel Verbose --json ./docs.json",
     "build:docs:html": "typedoc --out ./docs",
     "format": "prettier --check .",
-    "lint": "scripts/cli lint .",
+    "lint": "NODE_OPTIONS='--max-old-space-size=4096' eslint .",
     "typecheck": "tsc -b --noEmit true",
     "dev": "node scripts/dev-server.ts",
     "release": "scripts/cli release",

scripts/cli

@@ -26,11 +26,6 @@ cmd_typecheck () {
   tsc -p "$project_path" --noEmit true
 }
 
-cmd_lint () {
-  local project_path="${1}"
-  eslint "$project_path"
-}
-
 cmd_init_submodule () {
   git submodule update --init
 }

scripts/dev-server.ts

@@ -4,11 +4,11 @@ import HtmlWebpackPlugin from 'html-webpack-plugin'
 import webpack from 'webpack'
 import cors from 'cors'
 import webpackBase from '../webpack.base.ts'
-import logsConfig from '../packages/logs/webpack.config.ts'
-import rumSlimConfig from '../packages/rum-slim/webpack.config.ts'
-import rumConfig from '../packages/rum/webpack.config.ts'
-import flaggingConfig from '../packages/flagging/webpack.config.ts'
-import workerConfig from '../packages/worker/webpack.config.ts'
+import logsConfig from '../packages/logs/webpack.config.mts'
+import rumSlimConfig from '../packages/rum-slim/webpack.config.mts'
+import rumConfig from '../packages/rum/webpack.config.mts'
+import flaggingConfig from '../packages/flagging/webpack.config.mts'
+import workerConfig from '../packages/worker/webpack.config.mts'
 import { printLog, runMain } from './lib/executionUtils.ts'
 
 const sandboxPath = './sandbox'

test/e2e/lib/helpers/playwright.ts

@@ -1,7 +1,7 @@
 import type { PlaywrightWorkerOptions } from '@playwright/test'
 import type { BrowserConfiguration } from '../../../browsers.conf'
-import { getBuildInfos } from '../../../envUtils'
-import packageJson from '../../../../package.json'
+import { getBuildInfos } from '../../../envUtils.ts'
+import packageJson from '../../../../package.json' with { type: 'json' }
 
 export const DEV_SERVER_BASE_URL = 'http://localhost:8080'
 

test/e2e/package.json

@@ -0,0 +1,3 @@
+{
+  "private": true
+}

test/e2e/playwright.base.config.ts

@@ -30,8 +30,11 @@ export const config: Config = {
   use: {
     trace: isCi ? 'off' : 'retain-on-failure',
   },
+
   webServer: isLocal
     ? {
+        stdout: 'pipe',
+        cwd: path.join(__dirname, '../..'),
         command: 'yarn dev',
         url: DEV_SERVER_BASE_URL,
         reuseExistingServer: true,

test/e2e/tsconfig.json

@@ -8,9 +8,10 @@
     "moduleResolution": "node",
     "resolveJsonModule": true,
     "target": "ES2022",
-    "module": "ES2020",
+    "module": "preserve",
     "types": ["node", "ajv"],
     "allowJs": true,
-    "noEmit": true
+    "noEmit": true,
+    "allowImportingTsExtensions": true
   }
 }

test/envUtils.js → test/envUtils.ts

@@ -1,12 +1,12 @@
-const os = require('os')
+import os from 'os'
 
-function getIp() {
-  return Object.values(os.networkInterfaces())
+export function getIp() {
+  return (Object.values(os.networkInterfaces()) as os.NetworkInterfaceInfo[][])
     .flat()
-    .find(({ family, internal }) => family === 'IPv4' && !internal).address
+    .find(({ family, internal }) => family === 'IPv4' && !internal)!.address
 }
 
-function getBuildInfos() {
+export function getBuildInfos() {
   const ciInfos = getCIInfos()
   if (ciInfos) {
     return ciInfos
@@ -17,8 +17,8 @@ function getBuildInfos() {
   }
 }
 
-function getRunId() {
-  return process.env.CI_JOB_ID || process.env.USER
+export function getRunId() {
+  return process.env.CI_JOB_ID || process.env.USER || 'n/a'
 }
 
 function getCIInfos() {
@@ -32,24 +32,16 @@ function getLocalInfos() {
   return `${process.env.USER} ${new Date().toLocaleString()}`
 }
 
-function getTestReportDirectory() {
+export function getTestReportDirectory() {
   if (process.env.CI_JOB_NAME) {
     return `test-report/${process.env.CI_JOB_NAME}`
   }
 }
 
-function getCoverageReportDirectory() {
+export function getCoverageReportDirectory() {
   if (process.env.CI_JOB_NAME) {
     return `coverage/${process.env.CI_JOB_NAME}`
   }
 
   return 'coverage'
 }
-
-module.exports = {
-  getRunId,
-  getBuildInfos,
-  getIp,
-  getTestReportDirectory,
-  getCoverageReportDirectory,
-}

test/unit/browsers.conf.js → test/unit/browsers.conf.ts

@@ -1,9 +1,8 @@
 // Capabilities: https://www.browserstack.com/automate/capabilities
 
-/**
- * @type {Array<import('../browsers.conf').BrowserConfiguration>}
- */
-const browserConfigurations = [
+import type { BrowserConfiguration } from '../browsers.conf'
+
+export const browserConfigurations: BrowserConfiguration[] = [
   {
     sessionName: 'Edge',
     name: 'Edge',
@@ -47,7 +46,3 @@ const browserConfigurations = [
     device: 'iPhone 13',
   },
 ]
-
-module.exports = {
-  browserConfigurations,
-}