Skip to content

Conversation

@rgaignault
Copy link
Contributor

@rgaignault rgaignault commented Oct 21, 2025

Motivation

This PR extends the existing GraphQL tracking to capture GraphQL response errors, allowing developers to monitor server-side errors in their GraphQL queries
See spec for more informations : Graphql Spec

Changes

  • New trackResponseErrors option in GraphQL configuration
  • Extraction of GraphQL errors from HTTP responses (fetch and XHR)
  • Addition of telemetry for usage
  • E2E tests

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@rgaignault rgaignault requested a review from a team as a code owner October 21, 2025 09:25
@rgaignault rgaignault marked this pull request as draft October 21, 2025 09:25
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Oct 21, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 162.96 KiB 164.06 KiB +1.10 KiB +0.68%
Rum Recorder 19.78 KiB 19.78 KiB 0 B 0.00%
Rum Profiler 4.89 KiB 4.89 KiB 0 B 0.00%
Logs 56.62 KiB 56.34 KiB -292 B -0.50%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 119.90 KiB 121.14 KiB +1.24 KiB +1.03%
Worker 23.60 KiB 23.63 KiB +28 B +0.12%
🚀 CPU Performance

Pending...

🧠 Memory Performance

Pending...

🔗 RealWorld

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Oct 21, 2025

⚠️ Tests

⚠️ Warnings

❄️ 2 New flaky tests detected

cookie getCurrentSite caches the result from Safari 12.1.2 (Mac OS 10.14.6) (Datadog)
Expected spy cookie to have been called 2 times. It was called 0 times.
<Jasmine>
webpack:///packages/core/src/browser/cookie.spec.ts:50:43 <- /tmp/_karma_webpack_706064/commons.js:58851:49
<Jasmine>
cookie getCurrentSite returns the eTLD+1 for foo.bar.baz.example.com from Safari 12.1.2 (Mac OS 10.14.6) (Datadog)
Expected 'foo.bar.baz.example.com' to be 'example.com'.
<Jasmine>
webpack:///packages/core/src/browser/cookie.spec.ts:24:61 <- /tmp/_karma_webpack_706064/commons.js:58831:108
<Jasmine>

ℹ️ Info

🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 96.51%
Total Coverage: 92.63% (+0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 17fc984 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@rgaignault rgaignault marked this pull request as ready for review October 22, 2025 13:08
@rgaignault
Copy link
Contributor Author

@codex please review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants