feat!: add --head-sha to better control force pushes #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
|
|
||
| const createBranch = process.env["INPUT_CREATE-BRANCH"] || "false" | ||
| if(!["true", "false"].includes(createBranch.toLowerCase())) { | ||
| console.error(`Invalid value for create-branch (${createBranch}). Must be one of true or false.`); |
There was a problem hiding this comment.
🟠 Medium: Code Quality Violation
Unexpected console statement. (...read more)
Debugging with console (such as console.log or console.info) is not considered a bad practice, but these statements can be accidentally left in production code, leading to unnecessary log pollution. It is important to remove or replace these debugging statements to maintain clean and secure production builds.
To avoid potentially overwriting changes on the remote, allow callers to specify `--head-sha` (defaulting to the current HEAD on the remote, which is the previous behavior). This mitigates issues with potentially overwriting remote changes on long running jobs or active branches, particularly with jobs that rewrite file contents (such as lint fixes / auto formatting). - Replace --branch-from=<sha> with the pair of --head-sha=<sha> and --create-branch - Skip fetching current remote HEAD if --head-sha is supplied
avidal
force-pushed
the
require-head-sha
branch
from
e72b033 to
9c5a67e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid potentially overwriting changes on the remote, allow callers to specify
--head-sha(defaulting to the current HEAD on the remote, which is the previous behavior). This mitigates issues with potentially overwriting remote changes on long running jobs or active branches, particularly with jobs that rewrite file contents (such as lint fixes / auto formatting).