Skip to content

Conversation

@michalsrutek
Copy link
Contributor

What and why?

Adds Sendable conformance to Reflector.Error.Context and ReflectionMirror.Path to mitigate warnings.

🖼️

Screenshot 2025-10-06 at 15 44 35

How?

By conforming to the Sendable protocol.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines (internal) and run make api-surface)

@michalsrutek michalsrutek requested review from a team as code owners October 6, 2025 13:54
@michalsrutek michalsrutek changed the title Add Sendable conformance [NO-JIRA] Add Sendable conformance to fix a couple of warnings Oct 6, 2025
Copy link
Contributor

@gonzalezreal gonzalezreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @michalsrutek! The changes look good to me. 👍

However, we require verified commit signatures before we can merge. Could you please sign your commit? You can find instructions here.

@gonzalezreal gonzalezreal added the awaiting response Waiting for response / confirmation from the reporter label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting response Waiting for response / confirmation from the reporter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants