-
Couldn't load subscription status.
- Fork 160
RUM-11470: Report Time to full display #2522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-11470: Report Time to full display #2522
Conversation
745284c to
263e0f4
Compare
7fd41a6 to
7f87147
Compare
43d26f0 to
12039d4
Compare
7f87147 to
a9d015c
Compare
This comment has been minimized.
This comment has been minimized.
a9d015c to
14c7a7b
Compare
14c7a7b to
bbbab7f
Compare
DatadogRUM/Tests/RUMMonitor/Scopes/RUMAppLaunchManagerTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, otherwise looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I left a minor question.
I have a larger suggestion (maybe it's planned for further PR): The TTID and TTDF would deserve coverage in IntergrationTests. Both in Units, using @ncreated's framework to build different app launch scenarios, and in UI Tests which will start an actual host app. Is this planned?
8d8fa07 to
a56c917
Compare
What and why?
This PR introduces a new app launch metric: Time to Full Display (TTFD).
It follows the proposal outlined in the internal RFC.
How?
It introduces a new public interface to report that the app is fully interactive:
The TTFD logic is centralized in the
RUMAppLaunchManagerthat:RUMVitalEvent.isPrewarmedvalue.Review checklist
make api-surface)