Skip to content

update spotless to v6.13.0 #6922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 16, 2024
Merged

update spotless to v6.13.0 #6922

merged 4 commits into from
Apr 16, 2024

Conversation

@am312
Copy link
Contributor

@am312 am312 commented Apr 16, 2024 •
edited
Loading

What Does This Do

Updates spotless plugin v6.11.0 -> v6.13.0

Motivation

v6.13.0 is the last version usable w/JDK-8. v6.14.1 requires JDK-11+

@am312 am312 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Apr 16, 2024
@am312 am312 requested a review from a team as a code owner April 16, 2024 13:05
@am312 am312 requested review from PerfectSlayer and dougqh April 16, 2024 13:05
PerfectSlayer
PerfectSlayer requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update it for all the modules that use it?
I would rather have only one version used for the whole project. Thanks!

@pr-commenter
Copy link

pr-commenter bot commented Apr 16, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrew.munn/update-spotless-to-v6.13.0
git_commit_date 1713275901 1713281781
git_commit_sha 733e306 67543ea
release_version 1.33.0-SNAPSHOT~733e306ccf 1.33.0-SNAPSHOT~67543ea701
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1713284323 1713284323
ci_job_id 488121437 488121437
ci_pipeline_id 32216367 32216367
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.33.0-SNAPSHOT~67543ea701, baseline=1.33.0-SNAPSHOT~733e306ccf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080708
Total [baseline] (8.569 s) : 0, 8569119
Agent [candidate] (1.075 s) : 0, 1074955
Total [candidate] (8.586 s) : 0, 8586260
section iast
Agent [baseline] (1.198 s) : 0, 1198386
Total [baseline] (9.044 s) : 0, 9044162
Agent [candidate] (1.198 s) : 0, 1198233
Total [candidate] (9.057 s) : 0, 9057128
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.2 s) : 0, 1199849
Total [baseline] (8.985 s) : 0, 8985473
Agent [candidate] (1.2 s) : 0, 1200471
Total [candidate] (8.994 s) : 0, 8993812
section iast_TELEMETRY_OFF
Agent [baseline] (1.206 s) : 0, 1205954
Total [baseline] (9.082 s) : 0, 9081894
Agent [candidate] (1.198 s) : 0, 1197910
Total [candidate] (9.004 s) : 0, 9003606
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.198 s 117.678 ms (10.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.2 s 119.141 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.206 s 125.246 ms (11.6%)
Total tracing 8.569 s -
Total iast 9.044 s 475.043 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.985 s 416.354 ms (4.9%)
Total iast_TELEMETRY_OFF 9.082 s 512.774 ms (6.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent iast 1.198 s 123.278 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.2 s 125.516 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.198 s 122.955 ms (11.4%)
Total tracing 8.586 s -
Total iast 9.057 s 470.868 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.994 s 407.552 ms (4.7%)
Total iast_TELEMETRY_OFF 9.004 s 417.347 ms (4.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.33.0-SNAPSHOT~67543ea701, baseline=1.33.0-SNAPSHOT~733e306ccf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (677.338 ms) : 0, 677338
BytebuddyAgent [candidate] (673.411 ms) : 0, 673411
GlobalTracer [baseline] (310.853 ms) : 0, 310853
GlobalTracer [candidate] (309.431 ms) : 0, 309431
AppSec [baseline] (49.718 ms) : 0, 49718
AppSec [candidate] (49.413 ms) : 0, 49413
Remote Config [baseline] (668.873 µs) : 0, 669
Remote Config [candidate] (661.916 µs) : 0, 662
Telemetry [baseline] (7.629 ms) : 0, 7629
Telemetry [candidate] (7.63 ms) : 0, 7630
section iast
BytebuddyAgent [baseline] (793.819 ms) : 0, 793819
BytebuddyAgent [candidate] (794.043 ms) : 0, 794043
GlobalTracer [baseline] (288.172 ms) : 0, 288172
GlobalTracer [candidate] (287.929 ms) : 0, 287929
AppSec [baseline] (51.007 ms) : 0, 51007
AppSec [candidate] (49.999 ms) : 0, 49999
IAST [baseline] (23.077 ms) : 0, 23077
IAST [candidate] (23.901 ms) : 0, 23901
Remote Config [baseline] (576.144 µs) : 0, 576
Remote Config [candidate] (574.055 µs) : 0, 574
Telemetry [baseline] (7.413 ms) : 0, 7413
Telemetry [candidate] (7.425 ms) : 0, 7425
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (794.894 ms) : 0, 794894
BytebuddyAgent [candidate] (795.352 ms) : 0, 795352
GlobalTracer [baseline] (288.317 ms) : 0, 288317
GlobalTracer [candidate] (288.832 ms) : 0, 288832
AppSec [baseline] (52.867 ms) : 0, 52867
AppSec [candidate] (48.632 ms) : 0, 48632
IAST [baseline] (21.311 ms) : 0, 21311
IAST [candidate] (24.69 ms) : 0, 24690
Remote Config [baseline] (577.186 µs) : 0, 577
Remote Config [candidate] (569.56 µs) : 0, 570
Telemetry [baseline] (7.397 ms) : 0, 7397
Telemetry [candidate] (7.966 ms) : 0, 7966
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (799.028 ms) : 0, 799028
BytebuddyAgent [candidate] (793.181 ms) : 0, 793181
GlobalTracer [baseline] (290.252 ms) : 0, 290252
GlobalTracer [candidate] (288.876 ms) : 0, 288876
AppSec [baseline] (49.933 ms) : 0, 49933
AppSec [candidate] (47.664 ms) : 0, 47664
IAST [baseline] (24.21 ms) : 0, 24210
IAST [candidate] (25.9 ms) : 0, 25900
Remote Config [baseline] (579.137 µs) : 0, 579
Remote Config [candidate] (583.222 µs) : 0, 583
Telemetry [baseline] (7.332 ms) : 0, 7332
Telemetry [candidate] (7.363 ms) : 0, 7363
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.33.0-SNAPSHOT~67543ea701, baseline=1.33.0-SNAPSHOT~733e306ccf

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1079203
Total [baseline] (10.398 s) : 0, 10397749
Agent [candidate] (1.076 s) : 0, 1075542
Total [candidate] (10.429 s) : 0, 10429297
section appsec
Agent [baseline] (1.2 s) : 0, 1199539
Total [baseline] (10.543 s) : 0, 10543298
Agent [candidate] (1.199 s) : 0, 1198801
Total [candidate] (10.479 s) : 0, 10478601
section iast
Agent [baseline] (1.209 s) : 0, 1208574
Total [baseline] (10.771 s) : 0, 10771137
Agent [candidate] (1.199 s) : 0, 1199386
Total [candidate] (10.761 s) : 0, 10761122
section profiling
Agent [baseline] (1.27 s) : 0, 1270478
Total [baseline] (10.686 s) : 0, 10685658
Agent [candidate] (1.278 s) : 0, 1277574
Total [candidate] (10.625 s) : 0, 10625472
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent appsec 1.2 s 120.336 ms (11.2%)
Agent iast 1.209 s 129.371 ms (12.0%)
Agent profiling 1.27 s 191.275 ms (17.7%)
Total tracing 10.398 s -
Total appsec 10.543 s 145.549 ms (1.4%)
Total iast 10.771 s 373.388 ms (3.6%)
Total profiling 10.686 s 287.909 ms (2.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent appsec 1.199 s 123.259 ms (11.5%)
Agent iast 1.199 s 123.844 ms (11.5%)
Agent profiling 1.278 s 202.031 ms (18.8%)
Total tracing 10.429 s -
Total appsec 10.479 s 49.303 ms (0.5%)
Total iast 10.761 s 331.824 ms (3.2%)
Total profiling 10.625 s 196.175 ms (1.9%) 
gantt
    title petclinic - break down per module: candidate=1.33.0-SNAPSHOT~67543ea701, baseline=1.33.0-SNAPSHOT~733e306ccf

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.885 ms) : 0, 674885
BytebuddyAgent [candidate] (673.585 ms) : 0, 673585
GlobalTracer [baseline] (311.64 ms) : 0, 311640
GlobalTracer [candidate] (309.945 ms) : 0, 309945
AppSec [baseline] (49.86 ms) : 0, 49860
AppSec [candidate] (49.357 ms) : 0, 49357
Remote Config [baseline] (667.579 µs) : 0, 668
Remote Config [candidate] (658.281 µs) : 0, 658
Telemetry [baseline] (7.662 ms) : 0, 7662
Telemetry [candidate] (7.597 ms) : 0, 7597
section appsec
BytebuddyAgent [baseline] (696.59 ms) : 0, 696590
BytebuddyAgent [candidate] (696.066 ms) : 0, 696066
GlobalTracer [baseline] (291.89 ms) : 0, 291890
GlobalTracer [candidate] (292.052 ms) : 0, 292052
AppSec [baseline] (149.667 ms) : 0, 149667
AppSec [candidate] (149.296 ms) : 0, 149296
IAST [baseline] (18.926 ms) : 0, 18926
IAST [candidate] (18.949 ms) : 0, 18949
Remote Config [baseline] (605.815 µs) : 0, 606
Remote Config [candidate] (612.786 µs) : 0, 613
Telemetry [baseline] (7.383 ms) : 0, 7383
Telemetry [candidate] (7.427 ms) : 0, 7427
section iast
BytebuddyAgent [baseline] (800.814 ms) : 0, 800814
BytebuddyAgent [candidate] (794.044 ms) : 0, 794044
GlobalTracer [baseline] (290.268 ms) : 0, 290268
GlobalTracer [candidate] (288.404 ms) : 0, 288404
AppSec [baseline] (49.266 ms) : 0, 49266
AppSec [candidate] (51.378 ms) : 0, 51378
IAST [baseline] (24.852 ms) : 0, 24852
IAST [candidate] (23.091 ms) : 0, 23091
Remote Config [baseline] (573.447 µs) : 0, 573
Remote Config [candidate] (574.096 µs) : 0, 574
Telemetry [baseline] (8.185 ms) : 0, 8185
Telemetry [candidate] (7.415 ms) : 0, 7415
section profiling
BytebuddyAgent [baseline] (678.87 ms) : 0, 678870
BytebuddyAgent [candidate] (682.292 ms) : 0, 682292
GlobalTracer [baseline] (380.846 ms) : 0, 380846
GlobalTracer [candidate] (382.766 ms) : 0, 382766
AppSec [baseline] (50.549 ms) : 0, 50549
AppSec [candidate] (50.749 ms) : 0, 50749
Remote Config [baseline] (740.046 µs) : 0, 740
Remote Config [candidate] (732.794 µs) : 0, 733
Telemetry [baseline] (7.438 ms) : 0, 7438
Telemetry [candidate] (7.52 ms) : 0, 7520
ProfilingAgent [baseline] (95.772 ms) : 0, 95772
ProfilingAgent [candidate] (96.861 ms) : 0, 96861
Profiling [baseline] (95.795 ms) : 0, 95795
Profiling [candidate] (96.884 ms) : 0, 96884
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-04-16T15:49:36 2024-04-16T15:56:23
git_branch master andrew.munn/update-spotless-to-v6.13.0
git_commit_date 1713275901 1713281781
git_commit_sha 733e306 67543ea
release_version 1.33.0-SNAPSHOT~733e306ccf 1.33.0-SNAPSHOT~67543ea701
start_time 2024-04-16T15:49:23 2024-04-16T15:56:10
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1713283327 1713283327
ci_job_id 488121438 488121438
ci_pipeline_id 32216367 32216367
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.33.0-SNAPSHOT~67543ea701, baseline=1.33.0-SNAPSHOT~733e306ccf
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.344 ms) : 1325, 1364
.   : milestone, 1344,
appsec (1.737 ms) : 1713, 1761
.   : milestone, 1737,
appsec_no_iast (1.714 ms) : 1689, 1740
.   : milestone, 1714,
iast (1.489 ms) : 1466, 1512
.   : milestone, 1489,
profiling (1.504 ms) : 1478, 1530
.   : milestone, 1504,
tracing (1.456 ms) : 1433, 1479
.   : milestone, 1456,
section candidate
no_agent (1.341 ms) : 1321, 1361
.   : milestone, 1341,
appsec (1.718 ms) : 1693, 1742
.   : milestone, 1718,
appsec_no_iast (1.738 ms) : 1714, 1761
.   : milestone, 1738,
iast (1.492 ms) : 1469, 1515
.   : milestone, 1492,
profiling (1.485 ms) : 1460, 1510
.   : milestone, 1485,
tracing (1.488 ms) : 1464, 1512
.   : milestone, 1488,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.344 ms [1.325 ms, 1.364 ms] -
appsec 1.737 ms [1.713 ms, 1.761 ms] 392.336 µs (29.2%)
appsec_no_iast 1.714 ms [1.689 ms, 1.74 ms] 369.905 µs (27.5%)
iast 1.489 ms [1.466 ms, 1.512 ms] 144.577 µs (10.8%)
profiling 1.504 ms [1.478 ms, 1.53 ms] 159.737 µs (11.9%)
tracing 1.456 ms [1.433 ms, 1.479 ms] 111.545 µs (8.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.341 ms [1.321 ms, 1.361 ms] -
appsec 1.718 ms [1.693 ms, 1.742 ms] 376.503 µs (28.1%)
appsec_no_iast 1.738 ms [1.714 ms, 1.761 ms] 396.756 µs (29.6%)
iast 1.492 ms [1.469 ms, 1.515 ms] 151.223 µs (11.3%)
profiling 1.485 ms [1.46 ms, 1.51 ms] 144.13 µs (10.7%)
tracing 1.488 ms [1.464 ms, 1.512 ms] 146.96 µs (11.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.33.0-SNAPSHOT~67543ea701, baseline=1.33.0-SNAPSHOT~733e306ccf
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.135 µs) : 348, 392
.   : milestone, 370,
iast (470.102 µs) : 449, 491
.   : milestone, 470,
iast_FULL (537.9 µs) : 517, 559
.   : milestone, 538,
iast_GLOBAL (503.811 µs) : 482, 525
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (473.929 µs) : 452, 496
.   : milestone, 474,
iast_INACTIVE (445.554 µs) : 424, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (469.725 µs) : 449, 490
.   : milestone, 470,
tracing (445.193 µs) : 424, 467
.   : milestone, 445,
section candidate
no_agent (366.58 µs) : 347, 386
.   : milestone, 367,
iast (473.183 µs) : 452, 494
.   : milestone, 473,
iast_FULL (537.566 µs) : 516, 559
.   : milestone, 538,
iast_GLOBAL (497.127 µs) : 475, 519
.   : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (472.7 µs) : 452, 494
.   : milestone, 473,
iast_INACTIVE (447.301 µs) : 426, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (467.867 µs) : 447, 488
.   : milestone, 468,
tracing (444.432 µs) : 424, 465
.   : milestone, 444,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.135 µs [348.293 µs, 391.976 µs] -
iast 470.102 µs [449.369 µs, 490.835 µs] 99.968 µs (27.0%)
iast_FULL 537.9 µs [516.926 µs, 558.875 µs] 167.766 µs (45.3%)
iast_GLOBAL 503.811 µs [482.228 µs, 525.393 µs] 133.676 µs (36.1%)
iast_HARDCODED_SECRET_DISABLED 473.929 µs [452.175 µs, 495.683 µs] 103.794 µs (28.0%)
iast_INACTIVE 445.554 µs [424.374 µs, 466.733 µs] 75.419 µs (20.4%)
iast_TELEMETRY_OFF 469.725 µs [449.215 µs, 490.235 µs] 99.59 µs (26.9%)
tracing 445.193 µs [423.78 µs, 466.606 µs] 75.058 µs (20.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.58 µs [347.069 µs, 386.09 µs] -
iast 473.183 µs [452.156 µs, 494.21 µs] 106.603 µs (29.1%)
iast_FULL 537.566 µs [516.415 µs, 558.718 µs] 170.987 µs (46.6%)
iast_GLOBAL 497.127 µs [475.175 µs, 519.08 µs] 130.548 µs (35.6%)
iast_HARDCODED_SECRET_DISABLED 472.7 µs [451.81 µs, 493.59 µs] 106.12 µs (28.9%)
iast_INACTIVE 447.301 µs [426.248 µs, 468.355 µs] 80.722 µs (22.0%)
iast_TELEMETRY_OFF 467.867 µs [447.405 µs, 488.329 µs] 101.287 µs (27.6%)
tracing 444.432 µs [424.284 µs, 464.58 µs] 77.852 µs (21.2%)

@am312 am312 requested a review from PerfectSlayer April 16, 2024 15:43
@am312
Copy link
Contributor Author

am312 commented Apr 16, 2024 •
edited
Loading

It would be great to define this plugin version somewhere globally.

PerfectSlayer
PerfectSlayer approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the new version everywhere 👍

It would be great to define this plugin version somewhere globally.

We do have something like java-deps.gradle from my memory. Can't it be use for this?

@am312 am312 merged commit 90a6e41 into master Apr 16, 2024
@am312 am312 deleted the andrew.munn/update-spotless-to-v6.13.0 branch April 16, 2024 17:53
@github-actions github-actions bot added this to the 1.33.0 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dougqh dougqh dougqh approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.33.0

Development

Successfully merging this pull request may close these issues.

4 participants

@am312 @dougqh @PerfectSlayer