Skip to content

Fix location for SSRF with Kong Unirest #8407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Fix location for SSRF with Kong Unirest #8407

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9a38fe
Fix location for SSRF with Kong Unirest
smola Feb 17, 2025
9a6673c
Merge branch 'master' into smola/exclude-kong-unirest
smola Feb 18, 2025
9e7eb1d
Merge branch 'master' into smola/exclude-kong-unirest
smola Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ter/src/main/resources/datadog/trace/instrumentation/iastinstrumenter/iast_exclusion.trie
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@
1 jva_cup.*
1 liquibase.*
1 kodo.*
2 kong.unirest.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify... why 2 and not 1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

# 2 = Iast Instrumenter allows and filter stacktrace

This is not really a false positive, just a location problem. We want to detect the SSRF vulnerability in the code that calls the HTTP client, not within the HTTP client itself. So propagation inside this code is good, but we want to filter out it from the stacktrace.

1 macromedia.*
1 Microsoft.*
1 nanoxml.*
Expand Down
Loading