-
Notifications
You must be signed in to change notification settings - Fork 314
fix: kotlin compiler daemon memory settings #8829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 15 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~258a605e2f5, baseline=1.50.0-SNAPSHOT~cd3218a06a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1018193
Total [baseline] (10.469 s) : 0, 10468640
Agent [candidate] (1.018 s) : 0, 1018346
Total [candidate] (10.478 s) : 0, 10478002
section appsec
Agent [baseline] (1.165 s) : 0, 1164737
Total [baseline] (10.715 s) : 0, 10714820
Agent [candidate] (1.168 s) : 0, 1167546
Total [candidate] (10.67 s) : 0, 10670260
section iast
Agent [baseline] (1.15 s) : 0, 1149502
Total [baseline] (10.836 s) : 0, 10836141
Agent [candidate] (1.158 s) : 0, 1157648
Total [candidate] (10.989 s) : 0, 10988634
section profiling
Agent [baseline] (1.276 s) : 0, 1275727
Total [baseline] (10.804 s) : 0, 10804101
Agent [candidate] (1.284 s) : 0, 1283580
Total [candidate] (10.816 s) : 0, 10816224
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~258a605e2f5, baseline=1.50.0-SNAPSHOT~cd3218a06a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.685 ms) : 0, 681685
BytebuddyAgent [candidate] (681.867 ms) : 0, 681867
GlobalTracer [baseline] (239.699 ms) : 0, 239699
GlobalTracer [candidate] (239.905 ms) : 0, 239905
AppSec [baseline] (54.417 ms) : 0, 54417
AppSec [candidate] (54.871 ms) : 0, 54871
Debugger [baseline] (8.276 ms) : 0, 8276
Debugger [candidate] (6.937 ms) : 0, 6937
Remote Config [baseline] (699.848 µs) : 0, 700
Remote Config [candidate] (705.876 µs) : 0, 706
Telemetry [baseline] (9.804 ms) : 0, 9804
Telemetry [candidate] (10.562 ms) : 0, 10562
section appsec
BytebuddyAgent [baseline] (702.94 ms) : 0, 702940
BytebuddyAgent [candidate] (704.407 ms) : 0, 704407
GlobalTracer [baseline] (237.221 ms) : 0, 237221
GlobalTracer [candidate] (237.828 ms) : 0, 237828
AppSec [baseline] (175.744 ms) : 0, 175744
AppSec [candidate] (176.34 ms) : 0, 176340
Debugger [baseline] (5.932 ms) : 0, 5932
Debugger [candidate] (5.987 ms) : 0, 5987
Remote Config [baseline] (631.496 µs) : 0, 631
Remote Config [candidate] (630.403 µs) : 0, 630
Telemetry [baseline] (7.715 ms) : 0, 7715
Telemetry [candidate] (7.797 ms) : 0, 7797
IAST [baseline] (21.854 ms) : 0, 21854
IAST [candidate] (21.82 ms) : 0, 21820
section iast
BytebuddyAgent [baseline] (802.632 ms) : 0, 802632
BytebuddyAgent [candidate] (808.632 ms) : 0, 808632
GlobalTracer [baseline] (230.556 ms) : 0, 230556
GlobalTracer [candidate] (232.206 ms) : 0, 232206
AppSec [baseline] (48.536 ms) : 0, 48536
AppSec [candidate] (51.128 ms) : 0, 51128
Debugger [baseline] (5.916 ms) : 0, 5916
Debugger [candidate] (5.892 ms) : 0, 5892
Remote Config [baseline] (591.181 µs) : 0, 591
Remote Config [candidate] (589.728 µs) : 0, 590
Telemetry [baseline] (7.843 ms) : 0, 7843
Telemetry [candidate] (7.88 ms) : 0, 7880
IAST [baseline] (29.143 ms) : 0, 29143
IAST [candidate] (27.691 ms) : 0, 27691
section profiling
BytebuddyAgent [baseline] (671.612 ms) : 0, 671612
BytebuddyAgent [candidate] (676.744 ms) : 0, 676744
GlobalTracer [baseline] (374.398 ms) : 0, 374398
GlobalTracer [candidate] (375.279 ms) : 0, 375279
AppSec [baseline] (61.741 ms) : 0, 61741
AppSec [candidate] (62.058 ms) : 0, 62058
Debugger [baseline] (6.234 ms) : 0, 6234
Debugger [candidate] (6.36 ms) : 0, 6360
Remote Config [baseline] (652.562 µs) : 0, 653
Remote Config [candidate] (656.917 µs) : 0, 657
Telemetry [baseline] (8.056 ms) : 0, 8056
Telemetry [candidate] (8.248 ms) : 0, 8248
ProfilingAgent [baseline] (102.475 ms) : 0, 102475
ProfilingAgent [candidate] (103.122 ms) : 0, 103122
Profiling [baseline] (102.5 ms) : 0, 102500
Profiling [candidate] (103.145 ms) : 0, 103145
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~258a605e2f5, baseline=1.50.0-SNAPSHOT~cd3218a06a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1021002
Total [baseline] (8.701 s) : 0, 8701325
Agent [candidate] (1.018 s) : 0, 1018357
Total [candidate] (8.644 s) : 0, 8643788
section iast
Agent [baseline] (1.163 s) : 0, 1163278
Total [baseline] (9.236 s) : 0, 9236109
Agent [candidate] (1.149 s) : 0, 1148540
Total [candidate] (9.273 s) : 0, 9272691
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.158 s) : 0, 1158308
Total [baseline] (9.257 s) : 0, 9257481
Agent [candidate] (1.166 s) : 0, 1165694
Total [candidate] (9.243 s) : 0, 9242609
section iast_TELEMETRY_OFF
Agent [baseline] (1.152 s) : 0, 1152229
Total [baseline] (9.245 s) : 0, 9245107
Agent [candidate] (1.142 s) : 0, 1141791
Total [candidate] (9.247 s) : 0, 9247058
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~258a605e2f5, baseline=1.50.0-SNAPSHOT~cd3218a06a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.926 ms) : 0, 682926
BytebuddyAgent [candidate] (682.226 ms) : 0, 682226
GlobalTracer [baseline] (240.946 ms) : 0, 240946
GlobalTracer [candidate] (240.178 ms) : 0, 240178
AppSec [baseline] (54.596 ms) : 0, 54596
AppSec [candidate] (54.338 ms) : 0, 54338
Debugger [baseline] (9.068 ms) : 0, 9068
Debugger [candidate] (7.58 ms) : 0, 7580
Remote Config [baseline] (724.111 µs) : 0, 724
Remote Config [candidate] (696.792 µs) : 0, 697
Telemetry [baseline] (9.175 ms) : 0, 9175
Telemetry [candidate] (9.718 ms) : 0, 9718
section iast
BytebuddyAgent [baseline] (812.708 ms) : 0, 812708
BytebuddyAgent [candidate] (801.723 ms) : 0, 801723
GlobalTracer [baseline] (232.914 ms) : 0, 232914
GlobalTracer [candidate] (230.432 ms) : 0, 230432
IAST [baseline] (28.025 ms) : 0, 28025
IAST [candidate] (29.388 ms) : 0, 29388
AppSec [baseline] (49.81 ms) : 0, 49810
AppSec [candidate] (49.236 ms) : 0, 49236
Debugger [baseline] (5.975 ms) : 0, 5975
Debugger [candidate] (5.852 ms) : 0, 5852
Remote Config [baseline] (612.824 µs) : 0, 613
Remote Config [candidate] (594.349 µs) : 0, 594
Telemetry [baseline] (7.97 ms) : 0, 7970
Telemetry [candidate] (7.81 ms) : 0, 7810
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (808.691 ms) : 0, 808691
BytebuddyAgent [candidate] (814.006 ms) : 0, 814006
GlobalTracer [baseline] (232.484 ms) : 0, 232484
GlobalTracer [candidate] (233.41 ms) : 0, 233410
IAST [baseline] (30.31 ms) : 0, 30310
IAST [candidate] (28.193 ms) : 0, 28193
AppSec [baseline] (48.644 ms) : 0, 48644
AppSec [candidate] (50.718 ms) : 0, 50718
Debugger [baseline] (5.895 ms) : 0, 5895
Debugger [candidate] (5.987 ms) : 0, 5987
Remote Config [baseline] (600.595 µs) : 0, 601
Remote Config [candidate] (614.159 µs) : 0, 614
Telemetry [baseline] (7.955 ms) : 0, 7955
Telemetry [candidate] (8.098 ms) : 0, 8098
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (803.668 ms) : 0, 803668
BytebuddyAgent [candidate] (796.083 ms) : 0, 796083
GlobalTracer [baseline] (231.762 ms) : 0, 231762
GlobalTracer [candidate] (229.868 ms) : 0, 229868
IAST [baseline] (23.337 ms) : 0, 23337
IAST [candidate] (23.108 ms) : 0, 23108
AppSec [baseline] (55.525 ms) : 0, 55525
AppSec [candidate] (54.136 ms) : 0, 54136
Debugger [baseline] (5.938 ms) : 0, 5938
Debugger [candidate] (5.94 ms) : 0, 5940
Remote Config [baseline] (593.354 µs) : 0, 593
Remote Config [candidate] (600.236 µs) : 0, 600
Telemetry [baseline] (7.741 ms) : 0, 7741
Telemetry [candidate] (7.768 ms) : 0, 7768
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 18 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~258a605e2f5, baseline=1.50.0-SNAPSHOT~cd3218a06a
dateFormat X
axisFormat %s
section baseline
no_agent (1.361 ms) : 1341, 1381
. : milestone, 1361,
appsec (1.737 ms) : 1714, 1760
. : milestone, 1737,
appsec_no_iast (1.741 ms) : 1718, 1764
. : milestone, 1741,
code_origins (1.66 ms) : 1632, 1688
. : milestone, 1660,
iast (1.514 ms) : 1490, 1539
. : milestone, 1514,
profiling (1.581 ms) : 1556, 1606
. : milestone, 1581,
tracing (1.5 ms) : 1475, 1525
. : milestone, 1500,
section candidate
no_agent (1.368 ms) : 1348, 1387
. : milestone, 1368,
appsec (1.741 ms) : 1717, 1765
. : milestone, 1741,
appsec_no_iast (1.723 ms) : 1700, 1746
. : milestone, 1723,
code_origins (1.663 ms) : 1635, 1690
. : milestone, 1663,
iast (1.511 ms) : 1488, 1535
. : milestone, 1511,
profiling (1.509 ms) : 1486, 1532
. : milestone, 1509,
tracing (1.504 ms) : 1479, 1529
. : milestone, 1504,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~258a605e2f5, baseline=1.50.0-SNAPSHOT~cd3218a06a
dateFormat X
axisFormat %s
section baseline
no_agent (375.892 µs) : 356, 395
. : milestone, 376,
iast (528.216 µs) : 505, 552
. : milestone, 528,
iast_FULL (731.361 µs) : 709, 753
. : milestone, 731,
iast_GLOBAL (560.153 µs) : 539, 582
. : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (523.689 µs) : 501, 546
. : milestone, 524,
iast_INACTIVE (464.037 µs) : 442, 486
. : milestone, 464,
iast_TELEMETRY_OFF (516.615 µs) : 493, 540
. : milestone, 517,
tracing (459.492 µs) : 437, 482
. : milestone, 459,
section candidate
no_agent (378.963 µs) : 359, 399
. : milestone, 379,
iast (535.729 µs) : 512, 559
. : milestone, 536,
iast_FULL (736.442 µs) : 715, 758
. : milestone, 736,
iast_GLOBAL (557.042 µs) : 535, 579
. : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (523.542 µs) : 501, 546
. : milestone, 524,
iast_INACTIVE (467.276 µs) : 445, 490
. : milestone, 467,
iast_TELEMETRY_OFF (496.732 µs) : 474, 520
. : milestone, 497,
tracing (459.056 µs) : 437, 482
. : milestone, 459,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~258a605e2f5, baseline=1.50.0-SNAPSHOT~cd3218a06a
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1492
. : milestone, 1480,
appsec (2.41 ms) : 2361, 2460
. : milestone, 2410,
iast (2.194 ms) : 2132, 2256
. : milestone, 2194,
iast_GLOBAL (2.233 ms) : 2170, 2295
. : milestone, 2233,
profiling (2.047 ms) : 1997, 2097
. : milestone, 2047,
tracing (2.028 ms) : 1979, 2076
. : milestone, 2028,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.413 ms) : 2364, 2463
. : milestone, 2413,
iast (2.188 ms) : 2126, 2250
. : milestone, 2188,
iast_GLOBAL (2.238 ms) : 2176, 2301
. : milestone, 2238,
profiling (2.526 ms) : 2344, 2708
. : milestone, 2526,
tracing (2.01 ms) : 1962, 2057
. : milestone, 2010,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~258a605e2f5, baseline=1.50.0-SNAPSHOT~cd3218a06a
dateFormat X
axisFormat %s
section baseline
no_agent (15.398 s) : 15398000, 15398000
. : milestone, 15398000,
appsec (15.111 s) : 15111000, 15111000
. : milestone, 15111000,
iast (18.514 s) : 18514000, 18514000
. : milestone, 18514000,
iast_GLOBAL (18.164 s) : 18164000, 18164000
. : milestone, 18164000,
profiling (15.054 s) : 15054000, 15054000
. : milestone, 15054000,
tracing (14.858 s) : 14858000, 14858000
. : milestone, 14858000,
section candidate
no_agent (15.479 s) : 15479000, 15479000
. : milestone, 15479000,
appsec (14.969 s) : 14969000, 14969000
. : milestone, 14969000,
iast (18.662 s) : 18662000, 18662000
. : milestone, 18662000,
iast_GLOBAL (17.965 s) : 17965000, 17965000
. : milestone, 17965000,
profiling (14.864 s) : 14864000, 14864000
. : milestone, 14864000,
tracing (14.932 s) : 14932000, 14932000
. : milestone, 14932000,
|
Also, avoid warning by explicitly opting in coroutines.
What Does This Do
JVM memory settings for the kotlin compiler daemon are now passed to the correct property.
Also, use parallel gc and explicitly opt in for coroutine api to avoid unnecessary opt-in warnings.
Follow-up to #8833
Motivation
Help fix CircleCI
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]