Skip to content

Conversation

@amarziali
Copy link
Contributor

@amarziali amarziali commented Jun 30, 2025

What Does This Do

Improves repository instrumentation structure according to the naming conventions.

Changes made:

  • create a top level akka folder
  • move akka-http under akka
  • merge akka-concurrent and akka-init into akka-actor-2.5 and move under akka

Motivation

Additional Notes

Contributor Checklist

Jira ticket: LANGPLAT-79

@amarziali amarziali requested review from a team as code owners June 30, 2025 07:52
@github-actions
Copy link
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@amarziali amarziali requested a review from PerfectSlayer June 30, 2025 07:52
@amarziali amarziali added tag: no release notes Changes to exclude from release notes type: refactoring inst: akka Akka instrumentation labels Jun 30, 2025
@amarziali amarziali force-pushed the andrea.marziali/repo-reorg branch from a148425 to 03800ba Compare June 30, 2025 08:05
@pr-commenter
Copy link

pr-commenter bot commented Jun 30, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/repo-reorg
git_commit_date 1752173281 1752227632
git_commit_sha ad6d6b9 f16dbb8
release_version 1.52.0-SNAPSHOT~ad6d6b9786 1.52.0-SNAPSHOT~f16dbb8bcf
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1752229538 1752229538
ci_job_id 1024659692 1024659692
ci_pipeline_id 70281464 70281464
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-sfr7rcpz 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-sfr7rcpz 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics.

Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~f16dbb8bcf, baseline=1.52.0-SNAPSHOT~ad6d6b9786

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (993.022 ms) : 0, 993022
Total [baseline] (10.59 s) : 0, 10589743
Agent [candidate] (995.22 ms) : 0, 995220
Total [candidate] (10.642 s) : 0, 10641769
section appsec
Agent [baseline] (1.171 s) : 0, 1171447
Total [baseline] (10.747 s) : 0, 10747348
Agent [candidate] (1.182 s) : 0, 1181976
Total [candidate] (10.773 s) : 0, 10773299
section iast
Agent [baseline] (1.135 s) : 0, 1135382
Total [baseline] (10.826 s) : 0, 10826261
Agent [candidate] (1.141 s) : 0, 1140828
Total [candidate] (10.912 s) : 0, 10911597
section profiling
Agent [baseline] (1.252 s) : 0, 1251637
Total [baseline] (10.955 s) : 0, 10955211
Agent [candidate] (1.242 s) : 0, 1242445
Total [candidate] (10.932 s) : 0, 10932299
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 993.022 ms -
Agent appsec 1.171 s 178.425 ms (18.0%)
Agent iast 1.135 s 142.36 ms (14.3%)
Agent profiling 1.252 s 258.615 ms (26.0%)
Total tracing 10.59 s -
Total appsec 10.747 s 157.605 ms (1.5%)
Total iast 10.826 s 236.518 ms (2.2%)
Total profiling 10.955 s 365.469 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 995.22 ms -
Agent appsec 1.182 s 186.756 ms (18.8%)
Agent iast 1.141 s 145.608 ms (14.6%)
Agent profiling 1.242 s 247.225 ms (24.8%)
Total tracing 10.642 s -
Total appsec 10.773 s 131.53 ms (1.2%)
Total iast 10.912 s 269.828 ms (2.5%)
Total profiling 10.932 s 290.53 ms (2.7%)
gantt
    title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~f16dbb8bcf, baseline=1.52.0-SNAPSHOT~ad6d6b9786

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.772 ms) : 0, 685772
BytebuddyAgent [candidate] (687.043 ms) : 0, 687043
GlobalTracer [baseline] (241.511 ms) : 0, 241511
GlobalTracer [candidate] (242.113 ms) : 0, 242113
AppSec [baseline] (30.174 ms) : 0, 30174
AppSec [candidate] (30.241 ms) : 0, 30241
Debugger [baseline] (5.947 ms) : 0, 5947
Debugger [candidate] (6.013 ms) : 0, 6013
Remote Config [baseline] (670.9 µs) : 0, 671
Remote Config [candidate] (673.857 µs) : 0, 674
Telemetry [baseline] (8.16 ms) : 0, 8160
Telemetry [candidate] (8.254 ms) : 0, 8254
section appsec
BytebuddyAgent [baseline] (709.091 ms) : 0, 709091
BytebuddyAgent [candidate] (715.431 ms) : 0, 715431
GlobalTracer [baseline] (234.654 ms) : 0, 234654
GlobalTracer [candidate] (236.354 ms) : 0, 236354
IAST [baseline] (23.54 ms) : 0, 23540
IAST [candidate] (23.586 ms) : 0, 23586
AppSec [baseline] (169.024 ms) : 0, 169024
AppSec [candidate] (171.231 ms) : 0, 171231
Debugger [baseline] (5.729 ms) : 0, 5729
Debugger [candidate] (5.743 ms) : 0, 5743
Remote Config [baseline] (607.195 µs) : 0, 607
Remote Config [candidate] (599.772 µs) : 0, 600
Telemetry [baseline] (8.077 ms) : 0, 8077
Telemetry [candidate] (8.015 ms) : 0, 8015
section iast
BytebuddyAgent [baseline] (808.614 ms) : 0, 808614
BytebuddyAgent [candidate] (813.382 ms) : 0, 813382
GlobalTracer [baseline] (233.196 ms) : 0, 233196
GlobalTracer [candidate] (233.706 ms) : 0, 233706
IAST [baseline] (28.412 ms) : 0, 28412
IAST [candidate] (25.736 ms) : 0, 25736
AppSec [baseline] (29.099 ms) : 0, 29099
AppSec [candidate] (31.878 ms) : 0, 31878
Debugger [baseline] (5.816 ms) : 0, 5816
Debugger [candidate] (6.659 ms) : 0, 6659
Remote Config [baseline] (596.612 µs) : 0, 597
Remote Config [candidate] (585.036 µs) : 0, 585
Telemetry [baseline] (8.047 ms) : 0, 8047
Telemetry [candidate] (7.981 ms) : 0, 7981
section profiling
BytebuddyAgent [baseline] (682.344 ms) : 0, 682344
BytebuddyAgent [candidate] (676.787 ms) : 0, 676787
GlobalTracer [baseline] (363.06 ms) : 0, 363060
GlobalTracer [candidate] (360.436 ms) : 0, 360436
AppSec [baseline] (32.485 ms) : 0, 32485
AppSec [candidate] (30.87 ms) : 0, 30870
Debugger [baseline] (11.515 ms) : 0, 11515
Debugger [candidate] (11.19 ms) : 0, 11190
Remote Config [baseline] (667.692 µs) : 0, 668
Remote Config [candidate] (661.17 µs) : 0, 661
Telemetry [baseline] (8.765 ms) : 0, 8765
Telemetry [candidate] (9.557 ms) : 0, 9557
ProfilingAgent [baseline] (103.907 ms) : 0, 103907
ProfilingAgent [candidate] (104.409 ms) : 0, 104409
Profiling [baseline] (103.931 ms) : 0, 103931
Profiling [candidate] (104.433 ms) : 0, 104433
Loading
Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~f16dbb8bcf, baseline=1.52.0-SNAPSHOT~ad6d6b9786

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (993.866 ms) : 0, 993866
Total [baseline] (8.581 s) : 0, 8581177
Agent [candidate] (997.359 ms) : 0, 997359
Total [candidate] (8.552 s) : 0, 8551691
section iast
Agent [baseline] (1.13 s) : 0, 1129545
Total [baseline] (9.247 s) : 0, 9247265
Agent [candidate] (1.141 s) : 0, 1141051
Total [candidate] (9.312 s) : 0, 9311881
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 993.866 ms -
Agent iast 1.13 s 135.679 ms (13.7%)
Total tracing 8.581 s -
Total iast 9.247 s 666.088 ms (7.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 997.359 ms -
Agent iast 1.141 s 143.692 ms (14.4%)
Total tracing 8.552 s -
Total iast 9.312 s 760.19 ms (8.9%)
gantt
    title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~f16dbb8bcf, baseline=1.52.0-SNAPSHOT~ad6d6b9786

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.803 ms) : 0, 686803
BytebuddyAgent [candidate] (688.534 ms) : 0, 688534
GlobalTracer [baseline] (241.282 ms) : 0, 241282
GlobalTracer [candidate] (242.716 ms) : 0, 242716
AppSec [baseline] (30.181 ms) : 0, 30181
AppSec [candidate] (30.383 ms) : 0, 30383
Debugger [baseline] (5.966 ms) : 0, 5966
Debugger [candidate] (6.02 ms) : 0, 6020
Remote Config [baseline] (676.045 µs) : 0, 676
Remote Config [candidate] (676.936 µs) : 0, 677
Telemetry [baseline] (8.257 ms) : 0, 8257
Telemetry [candidate] (8.189 ms) : 0, 8189
section iast
BytebuddyAgent [baseline] (805.897 ms) : 0, 805897
BytebuddyAgent [candidate] (814.365 ms) : 0, 814365
GlobalTracer [baseline] (231.496 ms) : 0, 231496
GlobalTracer [candidate] (233.053 ms) : 0, 233053
IAST [baseline] (28.701 ms) : 0, 28701
IAST [candidate] (27.584 ms) : 0, 27584
AppSec [baseline] (28.624 ms) : 0, 28624
AppSec [candidate] (30.758 ms) : 0, 30758
Debugger [baseline] (5.706 ms) : 0, 5706
Debugger [candidate] (5.777 ms) : 0, 5777
Remote Config [baseline] (580.805 µs) : 0, 581
Remote Config [candidate] (601.159 µs) : 0, 601
Telemetry [baseline] (7.885 ms) : 0, 7885
Telemetry [candidate] (8.007 ms) : 0, 8007
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/repo-reorg
git_commit_date 1752173281 1752227632
git_commit_sha ad6d6b9 f16dbb8
release_version 1.52.0-SNAPSHOT~ad6d6b9786 1.52.0-SNAPSHOT~f16dbb8bcf
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1752229222 1752229222
ci_job_id 1024659693 1024659693
ci_pipeline_id 70281464 70281464
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-x0eyxbbf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-x0eyxbbf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:no_agent:high_load better
[-304.721µs; -194.909µs] or [-6.794%; -4.345%]
unstable
[-51.764op/s; +169.514op/s] or [-5.056%; +16.557%]
4.235ms 1082.719op/s 4.485ms 1023.844op/s
scenario:load:insecure-bank:iast_GLOBAL:high_load worse
[+333.276µs; +740.919µs] or [+3.263%; +7.253%]
unstable
[-70.387op/s; +25.387op/s] or [-15.477%; +5.582%]
10.752ms 432.281op/s 10.215ms 454.781op/s
scenario:load:insecure-bank:profiling:high_load better
[-510.740µs; -212.263µs] or [-5.703%; -2.370%]
unstable
[-41.803op/s; +84.741op/s] or [-8.069%; +16.357%]
8.595ms 539.531op/s 8.956ms 518.062op/s
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~f16dbb8bcf, baseline=1.52.0-SNAPSHOT~ad6d6b9786
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.04 ms) : 36733, 37347
.   : milestone, 37040,
appsec (45.297 ms) : 44902, 45691
.   : milestone, 45297,
code_origins (44.445 ms) : 44064, 44826
.   : milestone, 44445,
iast (44.417 ms) : 44031, 44802
.   : milestone, 44417,
profiling (47.292 ms) : 46848, 47736
.   : milestone, 47292,
tracing (44.394 ms) : 44029, 44759
.   : milestone, 44394,
section candidate
no_agent (36.786 ms) : 36491, 37082
.   : milestone, 36786,
appsec (46.079 ms) : 45675, 46483
.   : milestone, 46079,
code_origins (44.467 ms) : 44101, 44833
.   : milestone, 44467,
iast (43.695 ms) : 43308, 44083
.   : milestone, 43695,
profiling (47.779 ms) : 47351, 48206
.   : milestone, 47779,
tracing (44.654 ms) : 44278, 45029
.   : milestone, 44654,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.04 ms [36.733 ms, 37.347 ms] -
appsec 45.297 ms [44.902 ms, 45.691 ms] 8.256 ms (22.3%)
code_origins 44.445 ms [44.064 ms, 44.826 ms] 7.405 ms (20.0%)
iast 44.417 ms [44.031 ms, 44.802 ms] 7.376 ms (19.9%)
profiling 47.292 ms [46.848 ms, 47.736 ms] 10.252 ms (27.7%)
tracing 44.394 ms [44.029 ms, 44.759 ms] 7.353 ms (19.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.786 ms [36.491 ms, 37.082 ms] -
appsec 46.079 ms [45.675 ms, 46.483 ms] 9.293 ms (25.3%)
code_origins 44.467 ms [44.101 ms, 44.833 ms] 7.681 ms (20.9%)
iast 43.695 ms [43.308 ms, 44.083 ms] 6.909 ms (18.8%)
profiling 47.779 ms [47.351 ms, 48.206 ms] 10.992 ms (29.9%)
tracing 44.654 ms [44.278 ms, 45.029 ms] 7.867 ms (21.4%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~f16dbb8bcf, baseline=1.52.0-SNAPSHOT~ad6d6b9786
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.485 ms) : 4432, 4539
.   : milestone, 4485,
iast (9.494 ms) : 9322, 9665
.   : milestone, 9494,
iast_FULL (13.754 ms) : 13482, 14026
.   : milestone, 13754,
iast_GLOBAL (10.215 ms) : 10037, 10393
.   : milestone, 10215,
profiling (8.956 ms) : 8819, 9094
.   : milestone, 8956,
tracing (7.556 ms) : 7442, 7670
.   : milestone, 7556,
section candidate
no_agent (4.235 ms) : 4187, 4284
.   : milestone, 4235,
iast (9.372 ms) : 9219, 9525
.   : milestone, 9372,
iast_FULL (13.92 ms) : 13648, 14193
.   : milestone, 13920,
iast_GLOBAL (10.752 ms) : 10552, 10952
.   : milestone, 10752,
profiling (8.595 ms) : 8455, 8735
.   : milestone, 8595,
tracing (7.436 ms) : 7324, 7548
.   : milestone, 7436,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.485 ms [4.432 ms, 4.539 ms] -
iast 9.494 ms [9.322 ms, 9.665 ms] 5.008 ms (111.7%)
iast_FULL 13.754 ms [13.482 ms, 14.026 ms] 9.269 ms (206.6%)
iast_GLOBAL 10.215 ms [10.037 ms, 10.393 ms] 5.73 ms (127.7%)
profiling 8.956 ms [8.819 ms, 9.094 ms] 4.471 ms (99.7%)
tracing 7.556 ms [7.442 ms, 7.67 ms] 3.071 ms (68.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.235 ms [4.187 ms, 4.284 ms] -
iast 9.372 ms [9.219 ms, 9.525 ms] 5.137 ms (121.3%)
iast_FULL 13.92 ms [13.648 ms, 14.193 ms] 9.685 ms (228.7%)
iast_GLOBAL 10.752 ms [10.552 ms, 10.952 ms] 6.517 ms (153.9%)
profiling 8.595 ms [8.455 ms, 8.735 ms] 4.359 ms (102.9%)
tracing 7.436 ms [7.324 ms, 7.548 ms] 3.2 ms (75.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/repo-reorg
git_commit_date 1752173281 1752227632
git_commit_sha ad6d6b9 f16dbb8
release_version 1.52.0-SNAPSHOT~ad6d6b9786 1.52.0-SNAPSHOT~f16dbb8bcf
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1752229702 1752229702
ci_job_id 1024659694 1024659694
ci_pipeline_id 70281464 70281464
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-0jmycgce 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-0jmycgce 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~f16dbb8bcf, baseline=1.52.0-SNAPSHOT~ad6d6b9786
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
.   : milestone, 1478,
appsec (2.405 ms) : 2356, 2455
.   : milestone, 2405,
iast (2.198 ms) : 2136, 2261
.   : milestone, 2198,
iast_GLOBAL (2.237 ms) : 2175, 2300
.   : milestone, 2237,
profiling (2.043 ms) : 1993, 2093
.   : milestone, 2043,
tracing (2.006 ms) : 1958, 2054
.   : milestone, 2006,
section candidate
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.411 ms) : 2362, 2461
.   : milestone, 2411,
iast (2.188 ms) : 2126, 2250
.   : milestone, 2188,
iast_GLOBAL (2.231 ms) : 2169, 2294
.   : milestone, 2231,
profiling (2.484 ms) : 2308, 2659
.   : milestone, 2484,
tracing (2.01 ms) : 1962, 2059
.   : milestone, 2010,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.478 ms [1.466 ms, 1.489 ms] -
appsec 2.405 ms [2.356 ms, 2.455 ms] 927.603 µs (62.8%)
iast 2.198 ms [2.136 ms, 2.261 ms] 720.813 µs (48.8%)
iast_GLOBAL 2.237 ms [2.175 ms, 2.3 ms] 759.694 µs (51.4%)
profiling 2.043 ms [1.993 ms, 2.093 ms] 565.158 µs (38.2%)
tracing 2.006 ms [1.958 ms, 2.054 ms] 528.373 µs (35.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.461 ms, 1.484 ms] -
appsec 2.411 ms [2.362 ms, 2.461 ms] 938.91 µs (63.8%)
iast 2.188 ms [2.126 ms, 2.25 ms] 715.821 µs (48.6%)
iast_GLOBAL 2.231 ms [2.169 ms, 2.294 ms] 759.033 µs (51.6%)
profiling 2.484 ms [2.308 ms, 2.659 ms] 1.011 ms (68.7%)
tracing 2.01 ms [1.962 ms, 2.059 ms] 537.895 µs (36.5%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~f16dbb8bcf, baseline=1.52.0-SNAPSHOT~ad6d6b9786
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.02 s) : 15020000, 15020000
.   : milestone, 15020000,
appsec (15.003 s) : 15003000, 15003000
.   : milestone, 15003000,
iast (18.723 s) : 18723000, 18723000
.   : milestone, 18723000,
iast_GLOBAL (17.688 s) : 17688000, 17688000
.   : milestone, 17688000,
profiling (14.921 s) : 14921000, 14921000
.   : milestone, 14921000,
tracing (14.635 s) : 14635000, 14635000
.   : milestone, 14635000,
section candidate
no_agent (14.983 s) : 14983000, 14983000
.   : milestone, 14983000,
appsec (14.97 s) : 14970000, 14970000
.   : milestone, 14970000,
iast (18.454 s) : 18454000, 18454000
.   : milestone, 18454000,
iast_GLOBAL (18.046 s) : 18046000, 18046000
.   : milestone, 18046000,
profiling (15.808 s) : 15808000, 15808000
.   : milestone, 15808000,
tracing (14.821 s) : 14821000, 14821000
.   : milestone, 14821000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.02 s [15.02 s, 15.02 s] -
appsec 15.003 s [15.003 s, 15.003 s] -17.0 ms (-0.1%)
iast 18.723 s [18.723 s, 18.723 s] 3.703 s (24.7%)
iast_GLOBAL 17.688 s [17.688 s, 17.688 s] 2.668 s (17.8%)
profiling 14.921 s [14.921 s, 14.921 s] -99.0 ms (-0.7%)
tracing 14.635 s [14.635 s, 14.635 s] -385.0 ms (-2.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.983 s [14.983 s, 14.983 s] -
appsec 14.97 s [14.97 s, 14.97 s] -13.0 ms (-0.1%)
iast 18.454 s [18.454 s, 18.454 s] 3.471 s (23.2%)
iast_GLOBAL 18.046 s [18.046 s, 18.046 s] 3.063 s (20.4%)
profiling 15.808 s [15.808 s, 15.808 s] 825.0 ms (5.5%)
tracing 14.821 s [14.821 s, 14.821 s] -162.0 ms (-1.1%)

Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would akka-http has its own sub-folder while play don't?
Do we want to always have both major and minor version for consistency? (eg play-ws-2 to play-ws-2.0)

Time for one-pager :)

@amarziali
Copy link
Contributor Author

Why would akka-http has its own sub-folder while play don't?

Play will but it's not part of this pull request. Let's keep the changes as little as we can

Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarziali amarziali force-pushed the andrea.marziali/repo-reorg branch from 03800ba to f16dbb8 Compare July 11, 2025 09:54
@amarziali amarziali merged commit 242a6c8 into master Jul 11, 2025
507 checks passed
@amarziali amarziali deleted the andrea.marziali/repo-reorg branch July 11, 2025 11:50
@github-actions github-actions bot added this to the 1.52.0 milestone Jul 11, 2025
mhlidd pushed a commit that referenced this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: akka Akka instrumentation tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants