-
Notifications
You must be signed in to change notification settings - Fork 315
Give more time to structured concurrency tests #9143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~690beb137f, baseline=1.52.0-SNAPSHOT~956f5703a5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (996.492 ms) : 0, 996492
Total [baseline] (8.604 s) : 0, 8604095
Agent [candidate] (999.985 ms) : 0, 999985
Total [candidate] (8.594 s) : 0, 8594354
section iast
Agent [baseline] (1.136 s) : 0, 1135847
Total [baseline] (9.354 s) : 0, 9354471
Agent [candidate] (1.133 s) : 0, 1132816
Total [candidate] (9.31 s) : 0, 9310465
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~690beb137f, baseline=1.52.0-SNAPSHOT~956f5703a5
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.35 ms) : 0, 689350
BytebuddyAgent [candidate] (690.269 ms) : 0, 690269
GlobalTracer [baseline] (241.434 ms) : 0, 241434
GlobalTracer [candidate] (243.182 ms) : 0, 243182
AppSec [baseline] (30.061 ms) : 0, 30061
AppSec [candidate] (30.562 ms) : 0, 30562
Debugger [baseline] (6.004 ms) : 0, 6004
Debugger [candidate] (6.023 ms) : 0, 6023
Remote Config [baseline] (687.903 µs) : 0, 688
Remote Config [candidate] (688.33 µs) : 0, 688
Telemetry [baseline] (8.21 ms) : 0, 8210
Telemetry [candidate] (8.268 ms) : 0, 8268
section iast
BytebuddyAgent [baseline] (808.874 ms) : 0, 808874
BytebuddyAgent [candidate] (807.813 ms) : 0, 807813
GlobalTracer [baseline] (233.712 ms) : 0, 233712
GlobalTracer [candidate] (231.787 ms) : 0, 231787
AppSec [baseline] (30.879 ms) : 0, 30879
AppSec [candidate] (28.334 ms) : 0, 28334
Debugger [baseline] (5.767 ms) : 0, 5767
Debugger [candidate] (7.547 ms) : 0, 7547
Remote Config [baseline] (594.916 µs) : 0, 595
Remote Config [candidate] (574.478 µs) : 0, 574
Telemetry [baseline] (7.978 ms) : 0, 7978
Telemetry [candidate] (7.992 ms) : 0, 7992
IAST [baseline] (27.15 ms) : 0, 27150
IAST [candidate] (27.926 ms) : 0, 27926
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~690beb137f, baseline=1.52.0-SNAPSHOT~956f5703a5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (995.543 ms) : 0, 995543
Total [baseline] (10.709 s) : 0, 10709171
Agent [candidate] (995.219 ms) : 0, 995219
Total [candidate] (10.658 s) : 0, 10658159
section appsec
Agent [baseline] (1.174 s) : 0, 1173619
Total [baseline] (10.775 s) : 0, 10775155
Agent [candidate] (1.177 s) : 0, 1176588
Total [candidate] (10.781 s) : 0, 10781323
section iast
Agent [baseline] (1.133 s) : 0, 1132841
Total [baseline] (10.817 s) : 0, 10816974
Agent [candidate] (1.132 s) : 0, 1131922
Total [candidate] (10.88 s) : 0, 10880444
section profiling
Agent [baseline] (1.259 s) : 0, 1259200
Total [baseline] (11.052 s) : 0, 11051500
Agent [candidate] (1.245 s) : 0, 1244559
Total [candidate] (10.984 s) : 0, 10983691
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~690beb137f, baseline=1.52.0-SNAPSHOT~956f5703a5
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.988 ms) : 0, 686988
BytebuddyAgent [candidate] (687.382 ms) : 0, 687382
GlobalTracer [baseline] (242.348 ms) : 0, 242348
GlobalTracer [candidate] (241.82 ms) : 0, 241820
AppSec [baseline] (30.27 ms) : 0, 30270
AppSec [candidate] (30.335 ms) : 0, 30335
Debugger [baseline] (6.028 ms) : 0, 6028
Debugger [candidate] (5.999 ms) : 0, 5999
Remote Config [baseline] (679.364 µs) : 0, 679
Remote Config [candidate] (685.462 µs) : 0, 685
Telemetry [baseline] (8.267 ms) : 0, 8267
Telemetry [candidate] (8.186 ms) : 0, 8186
section appsec
BytebuddyAgent [baseline] (709.202 ms) : 0, 709202
BytebuddyAgent [candidate] (711.685 ms) : 0, 711685
GlobalTracer [baseline] (235.042 ms) : 0, 235042
GlobalTracer [candidate] (235.146 ms) : 0, 235146
IAST [baseline] (23.205 ms) : 0, 23205
IAST [candidate] (23.256 ms) : 0, 23256
AppSec [baseline] (170.911 ms) : 0, 170911
AppSec [candidate] (171.146 ms) : 0, 171146
Debugger [baseline] (5.685 ms) : 0, 5685
Debugger [candidate] (5.701 ms) : 0, 5701
Remote Config [baseline] (604.253 µs) : 0, 604
Remote Config [candidate] (591.784 µs) : 0, 592
Telemetry [baseline] (8.046 ms) : 0, 8046
Telemetry [candidate] (8.076 ms) : 0, 8076
section iast
BytebuddyAgent [baseline] (807.633 ms) : 0, 807633
BytebuddyAgent [candidate] (807.083 ms) : 0, 807083
GlobalTracer [baseline] (232.335 ms) : 0, 232335
GlobalTracer [candidate] (232.357 ms) : 0, 232357
IAST [baseline] (28.672 ms) : 0, 28672
IAST [candidate] (27.783 ms) : 0, 27783
AppSec [baseline] (28.213 ms) : 0, 28213
AppSec [candidate] (29.635 ms) : 0, 29635
Debugger [baseline] (6.62 ms) : 0, 6620
Debugger [candidate] (5.719 ms) : 0, 5719
Remote Config [baseline] (597.519 µs) : 0, 598
Remote Config [candidate] (574.678 µs) : 0, 575
Telemetry [baseline] (7.962 ms) : 0, 7962
Telemetry [candidate] (7.965 ms) : 0, 7965
section profiling
BytebuddyAgent [baseline] (686.079 ms) : 0, 686079
BytebuddyAgent [candidate] (677.87 ms) : 0, 677870
GlobalTracer [baseline] (364.738 ms) : 0, 364738
GlobalTracer [candidate] (361.755 ms) : 0, 361755
AppSec [baseline] (33.395 ms) : 0, 33395
AppSec [candidate] (30.973 ms) : 0, 30973
Debugger [baseline] (10.724 ms) : 0, 10724
Debugger [candidate] (11.29 ms) : 0, 11290
Remote Config [baseline] (679.079 µs) : 0, 679
Remote Config [candidate] (657.861 µs) : 0, 658
Telemetry [baseline] (8.816 ms) : 0, 8816
Telemetry [candidate] (10.197 ms) : 0, 10197
ProfilingAgent [baseline] (105.625 ms) : 0, 105625
ProfilingAgent [candidate] (102.991 ms) : 0, 102991
Profiling [baseline] (105.649 ms) : 0, 105649
Profiling [candidate] (103.017 ms) : 0, 103017
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~690beb137f, baseline=1.52.0-SNAPSHOT~956f5703a5
dateFormat X
axisFormat %s
section baseline
no_agent (36.84 ms) : 36545, 37135
. : milestone, 36840,
appsec (45.74 ms) : 45342, 46137
. : milestone, 45740,
code_origins (45.996 ms) : 45593, 46399
. : milestone, 45996,
iast (44.416 ms) : 44030, 44802
. : milestone, 44416,
profiling (49.531 ms) : 49030, 50031
. : milestone, 49531,
tracing (42.163 ms) : 41802, 42524
. : milestone, 42163,
section candidate
no_agent (37.089 ms) : 36793, 37385
. : milestone, 37089,
appsec (48.948 ms) : 48512, 49384
. : milestone, 48948,
code_origins (45.072 ms) : 44684, 45461
. : milestone, 45072,
iast (44.339 ms) : 43960, 44717
. : milestone, 44339,
profiling (48.603 ms) : 48153, 49052
. : milestone, 48603,
tracing (42.419 ms) : 42060, 42778
. : milestone, 42419,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~690beb137f, baseline=1.52.0-SNAPSHOT~956f5703a5
dateFormat X
axisFormat %s
section baseline
no_agent (4.487 ms) : 4431, 4543
. : milestone, 4487,
iast (9.312 ms) : 9162, 9462
. : milestone, 9312,
iast_FULL (13.806 ms) : 13527, 14085
. : milestone, 13806,
iast_GLOBAL (10.127 ms) : 9948, 10307
. : milestone, 10127,
profiling (8.643 ms) : 8502, 8784
. : milestone, 8643,
tracing (7.359 ms) : 7251, 7467
. : milestone, 7359,
section candidate
no_agent (4.485 ms) : 4435, 4535
. : milestone, 4485,
iast (9.006 ms) : 8862, 9151
. : milestone, 9006,
iast_FULL (13.79 ms) : 13518, 14061
. : milestone, 13790,
iast_GLOBAL (10.137 ms) : 9959, 10315
. : milestone, 10137,
profiling (8.515 ms) : 8370, 8659
. : milestone, 8515,
tracing (7.987 ms) : 7859, 8115
. : milestone, 7987,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~690beb137f, baseline=1.52.0-SNAPSHOT~956f5703a5
dateFormat X
axisFormat %s
section baseline
no_agent (14.967 s) : 14967000, 14967000
. : milestone, 14967000,
appsec (14.726 s) : 14726000, 14726000
. : milestone, 14726000,
iast (18.51 s) : 18510000, 18510000
. : milestone, 18510000,
iast_GLOBAL (17.898 s) : 17898000, 17898000
. : milestone, 17898000,
profiling (15.144 s) : 15144000, 15144000
. : milestone, 15144000,
tracing (14.848 s) : 14848000, 14848000
. : milestone, 14848000,
section candidate
no_agent (14.928 s) : 14928000, 14928000
. : milestone, 14928000,
appsec (14.646 s) : 14646000, 14646000
. : milestone, 14646000,
iast (18.945 s) : 18945000, 18945000
. : milestone, 18945000,
iast_GLOBAL (17.82 s) : 17820000, 17820000
. : milestone, 17820000,
profiling (15.152 s) : 15152000, 15152000
. : milestone, 15152000,
tracing (14.709 s) : 14709000, 14709000
. : milestone, 14709000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~690beb137f, baseline=1.52.0-SNAPSHOT~956f5703a5
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1494
. : milestone, 1482,
appsec (2.428 ms) : 2378, 2478
. : milestone, 2428,
iast (2.215 ms) : 2153, 2278
. : milestone, 2215,
iast_GLOBAL (2.243 ms) : 2180, 2306
. : milestone, 2243,
profiling (2.067 ms) : 2016, 2118
. : milestone, 2067,
tracing (2.031 ms) : 1982, 2079
. : milestone, 2031,
section candidate
no_agent (1.485 ms) : 1473, 1496
. : milestone, 1485,
appsec (2.426 ms) : 2376, 2476
. : milestone, 2426,
iast (2.201 ms) : 2139, 2264
. : milestone, 2201,
iast_GLOBAL (2.256 ms) : 2193, 2319
. : milestone, 2256,
profiling (2.053 ms) : 2003, 2103
. : milestone, 2053,
tracing (2.023 ms) : 1975, 2071
. : milestone, 2023,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me
What Does This Do
Fixes the structured concurrency test that is failing quite often (expecially on 24.x)
I observed locally that the wait can time out. hence the parent span is reported before the child are finished and spans are dropped because of the strict write policy. Hence the test times out
We just give more time to the join (better always give a larger timeout even if it won't be reached...)
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]