-
Notifications
You must be signed in to change notification settings - Fork 315
Ignore jboss and quarkus smoke tests for JDK 24+ #9147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~2b0cb8827e, baseline=1.52.0-SNAPSHOT~90a02cea31
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.001 s) : 0, 1000914
Total [baseline] (10.598 s) : 0, 10597647
Agent [candidate] (1.002 s) : 0, 1002500
Total [candidate] (10.626 s) : 0, 10626092
section appsec
Agent [baseline] (1.175 s) : 0, 1175426
Total [baseline] (10.744 s) : 0, 10743516
Agent [candidate] (1.174 s) : 0, 1174498
Total [candidate] (10.74 s) : 0, 10739898
section iast
Agent [baseline] (1.132 s) : 0, 1131931
Total [baseline] (10.815 s) : 0, 10815128
Agent [candidate] (1.131 s) : 0, 1130918
Total [candidate] (10.789 s) : 0, 10789349
section profiling
Agent [baseline] (1.243 s) : 0, 1242808
Total [baseline] (11.001 s) : 0, 11000721
Agent [candidate] (1.251 s) : 0, 1250943
Total [candidate] (11.041 s) : 0, 11040678
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~2b0cb8827e, baseline=1.52.0-SNAPSHOT~90a02cea31
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.275 ms) : 0, 691275
BytebuddyAgent [candidate] (692.195 ms) : 0, 692195
GlobalTracer [baseline] (242.583 ms) : 0, 242583
GlobalTracer [candidate] (243.777 ms) : 0, 243777
AppSec [baseline] (30.526 ms) : 0, 30526
AppSec [candidate] (30.538 ms) : 0, 30538
Debugger [baseline] (5.999 ms) : 0, 5999
Debugger [candidate] (6.076 ms) : 0, 6076
Remote Config [baseline] (698.916 µs) : 0, 699
Remote Config [candidate] (703.322 µs) : 0, 703
Telemetry [baseline] (9.022 ms) : 0, 9022
Telemetry [candidate] (8.323 ms) : 0, 8323
section appsec
BytebuddyAgent [baseline] (710.652 ms) : 0, 710652
BytebuddyAgent [candidate] (709.966 ms) : 0, 709966
GlobalTracer [baseline] (235.008 ms) : 0, 235008
GlobalTracer [candidate] (234.616 ms) : 0, 234616
AppSec [baseline] (170.859 ms) : 0, 170859
AppSec [candidate] (171.091 ms) : 0, 171091
Debugger [baseline] (5.742 ms) : 0, 5742
Debugger [candidate] (5.704 ms) : 0, 5704
Remote Config [baseline] (605.168 µs) : 0, 605
Remote Config [candidate] (594.315 µs) : 0, 594
Telemetry [baseline] (8.101 ms) : 0, 8101
Telemetry [candidate] (8.052 ms) : 0, 8052
IAST [baseline] (23.538 ms) : 0, 23538
IAST [candidate] (23.504 ms) : 0, 23504
section iast
BytebuddyAgent [baseline] (806.024 ms) : 0, 806024
BytebuddyAgent [candidate] (806.524 ms) : 0, 806524
GlobalTracer [baseline] (232.897 ms) : 0, 232897
GlobalTracer [candidate] (231.957 ms) : 0, 231957
AppSec [baseline] (27.315 ms) : 0, 27315
AppSec [candidate] (29.332 ms) : 0, 29332
Debugger [baseline] (5.82 ms) : 0, 5820
Debugger [candidate] (5.73 ms) : 0, 5730
Remote Config [baseline] (591.115 µs) : 0, 591
Remote Config [candidate] (574.766 µs) : 0, 575
Telemetry [baseline] (7.999 ms) : 0, 7999
Telemetry [candidate] (7.889 ms) : 0, 7889
IAST [baseline] (30.497 ms) : 0, 30497
IAST [candidate] (28.147 ms) : 0, 28147
section profiling
BytebuddyAgent [baseline] (677.155 ms) : 0, 677155
BytebuddyAgent [candidate] (681.153 ms) : 0, 681153
GlobalTracer [baseline] (361.233 ms) : 0, 361233
GlobalTracer [candidate] (363.056 ms) : 0, 363056
AppSec [baseline] (31.419 ms) : 0, 31419
AppSec [candidate] (31.621 ms) : 0, 31621
Debugger [baseline] (11.32 ms) : 0, 11320
Debugger [candidate] (12.138 ms) : 0, 12138
Remote Config [baseline] (664.779 µs) : 0, 665
Remote Config [candidate] (668.475 µs) : 0, 668
Telemetry [baseline] (9.478 ms) : 0, 9478
Telemetry [candidate] (8.87 ms) : 0, 8870
ProfilingAgent [baseline] (102.893 ms) : 0, 102893
ProfilingAgent [candidate] (104.549 ms) : 0, 104549
Profiling [baseline] (102.917 ms) : 0, 102917
Profiling [candidate] (104.573 ms) : 0, 104573
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~2b0cb8827e, baseline=1.52.0-SNAPSHOT~90a02cea31
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.005 s) : 0, 1004657
Total [baseline] (8.609 s) : 0, 8608862
Agent [candidate] (994.869 ms) : 0, 994869
Total [candidate] (8.571 s) : 0, 8570910
section iast
Agent [baseline] (1.131 s) : 0, 1130633
Total [baseline] (9.308 s) : 0, 9308232
Agent [candidate] (1.138 s) : 0, 1138044
Total [candidate] (9.284 s) : 0, 9284293
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~2b0cb8827e, baseline=1.52.0-SNAPSHOT~90a02cea31
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (694.424 ms) : 0, 694424
BytebuddyAgent [candidate] (686.752 ms) : 0, 686752
GlobalTracer [baseline] (243.843 ms) : 0, 243843
GlobalTracer [candidate] (242.132 ms) : 0, 242132
AppSec [baseline] (30.38 ms) : 0, 30380
AppSec [candidate] (30.169 ms) : 0, 30169
Debugger [baseline] (6.033 ms) : 0, 6033
Debugger [candidate] (6.006 ms) : 0, 6006
Remote Config [baseline] (697.229 µs) : 0, 697
Remote Config [candidate] (681.397 µs) : 0, 681
Telemetry [baseline] (8.282 ms) : 0, 8282
Telemetry [candidate] (8.268 ms) : 0, 8268
section iast
BytebuddyAgent [baseline] (805.688 ms) : 0, 805688
BytebuddyAgent [candidate] (811.883 ms) : 0, 811883
GlobalTracer [baseline] (231.087 ms) : 0, 231087
GlobalTracer [candidate] (232.669 ms) : 0, 232669
AppSec [baseline] (31.003 ms) : 0, 31003
AppSec [candidate] (30.67 ms) : 0, 30670
Debugger [baseline] (6.713 ms) : 0, 6713
Debugger [candidate] (5.777 ms) : 0, 5777
Remote Config [baseline] (650.998 µs) : 0, 651
Remote Config [candidate] (593.906 µs) : 0, 594
Telemetry [baseline] (8.04 ms) : 0, 8040
Telemetry [candidate] (8.022 ms) : 0, 8022
IAST [baseline] (26.648 ms) : 0, 26648
IAST [candidate] (27.516 ms) : 0, 27516
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 4 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~2b0cb8827e, baseline=1.52.0-SNAPSHOT~90a02cea31
dateFormat X
axisFormat %s
section baseline
no_agent (4.308 ms) : 4251, 4365
. : milestone, 4308,
iast (9.235 ms) : 9084, 9386
. : milestone, 9235,
iast_FULL (14.002 ms) : 13729, 14274
. : milestone, 14002,
iast_GLOBAL (10.242 ms) : 10062, 10421
. : milestone, 10242,
profiling (8.854 ms) : 8707, 9001
. : milestone, 8854,
tracing (7.685 ms) : 7576, 7793
. : milestone, 7685,
section candidate
no_agent (4.548 ms) : 4496, 4600
. : milestone, 4548,
iast (9.468 ms) : 9313, 9622
. : milestone, 9468,
iast_FULL (13.653 ms) : 13383, 13922
. : milestone, 13653,
iast_GLOBAL (10.229 ms) : 10049, 10409
. : milestone, 10229,
profiling (8.447 ms) : 8321, 8573
. : milestone, 8447,
tracing (7.489 ms) : 7382, 7596
. : milestone, 7489,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~2b0cb8827e, baseline=1.52.0-SNAPSHOT~90a02cea31
dateFormat X
axisFormat %s
section baseline
no_agent (35.586 ms) : 35307, 35866
. : milestone, 35586,
appsec (46.627 ms) : 46222, 47033
. : milestone, 46627,
code_origins (44.358 ms) : 43986, 44730
. : milestone, 44358,
iast (45.195 ms) : 44808, 45582
. : milestone, 45195,
profiling (47.61 ms) : 47190, 48029
. : milestone, 47610,
tracing (42.285 ms) : 41941, 42629
. : milestone, 42285,
section candidate
no_agent (39.107 ms) : 38782, 39431
. : milestone, 39107,
appsec (46.903 ms) : 46474, 47331
. : milestone, 46903,
code_origins (46.497 ms) : 46097, 46896
. : milestone, 46497,
iast (42.701 ms) : 42324, 43078
. : milestone, 42701,
profiling (49.08 ms) : 48615, 49545
. : milestone, 49080,
tracing (42.609 ms) : 42252, 42966
. : milestone, 42609,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~2b0cb8827e, baseline=1.52.0-SNAPSHOT~90a02cea31
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (2.427 ms) : 2376, 2478
. : milestone, 2427,
iast (2.206 ms) : 2142, 2269
. : milestone, 2206,
iast_GLOBAL (2.26 ms) : 2196, 2324
. : milestone, 2260,
profiling (2.523 ms) : 2344, 2703
. : milestone, 2523,
tracing (2.026 ms) : 1977, 2076
. : milestone, 2026,
section candidate
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (2.434 ms) : 2383, 2485
. : milestone, 2434,
iast (2.215 ms) : 2152, 2279
. : milestone, 2215,
iast_GLOBAL (2.263 ms) : 2198, 2327
. : milestone, 2263,
profiling (2.065 ms) : 2014, 2117
. : milestone, 2065,
tracing (2.028 ms) : 1979, 2078
. : milestone, 2028,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~2b0cb8827e, baseline=1.52.0-SNAPSHOT~90a02cea31
dateFormat X
axisFormat %s
section baseline
no_agent (15.274 s) : 15274000, 15274000
. : milestone, 15274000,
appsec (14.782 s) : 14782000, 14782000
. : milestone, 14782000,
iast (18.178 s) : 18178000, 18178000
. : milestone, 18178000,
iast_GLOBAL (17.938 s) : 17938000, 17938000
. : milestone, 17938000,
profiling (15.69 s) : 15690000, 15690000
. : milestone, 15690000,
tracing (14.648 s) : 14648000, 14648000
. : milestone, 14648000,
section candidate
no_agent (15.207 s) : 15207000, 15207000
. : milestone, 15207000,
appsec (14.904 s) : 14904000, 14904000
. : milestone, 14904000,
iast (18.189 s) : 18189000, 18189000
. : milestone, 18189000,
iast_GLOBAL (18.21 s) : 18210000, 18210000
. : milestone, 18210000,
profiling (15.029 s) : 15029000, 15029000
. : milestone, 15029000,
tracing (15.038 s) : 15038000, 15038000
. : milestone, 15038000,
|
amarziali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Maybe we should have a reminder to activate them back when 25 is out and boss and quarkus support it? |
I think the problem with quarkus is that our smoke tests run a really old version (v1.9.2.Final) whereas even Java 21 is not officially supported until v3.5 (quarkus blog). Similarly, jboss v2 specifically tests v2.0.0.Final which was released about 4 years ago (mvnrepository). If testing with 25, we would probably need to write new smoke tests instead of reactivating. 😅 |
* Update jboss * Update quarkus
What Does This Do
Ignore jboss and quarkus smoke tests for JDK 24+
Motivation
They do not support JDK 24+
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]