- 
                Notifications
    You must be signed in to change notification settings 
- Fork 315
Improve InjectingPipe outputstream and writer #9176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to: 
 If you need help, please check our contributing guidelines. | 
| BenchmarksStartupParameters
 See matching parameters
 SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
    title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~bb035b0174, baseline=1.52.0-SNAPSHOT~785ce96272
    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (991.701 ms) : 0, 991701
Total [baseline] (8.576 s) : 0, 8575965
Agent [candidate] (1.001 s) : 0, 1000799
Total [candidate] (8.591 s) : 0, 8590703
section iast
Agent [baseline] (1.13 s) : 0, 1130446
Total [baseline] (9.264 s) : 0, 9264321
Agent [candidate] (1.137 s) : 0, 1136966
Total [candidate] (9.284 s) : 0, 9284263
 
 
 
 gantt
    title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~bb035b0174, baseline=1.52.0-SNAPSHOT~785ce96272
    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.506 ms) : 0, 684506
BytebuddyAgent [candidate] (690.615 ms) : 0, 690615
GlobalTracer [baseline] (241.16 ms) : 0, 241160
GlobalTracer [candidate] (243.508 ms) : 0, 243508
AppSec [baseline] (30.458 ms) : 0, 30458
AppSec [candidate] (30.774 ms) : 0, 30774
Debugger [baseline] (5.972 ms) : 0, 5972
Debugger [candidate] (6.076 ms) : 0, 6076
Remote Config [baseline] (670.538 µs) : 0, 671
Remote Config [candidate] (679.554 µs) : 0, 680
Telemetry [baseline] (8.195 ms) : 0, 8195
Telemetry [candidate] (8.272 ms) : 0, 8272
section iast
BytebuddyAgent [baseline] (804.697 ms) : 0, 804697
BytebuddyAgent [candidate] (810.853 ms) : 0, 810853
GlobalTracer [baseline] (232.336 ms) : 0, 232336
GlobalTracer [candidate] (232.535 ms) : 0, 232535
AppSec [baseline] (29.251 ms) : 0, 29251
AppSec [candidate] (29.95 ms) : 0, 29950
Debugger [baseline] (6.591 ms) : 0, 6591
Debugger [candidate] (5.764 ms) : 0, 5764
Remote Config [baseline] (588.693 µs) : 0, 589
Remote Config [candidate] (591.648 µs) : 0, 592
Telemetry [baseline] (7.869 ms) : 0, 7869
Telemetry [candidate] (8.016 ms) : 0, 8016
IAST [baseline] (28.317 ms) : 0, 28317
IAST [candidate] (28.306 ms) : 0, 28306
Startup time reports for petclinicgantt
    title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~bb035b0174, baseline=1.52.0-SNAPSHOT~785ce96272
    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.0 s) : 0, 1000155
Total [baseline] (10.605 s) : 0, 10604875
Agent [candidate] (1.0 s) : 0, 1000370
Total [candidate] (10.695 s) : 0, 10694847
section appsec
Agent [baseline] (1.174 s) : 0, 1173817
Total [baseline] (10.801 s) : 0, 10801461
Agent [candidate] (1.174 s) : 0, 1174103
Total [candidate] (10.739 s) : 0, 10739460
section iast
Agent [baseline] (1.14 s) : 0, 1139692
Total [baseline] (10.825 s) : 0, 10824670
Agent [candidate] (1.133 s) : 0, 1133174
Total [candidate] (10.798 s) : 0, 10797704
section profiling
Agent [baseline] (1.244 s) : 0, 1244258
Total [baseline] (11.009 s) : 0, 11009425
Agent [candidate] (1.244 s) : 0, 1244174
Total [candidate] (10.96 s) : 0, 10959593
 
 
 
 gantt
    title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~bb035b0174, baseline=1.52.0-SNAPSHOT~785ce96272
    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.25 ms) : 0, 690250
BytebuddyAgent [candidate] (690.127 ms) : 0, 690127
GlobalTracer [baseline] (243.243 ms) : 0, 243243
GlobalTracer [candidate] (243.656 ms) : 0, 243656
AppSec [baseline] (30.772 ms) : 0, 30772
AppSec [candidate] (30.565 ms) : 0, 30565
Debugger [baseline] (5.991 ms) : 0, 5991
Debugger [candidate] (6.071 ms) : 0, 6071
Remote Config [baseline] (678.135 µs) : 0, 678
Remote Config [candidate] (674.272 µs) : 0, 674
Telemetry [baseline] (8.223 ms) : 0, 8223
Telemetry [candidate] (8.287 ms) : 0, 8287
section appsec
BytebuddyAgent [baseline] (708.027 ms) : 0, 708027
BytebuddyAgent [candidate] (708.589 ms) : 0, 708589
GlobalTracer [baseline] (234.978 ms) : 0, 234978
GlobalTracer [candidate] (235.008 ms) : 0, 235008
AppSec [baseline] (171.741 ms) : 0, 171741
AppSec [candidate] (171.76 ms) : 0, 171760
Debugger [baseline] (5.776 ms) : 0, 5776
Debugger [candidate] (5.719 ms) : 0, 5719
Remote Config [baseline] (611.729 µs) : 0, 612
Remote Config [candidate] (601.959 µs) : 0, 602
Telemetry [baseline] (8.042 ms) : 0, 8042
Telemetry [candidate] (7.982 ms) : 0, 7982
IAST [baseline] (23.692 ms) : 0, 23692
IAST [candidate] (23.539 ms) : 0, 23539
section iast
BytebuddyAgent [baseline] (812.068 ms) : 0, 812068
BytebuddyAgent [candidate] (808.445 ms) : 0, 808445
GlobalTracer [baseline] (233.968 ms) : 0, 233968
GlobalTracer [candidate] (232.076 ms) : 0, 232076
AppSec [baseline] (28.229 ms) : 0, 28229
AppSec [candidate] (26.444 ms) : 0, 26444
Debugger [baseline] (5.84 ms) : 0, 5840
Debugger [candidate] (5.739 ms) : 0, 5739
Remote Config [baseline] (588.132 µs) : 0, 588
Remote Config [candidate] (576.639 µs) : 0, 577
Telemetry [baseline] (8.031 ms) : 0, 8031
Telemetry [candidate] (7.889 ms) : 0, 7889
IAST [baseline] (30.035 ms) : 0, 30035
IAST [candidate] (31.195 ms) : 0, 31195
section profiling
BytebuddyAgent [baseline] (675.657 ms) : 0, 675657
BytebuddyAgent [candidate] (676.677 ms) : 0, 676677
GlobalTracer [baseline] (362.569 ms) : 0, 362569
GlobalTracer [candidate] (361.707 ms) : 0, 361707
AppSec [baseline] (32.775 ms) : 0, 32775
AppSec [candidate] (31.903 ms) : 0, 31903
Debugger [baseline] (11.299 ms) : 0, 11299
Debugger [candidate] (12.686 ms) : 0, 12686
Remote Config [baseline] (664.478 µs) : 0, 664
Remote Config [candidate] (664.891 µs) : 0, 665
Telemetry [baseline] (8.119 ms) : 0, 8119
Telemetry [candidate] (8.047 ms) : 0, 8047
ProfilingAgent [baseline] (104.556 ms) : 0, 104556
ProfilingAgent [candidate] (103.734 ms) : 0, 103734
Profiling [baseline] (104.58 ms) : 0, 104580
Profiling [candidate] (103.758 ms) : 0, 103758
LoadParameters
 See matching parameters
 SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics. 
 Request duration reports for insecure-bankgantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~bb035b0174, baseline=1.52.0-SNAPSHOT~785ce96272
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.429 ms) : 4376, 4482
.   : milestone, 4429,
iast (9.277 ms) : 9127, 9428
.   : milestone, 9277,
iast_FULL (13.785 ms) : 13513, 14057
.   : milestone, 13785,
iast_GLOBAL (10.474 ms) : 10285, 10663
.   : milestone, 10474,
profiling (8.931 ms) : 8778, 9084
.   : milestone, 8931,
tracing (7.803 ms) : 7684, 7922
.   : milestone, 7803,
section candidate
no_agent (4.346 ms) : 4298, 4395
.   : milestone, 4346,
iast (9.199 ms) : 9048, 9351
.   : milestone, 9199,
iast_FULL (14.155 ms) : 13876, 14433
.   : milestone, 14155,
iast_GLOBAL (10.334 ms) : 10152, 10517
.   : milestone, 10334,
profiling (8.659 ms) : 8519, 8799
.   : milestone, 8659,
tracing (7.328 ms) : 7226, 7430
.   : milestone, 7328,
 
 
 
 Request duration reports for petclinicgantt
    title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~bb035b0174, baseline=1.52.0-SNAPSHOT~785ce96272
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.994 ms) : 37688, 38301
.   : milestone, 37994,
appsec (49.368 ms) : 48926, 49810
.   : milestone, 49368,
code_origins (45.92 ms) : 45531, 46308
.   : milestone, 45920,
iast (44.25 ms) : 43866, 44634
.   : milestone, 44250,
profiling (49.728 ms) : 49278, 50178
.   : milestone, 49728,
tracing (42.914 ms) : 42559, 43268
.   : milestone, 42914,
section candidate
no_agent (37.302 ms) : 37001, 37604
.   : milestone, 37302,
appsec (46.561 ms) : 46153, 46969
.   : milestone, 46561,
code_origins (46.294 ms) : 45889, 46700
.   : milestone, 46294,
iast (44.533 ms) : 44135, 44930
.   : milestone, 44533,
profiling (48.725 ms) : 48260, 49189
.   : milestone, 48725,
tracing (43.143 ms) : 42775, 43511
.   : milestone, 43143,
 
 
 
 DacapoParameters
 See matching parameters
 SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
    title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~bb035b0174, baseline=1.52.0-SNAPSHOT~785ce96272
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.978 s) : 14978000, 14978000
.   : milestone, 14978000,
appsec (14.674 s) : 14674000, 14674000
.   : milestone, 14674000,
iast (18.242 s) : 18242000, 18242000
.   : milestone, 18242000,
iast_GLOBAL (18.136 s) : 18136000, 18136000
.   : milestone, 18136000,
profiling (14.92 s) : 14920000, 14920000
.   : milestone, 14920000,
tracing (14.852 s) : 14852000, 14852000
.   : milestone, 14852000,
section candidate
no_agent (15.62 s) : 15620000, 15620000
.   : milestone, 15620000,
appsec (14.582 s) : 14582000, 14582000
.   : milestone, 14582000,
iast (18.375 s) : 18375000, 18375000
.   : milestone, 18375000,
iast_GLOBAL (18.136 s) : 18136000, 18136000
.   : milestone, 18136000,
profiling (14.868 s) : 14868000, 14868000
.   : milestone, 14868000,
tracing (15.146 s) : 15146000, 15146000
.   : milestone, 15146000,
 
 
 
 Execution time for tomcatgantt
    title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~bb035b0174, baseline=1.52.0-SNAPSHOT~785ce96272
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
.   : milestone, 1475,
appsec (2.386 ms) : 2337, 2436
.   : milestone, 2386,
iast (2.195 ms) : 2133, 2257
.   : milestone, 2195,
iast_GLOBAL (2.225 ms) : 2163, 2287
.   : milestone, 2225,
profiling (2.031 ms) : 1980, 2081
.   : milestone, 2031,
tracing (2.007 ms) : 1958, 2055
.   : milestone, 2007,
section candidate
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.406 ms) : 2356, 2456
.   : milestone, 2406,
iast (2.188 ms) : 2125, 2250
.   : milestone, 2188,
iast_GLOBAL (2.227 ms) : 2164, 2289
.   : milestone, 2227,
profiling (2.044 ms) : 1993, 2095
.   : milestone, 2044,
tracing (2.002 ms) : 1954, 2051
.   : milestone, 2002,
 
 
 
 | 
What Does This Do
Follow up of #9146
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]