Migrate Querying of Environment Variables to to `ConfigHelper` #9620

mhlidd · 2025-09-26T00:54:21Z

What Does This Do

This PR builds off of the Config Inversion implementation to migrate all querying of environment variables to utilize ConfigHelper instead of directly invoking the Environment component. Linter rules to restrict the direct invocation of the Environment component or undocumented String constants for environment variables (e.g. DD_ENV_VAR) are now enforced.

Classes that are excluded from this migration are bootstrap-related classes since there would be issues with the Logger being initialized too early. Furthermore, there are few configurations used in bootstrap and they are rarely modified.

Additionally, this PR introduces a NoOp implementation of the ConfigInversionMetricCollector to handle exceptions during build-time where the ConfigHelper is invoked but actual implementation has not been registered.

This PR also adds the environment variables that have been introduced since the initial commit of the metadata/supported-configurations.json file.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-09-30T18:01:00Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1759523392	1759523737
end_time	2025-10-03T20:31:14	2025-10-03T20:36:58
git_branch	master	mhlidd/migrate_to_config_helper
git_commit_sha	`6549d20`	`2401cfd`
start_time	2025-10-03T20:29:53	2025-10-03T20:35:38

See matching parameters

	Baseline	Candidate
ci_job_id	1163206872	1163206872
ci_pipeline_id	78362629	78362629
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1759522662	1759522662

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics.

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-35.555µs; +25.075µs] or [-12.448%; +8.779%]	unstable [-46.431µs; +37.610µs] or [-14.227%; +11.524%]	unstable [-57.500µs; +51.247µs] or [-16.825%; +14.996%]	unstable [-82.897µs; +153.660µs] or [-8.936%; +16.563%]	unstable [-95.557op/s; +155.779op/s] or [-3.918%; +6.387%]
scenario:basic	same	same	same	unstable [-67.955µs; +108.349µs] or [-9.326%; +14.869%]	unstable [-158.087op/s; +158.087op/s] or [-6.007%; +6.007%]
scenario:loop	unsure [+2.615µs; +9.362µs] or [+0.030%; +0.106%]	unsure [+14.125µs; +24.410µs] or [+0.158%; +0.273%]	unsure [+5.686µs; +16.565µs] or [+0.063%; +0.184%]	same	same

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (326.351 µs) : 290, 362
.   : milestone, 326,
basic (281.143 µs) : 275, 288
.   : milestone, 281,
loop (8.951 ms) : 8946, 8956
.   : milestone, 8951,
section candidate
noprobe (321.941 µs) : 278, 365
.   : milestone, 322,
basic (280.261 µs) : 274, 286
.   : milestone, 280,
loop (8.97 ms) : 8966, 8975
.   : milestone, 8970,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	326.351 µs [290.216 µs, 362.486 µs]
basic	281.143 µs [274.547 µs, 287.738 µs]
loop	8.951 ms [8.946 ms, 8.956 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	321.941 µs [278.422 µs, 365.46 µs]
basic	280.261 µs [274.214 µs, 286.309 µs]
loop	8.97 ms [8.966 ms, 8.975 ms]

datadog-datadog-prod-us1 · 2025-09-30T18:02:18Z

🎯 Code Coverage
• Patch Coverage: 30.77%
• Total Coverage: 59.69% (-0.03%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: f6c59b4 | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-09-30T18:16:08Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/migrate_to_config_helper
git_commit_date	1761156228	1761156605
git_commit_sha	`cd02b0c`	`f6c59b4`
release_version	1.55.0-SNAPSHOT~cd02b0c326	1.55.0-SNAPSHOT~f6c59b40f8

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1761158428	1761158428
ci_job_id	1192427603	1192427603
ci_pipeline_id	80006070	80006070
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-4-jmi8n9cw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-4-jmi8n9cw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~f6c59b40f8, baseline=1.55.0-SNAPSHOT~cd02b0c326

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1017655
Total [baseline] (10.647 s) : 0, 10646635
Agent [candidate] (1.03 s) : 0, 1029777
Total [candidate] (10.778 s) : 0, 10778449
section appsec
Agent [baseline] (1.2 s) : 0, 1200470
Total [baseline] (10.805 s) : 0, 10804938
Agent [candidate] (1.209 s) : 0, 1208778
Total [candidate] (10.939 s) : 0, 10938893
section iast
Agent [baseline] (1.159 s) : 0, 1159359
Total [baseline] (11.097 s) : 0, 11097053
Agent [candidate] (1.159 s) : 0, 1158589
Total [candidate] (11.07 s) : 0, 11069753
section profiling
Agent [baseline] (1.161 s) : 0, 1161239
Total [baseline] (10.833 s) : 0, 10832661
Agent [candidate] (1.17 s) : 0, 1169923
Total [candidate] (10.887 s) : 0, 10887193

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.018 s	-
Agent	appsec	1.2 s	182.816 ms (18.0%)
Agent	iast	1.159 s	141.705 ms (13.9%)
Agent	profiling	1.161 s	143.585 ms (14.1%)
Total	tracing	10.647 s	-
Total	appsec	10.805 s	158.304 ms (1.5%)
Total	iast	11.097 s	450.418 ms (4.2%)
Total	profiling	10.833 s	186.027 ms (1.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.03 s	-
Agent	appsec	1.209 s	179.001 ms (17.4%)
Agent	iast	1.159 s	128.812 ms (12.5%)
Agent	profiling	1.17 s	140.146 ms (13.6%)
Total	tracing	10.778 s	-
Total	appsec	10.939 s	160.444 ms (1.5%)
Total	iast	11.07 s	291.304 ms (2.7%)
Total	profiling	10.887 s	108.743 ms (1.0%)

gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~f6c59b40f8, baseline=1.55.0-SNAPSHOT~cd02b0c326

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (693.675 ms) : 0, 693675
BytebuddyAgent [candidate] (703.12 ms) : 0, 703120
GlobalTracer [baseline] (242.955 ms) : 0, 242955
GlobalTracer [candidate] (243.965 ms) : 0, 243965
AppSec [baseline] (32.082 ms) : 0, 32082
AppSec [candidate] (32.326 ms) : 0, 32326
Debugger [baseline] (6.287 ms) : 0, 6287
Debugger [candidate] (6.333 ms) : 0, 6333
Remote Config [baseline] (668.488 µs) : 0, 668
Remote Config [candidate] (665.095 µs) : 0, 665
Telemetry [baseline] (9.363 ms) : 0, 9363
Telemetry [candidate] (15.026 ms) : 0, 15026
Flare Poller [baseline] (10.075 ms) : 0, 10075
Flare Poller [candidate] (5.723 ms) : 0, 5723
section appsec
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (722.229 ms) : 0, 722229
BytebuddyAgent [candidate] (730.708 ms) : 0, 730708
GlobalTracer [baseline] (236.051 ms) : 0, 236051
GlobalTracer [candidate] (235.97 ms) : 0, 235970
AppSec [baseline] (174.243 ms) : 0, 174243
AppSec [candidate] (175.289 ms) : 0, 175289
Debugger [baseline] (6.128 ms) : 0, 6128
Debugger [candidate] (6.02 ms) : 0, 6020
Remote Config [baseline] (639.922 µs) : 0, 640
Remote Config [candidate] (617.672 µs) : 0, 618
Telemetry [baseline] (9.368 ms) : 0, 9368
Telemetry [candidate] (8.456 ms) : 0, 8456
Flare Poller [baseline] (3.982 ms) : 0, 3982
Flare Poller [candidate] (3.9 ms) : 0, 3900
IAST [baseline] (25.112 ms) : 0, 25112
IAST [candidate] (25.174 ms) : 0, 25174
section iast
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (821.559 ms) : 0, 821559
BytebuddyAgent [candidate] (822.194 ms) : 0, 822194
GlobalTracer [baseline] (232.83 ms) : 0, 232830
GlobalTracer [candidate] (232.714 ms) : 0, 232714
AppSec [baseline] (35.153 ms) : 0, 35153
AppSec [candidate] (30.575 ms) : 0, 30575
Debugger [baseline] (6.16 ms) : 0, 6160
Debugger [candidate] (6.166 ms) : 0, 6166
Remote Config [baseline] (612.97 µs) : 0, 613
Remote Config [candidate] (592.715 µs) : 0, 593
Telemetry [baseline] (8.805 ms) : 0, 8805
Telemetry [candidate] (8.465 ms) : 0, 8465
Flare Poller [baseline] (4.337 ms) : 0, 4337
Flare Poller [candidate] (4.164 ms) : 0, 4164
IAST [baseline] (26.899 ms) : 0, 26899
IAST [candidate] (30.946 ms) : 0, 30946
section profiling
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (718.498 ms) : 0, 718498
BytebuddyAgent [candidate] (725.55 ms) : 0, 725550
GlobalTracer [baseline] (218.326 ms) : 0, 218326
GlobalTracer [candidate] (218.53 ms) : 0, 218530
AppSec [baseline] (32.244 ms) : 0, 32244
AppSec [candidate] (32.182 ms) : 0, 32182
Debugger [baseline] (7.478 ms) : 0, 7478
Debugger [candidate] (8.288 ms) : 0, 8288
Remote Config [baseline] (673.167 µs) : 0, 673
Remote Config [candidate] (1.494 ms) : 0, 1494
Telemetry [baseline] (15.079 ms) : 0, 15079
Telemetry [candidate] (13.661 ms) : 0, 13661
Flare Poller [baseline] (4.1 ms) : 0, 4100
Flare Poller [candidate] (4.086 ms) : 0, 4086
ProfilingAgent [baseline] (109.614 ms) : 0, 109614
ProfilingAgent [candidate] (109.503 ms) : 0, 109503
Profiling [baseline] (110.26 ms) : 0, 110260
Profiling [candidate] (110.174 ms) : 0, 110174

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~f6c59b40f8, baseline=1.55.0-SNAPSHOT~cd02b0c326

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.016 s) : 0, 1015876
Total [baseline] (8.667 s) : 0, 8667457
Agent [candidate] (1.034 s) : 0, 1033795
Total [candidate] (8.654 s) : 0, 8654101
section iast
Agent [baseline] (1.147 s) : 0, 1146614
Total [baseline] (9.275 s) : 0, 9274825
Agent [candidate] (1.165 s) : 0, 1164970
Total [candidate] (9.382 s) : 0, 9381752

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.016 s	-
Agent	iast	1.147 s	130.738 ms (12.9%)
Total	tracing	8.667 s	-
Total	iast	9.275 s	607.367 ms (7.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.034 s	-
Agent	iast	1.165 s	131.175 ms (12.7%)
Total	tracing	8.654 s	-
Total	iast	9.382 s	727.651 ms (8.4%)

gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~f6c59b40f8, baseline=1.55.0-SNAPSHOT~cd02b0c326

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (693.276 ms) : 0, 693276
BytebuddyAgent [candidate] (705.479 ms) : 0, 705479
GlobalTracer [baseline] (241.989 ms) : 0, 241989
GlobalTracer [candidate] (244.919 ms) : 0, 244919
AppSec [baseline] (32.3 ms) : 0, 32300
AppSec [candidate] (32.481 ms) : 0, 32481
Debugger [baseline] (6.239 ms) : 0, 6239
Debugger [candidate] (6.419 ms) : 0, 6419
Remote Config [baseline] (674.343 µs) : 0, 674
Remote Config [candidate] (674.562 µs) : 0, 675
Telemetry [baseline] (9.266 ms) : 0, 9266
Telemetry [candidate] (14.345 ms) : 0, 14345
Flare Poller [baseline] (9.646 ms) : 0, 9646
Flare Poller [candidate] (6.773 ms) : 0, 6773
section iast
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (811.726 ms) : 0, 811726
BytebuddyAgent [candidate] (827.345 ms) : 0, 827345
GlobalTracer [baseline] (230.788 ms) : 0, 230788
GlobalTracer [candidate] (233.441 ms) : 0, 233441
AppSec [baseline] (34.804 ms) : 0, 34804
AppSec [candidate] (29.836 ms) : 0, 29836
Debugger [baseline] (6.193 ms) : 0, 6193
Debugger [candidate] (6.202 ms) : 0, 6202
Remote Config [baseline] (612.667 µs) : 0, 613
Remote Config [candidate] (603.445 µs) : 0, 603
Telemetry [baseline] (8.682 ms) : 0, 8682
Telemetry [candidate] (8.51 ms) : 0, 8510
Flare Poller [baseline] (4.286 ms) : 0, 4286
Flare Poller [candidate] (4.18 ms) : 0, 4180
IAST [baseline] (26.698 ms) : 0, 26698
IAST [candidate] (31.984 ms) : 0, 31984

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/migrate_to_config_helper
git_commit_date	1761156228	1761156605
git_commit_sha	`cd02b0c`	`f6c59b4`
release_version	1.55.0-SNAPSHOT~cd02b0c326	1.55.0-SNAPSHOT~f6c59b40f8

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1761158103	1761158103
ci_job_id	1192427604	1192427604
ci_pipeline_id	80006070	80006070
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-3-uqye4ery 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-3-uqye4ery 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:tracing:high_load	better [-519.433µs; -287.121µs] or [-6.761%; -3.737%]	unstable [-46.247op/s; +112.247op/s] or [-7.670%; +18.615%]	7.279ms	636.000op/s	7.683ms	603.000op/s
scenario:load:petclinic:no_agent:high_load	worse [+2.096ms; +2.741ms] or [+5.840%; +7.636%]	unstable [-17.046op/s; +0.596op/s] or [-13.083%; +0.458%]	38.318ms	122.062op/s	35.899ms	130.287op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~f6c59b40f8, baseline=1.55.0-SNAPSHOT~cd02b0c326
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.374 ms) : 4323, 4425
.   : milestone, 4374,
iast (9.557 ms) : 9400, 9714
.   : milestone, 9557,
iast_FULL (14.391 ms) : 14106, 14676
.   : milestone, 14391,
iast_GLOBAL (10.971 ms) : 10775, 11167
.   : milestone, 10971,
profiling (9.039 ms) : 8886, 9191
.   : milestone, 9039,
tracing (7.683 ms) : 7575, 7790
.   : milestone, 7683,
section candidate
no_agent (4.364 ms) : 4310, 4418
.   : milestone, 4364,
iast (9.761 ms) : 9589, 9932
.   : milestone, 9761,
iast_FULL (14.432 ms) : 14147, 14718
.   : milestone, 14432,
iast_GLOBAL (11.034 ms) : 10832, 11235
.   : milestone, 11034,
profiling (9.196 ms) : 9045, 9347
.   : milestone, 9196,
tracing (7.279 ms) : 7171, 7387
.   : milestone, 7279,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.374 ms [4.323 ms, 4.425 ms]	-
iast	9.557 ms [9.4 ms, 9.714 ms]	5.182 ms (118.5%)
iast_FULL	14.391 ms [14.106 ms, 14.676 ms]	10.016 ms (229.0%)
iast_GLOBAL	10.971 ms [10.775 ms, 11.167 ms]	6.596 ms (150.8%)
profiling	9.039 ms [8.886 ms, 9.191 ms]	4.664 ms (106.6%)
tracing	7.683 ms [7.575 ms, 7.79 ms]	3.308 ms (75.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.364 ms [4.31 ms, 4.418 ms]	-
iast	9.761 ms [9.589 ms, 9.932 ms]	5.397 ms (123.7%)
iast_FULL	14.432 ms [14.147 ms, 14.718 ms]	10.068 ms (230.7%)
iast_GLOBAL	11.034 ms [10.832 ms, 11.235 ms]	6.67 ms (152.8%)
profiling	9.196 ms [9.045 ms, 9.347 ms]	4.832 ms (110.7%)
tracing	7.279 ms [7.171 ms, 7.387 ms]	2.915 ms (66.8%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~f6c59b40f8, baseline=1.55.0-SNAPSHOT~cd02b0c326
    dateFormat X
    axisFormat %s
section baseline
no_agent (35.899 ms) : 35616, 36182
.   : milestone, 35899,
appsec (47.793 ms) : 47375, 48211
.   : milestone, 47793,
code_origins (43.244 ms) : 42873, 43616
.   : milestone, 43244,
iast (43.081 ms) : 42710, 43452
.   : milestone, 43081,
profiling (47.684 ms) : 47267, 48100
.   : milestone, 47684,
tracing (43.862 ms) : 43491, 44233
.   : milestone, 43862,
section candidate
no_agent (38.318 ms) : 38002, 38633
.   : milestone, 38318,
appsec (48.593 ms) : 48177, 49008
.   : milestone, 48593,
code_origins (44.134 ms) : 43750, 44518
.   : milestone, 44134,
iast (43.605 ms) : 43214, 43997
.   : milestone, 43605,
profiling (48.84 ms) : 48404, 49276
.   : milestone, 48840,
tracing (42.9 ms) : 42535, 43266
.   : milestone, 42900,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	35.899 ms [35.616 ms, 36.182 ms]	-
appsec	47.793 ms [47.375 ms, 48.211 ms]	11.895 ms (33.1%)
code_origins	43.244 ms [42.873 ms, 43.616 ms]	7.346 ms (20.5%)
iast	43.081 ms [42.71 ms, 43.452 ms]	7.182 ms (20.0%)
profiling	47.684 ms [47.267 ms, 48.1 ms]	11.785 ms (32.8%)
tracing	43.862 ms [43.491 ms, 44.233 ms]	7.963 ms (22.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	38.318 ms [38.002 ms, 38.633 ms]	-
appsec	48.593 ms [48.177 ms, 49.008 ms]	10.275 ms (26.8%)
code_origins	44.134 ms [43.75 ms, 44.518 ms]	5.816 ms (15.2%)
iast	43.605 ms [43.214 ms, 43.997 ms]	5.288 ms (13.8%)
profiling	48.84 ms [48.404 ms, 49.276 ms]	10.523 ms (27.5%)
tracing	42.9 ms [42.535 ms, 43.266 ms]	4.582 ms (12.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/migrate_to_config_helper
git_commit_date	1761156228	1761156605
git_commit_sha	`cd02b0c`	`f6c59b4`
release_version	1.55.0-SNAPSHOT~cd02b0c326	1.55.0-SNAPSHOT~f6c59b40f8

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1761158578	1761158578
ci_job_id	1192427605	1192427605
ci_pipeline_id	80006070	80006070
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-5-oppenoo6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-5-oppenoo6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~f6c59b40f8, baseline=1.55.0-SNAPSHOT~cd02b0c326
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.836 s) : 14836000, 14836000
.   : milestone, 14836000,
appsec (15.026 s) : 15026000, 15026000
.   : milestone, 15026000,
iast (18.752 s) : 18752000, 18752000
.   : milestone, 18752000,
iast_GLOBAL (17.69 s) : 17690000, 17690000
.   : milestone, 17690000,
profiling (15.195 s) : 15195000, 15195000
.   : milestone, 15195000,
tracing (15.253 s) : 15253000, 15253000
.   : milestone, 15253000,
section candidate
no_agent (14.962 s) : 14962000, 14962000
.   : milestone, 14962000,
appsec (14.97 s) : 14970000, 14970000
.   : milestone, 14970000,
iast (18.585 s) : 18585000, 18585000
.   : milestone, 18585000,
iast_GLOBAL (18.057 s) : 18057000, 18057000
.   : milestone, 18057000,
profiling (15.081 s) : 15081000, 15081000
.   : milestone, 15081000,
tracing (15.318 s) : 15318000, 15318000
.   : milestone, 15318000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.836 s [14.836 s, 14.836 s]	-
appsec	15.026 s [15.026 s, 15.026 s]	190.0 ms (1.3%)
iast	18.752 s [18.752 s, 18.752 s]	3.916 s (26.4%)
iast_GLOBAL	17.69 s [17.69 s, 17.69 s]	2.854 s (19.2%)
profiling	15.195 s [15.195 s, 15.195 s]	359.0 ms (2.4%)
tracing	15.253 s [15.253 s, 15.253 s]	417.0 ms (2.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.962 s [14.962 s, 14.962 s]	-
appsec	14.97 s [14.97 s, 14.97 s]	8.0 ms (0.1%)
iast	18.585 s [18.585 s, 18.585 s]	3.623 s (24.2%)
iast_GLOBAL	18.057 s [18.057 s, 18.057 s]	3.095 s (20.7%)
profiling	15.081 s [15.081 s, 15.081 s]	119.0 ms (0.8%)
tracing	15.318 s [15.318 s, 15.318 s]	356.0 ms (2.4%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~f6c59b40f8, baseline=1.55.0-SNAPSHOT~cd02b0c326
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (3.713 ms) : 3494, 3931
.   : milestone, 3713,
iast (2.208 ms) : 2144, 2271
.   : milestone, 2208,
iast_GLOBAL (2.251 ms) : 2187, 2316
.   : milestone, 2251,
profiling (2.055 ms) : 2003, 2107
.   : milestone, 2055,
tracing (2.021 ms) : 1971, 2070
.   : milestone, 2021,
section candidate
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (3.687 ms) : 3469, 3905
.   : milestone, 3687,
iast (2.211 ms) : 2147, 2274
.   : milestone, 2211,
iast_GLOBAL (2.253 ms) : 2189, 2317
.   : milestone, 2253,
profiling (2.055 ms) : 2004, 2106
.   : milestone, 2055,
tracing (2.022 ms) : 1973, 2072
.   : milestone, 2022,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.463 ms, 1.486 ms]	-
appsec	3.713 ms [3.494 ms, 3.931 ms]	2.238 ms (151.7%)
iast	2.208 ms [2.144 ms, 2.271 ms]	732.75 µs (49.7%)
iast_GLOBAL	2.251 ms [2.187 ms, 2.316 ms]	776.474 µs (52.6%)
profiling	2.055 ms [2.003 ms, 2.107 ms]	580.097 µs (39.3%)
tracing	2.021 ms [1.971 ms, 2.07 ms]	545.808 µs (37.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.463 ms, 1.486 ms]	-
appsec	3.687 ms [3.469 ms, 3.905 ms]	2.212 ms (150.1%)
iast	2.211 ms [2.147 ms, 2.274 ms]	736.107 µs (49.9%)
iast_GLOBAL	2.253 ms [2.189 ms, 2.317 ms]	778.289 µs (52.8%)
profiling	2.055 ms [2.004 ms, 2.106 ms]	580.608 µs (39.4%)
tracing	2.022 ms [1.973 ms, 2.072 ms]	547.872 µs (37.2%)

PerfectSlayer

So far it looks good. I left some comments along the review.

🎯 suggestion: The more I read usage of ConfigHelper, the more‏ I wonder if you should not introduce static helper methods as syntactic sugar like: ConfigHelper.env(String key) : String and ConfigHelper.env() : Map<String, String>.

public static String env(String key) {
  return get().getEnvironmentVariable(key); 
}

This would replace calls like:
ConfigHelper.get().getEnvironmentVariable("TMPDIR") and .map(ConfigHelper.get()::getEnvironmentVariable)
to
ConfigHelper.env("TMPDIR") and map(ConfigHelper::env)

WDYT?

components/environment/src/main/java/datadog/environment/EnvironmentVariables.java

dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/Constants.java

...entation-testing/src/main/java/datadog/trace/agent/test/BootstrapClasspathSetupListener.java

dd-java-agent/src/main/java6/datadog/trace/bootstrap/AgentPreCheck.java

gradle/forbiddenApiFilters/main.txt

...-utils/src/main/java/datadog/trace/api/telemetry/ConfigInversionMetricCollectorProvider.java

utils/container-utils/build.gradle.kts

mhlidd · 2025-10-03T19:40:41Z

🎯 suggestion: The more I read usage of ConfigHelper, the more‏ I wonder if you should not introduce static helper methods as syntactic sugar like: ConfigHelper.env(String key) : String and ConfigHelper.env() : Map<String, String>.

I think you mean I should introduce it 😄. But yes I agree this makes sense and is a lot more clear.

PerfectSlayer

I think you mean I should introduce it 😄. But yes I agree this makes sense and is a lot more clear.

Yes, sorry, it was a poor translation from my French 😓

👏 praise: ‏Thanks for the follow up changes! Everything looks great now ✨

utils/config-utils/src/main/java/datadog/trace/config/inversion/ConfigHelper.java

…ative test classes

github-actions · 2025-10-20T15:44:18Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

mhlidd changed the base branch from master to mhlidd/config_inversion_base September 26, 2025 00:54

mhlidd changed the title ~~Mhlidd/migrate to config helper~~ Migrate Querying of Environment Variables to to ConfigHelper Oct 2, 2025

mhlidd marked this pull request as ready for review October 2, 2025 17:56

mhlidd requested review from a team as code owners October 2, 2025 17:56

mhlidd requested review from AlexeyKuznetsov-DD, PerfectSlayer, daniel-mohedano, dougqh and mcculls and removed request for a team October 2, 2025 17:56

PerfectSlayer reviewed Oct 3, 2025

View reviewed changes

mhlidd requested a review from PerfectSlayer October 3, 2025 20:45

PerfectSlayer approved these changes Oct 6, 2025

View reviewed changes

utils/config-utils/src/main/java/datadog/trace/config/inversion/ConfigHelper.java Outdated Show resolved Hide resolved

mhlidd force-pushed the mhlidd/config_inversion_base branch from 63e5d5a to a257e6c Compare October 10, 2025 18:09

mhlidd requested review from a team as code owners October 10, 2025 18:09

mhlidd requested review from jpbempel and removed request for a team October 10, 2025 18:09

Base automatically changed from mhlidd/config_inversion_base to master October 10, 2025 19:29

AlexeyKuznetsov-DD and others added 3 commits October 20, 2025 11:28

Refactored EnvironmentVariables to be testable.

8e67f73

adding supported-configurations.json file

23f1998

removing extra supported-configurations.json

bdc2fd1

mhlidd added 7 commits October 20, 2025 11:41

adding to bootstrap classpath for testing

79fa0e2

bugfixes

a1cd8de

adding more configurations to supported-configurations and updating n…

2e776be

…ative test classes

fix native build and update telemetry test with clear error message

322f5ad

PR comments

58046e2

removing explicit dependency on environment component

a15efd0

responding to PR comments

dc61df4

mhlidd force-pushed the mhlidd/migrate_to_config_helper branch from 2401cfd to dc61df4 Compare October 20, 2025 15:44

mhlidd added type: enhancement Enhancements and improvements comp: core Tracer core comp: api Tracer public API labels Oct 20, 2025

mhlidd added 4 commits October 20, 2025 14:15

updating native loading

88713ee

Merge branch 'master' into mhlidd/migrate_to_config_helper

5614945

updating failing tests

a75b2e5

Merge branch 'master' into mhlidd/migrate_to_config_helper

04095ac

mhlidd requested a review from a team as a code owner October 21, 2025 19:57

mhlidd requested review from TonyCTHsu and removed request for a team October 21, 2025 19:57

updating memory for native build

6167246

mhlidd force-pushed the mhlidd/migrate_to_config_helper branch from 3c09b42 to 6167246 Compare October 21, 2025 20:33

mhlidd added 4 commits October 21, 2025 17:10

adding documentation for failing tests

43c7d2e

increasing memory

0c6e8c3

reverting gradle memory

b5205bf

cleanup

e070d08

mhlidd force-pushed the mhlidd/migrate_to_config_helper branch from 12ec01f to e070d08 Compare October 22, 2025 17:58

Merge branch 'master' into mhlidd/migrate_to_config_helper

f6c59b4

mhlidd merged commit 775e361 into master Oct 22, 2025
537 checks passed

mhlidd deleted the mhlidd/migrate_to_config_helper branch October 22, 2025 19:15

github-actions bot added this to the 1.55.0 milestone Oct 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate Querying of Environment Variables to to `ConfigHelper` #9620

Migrate Querying of Environment Variables to to `ConfigHelper` #9620

Uh oh!

mhlidd commented Sep 26, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Sep 30, 2025 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 bot commented Sep 30, 2025 •

edited by datadog-official bot

Loading

Uh oh!

pr-commenter bot commented Sep 30, 2025 •

edited

Loading

Uh oh!

PerfectSlayer left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mhlidd commented Oct 3, 2025

Uh oh!

PerfectSlayer left a comment

Uh oh!

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Migrate Querying of Environment Variables to to ConfigHelper #9620

Migrate Querying of Environment Variables to to ConfigHelper #9620

Uh oh!

Conversation

mhlidd commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Debugger benchmarks

Parameters

Summary

Uh oh!

datadog-datadog-prod-us1 bot commented Sep 30, 2025 • edited by datadog-official bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mhlidd commented Oct 3, 2025

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Migrate Querying of Environment Variables to to `ConfigHelper` #9620

Migrate Querying of Environment Variables to to `ConfigHelper` #9620

mhlidd commented Sep 26, 2025 •

edited

Loading

pr-commenter bot commented Sep 30, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Sep 30, 2025 •

edited by datadog-official bot

Loading

pr-commenter bot commented Sep 30, 2025 •

edited

Loading