-
Notifications
You must be signed in to change notification settings - Fork 315
Add akka repository token to be used by Gradle and revert akka downgrade. #9668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 99d81a8 | Docs | Was this helpful? Give us feedback! |
| // temporary workaround to avoid early resolution of test classpath | ||
| // ( Akka instrumentation doesn't require call-site instrumentation ) | ||
| // apply plugin: 'call-site-instrumentation' | ||
| apply plugin: 'call-site-instrumentation' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
side note: this can be removed but it can. be done in a separate pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, will open another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~99d81a88a2, baseline=1.54.0-SNAPSHOT~70b85a8492
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1020149
Total [baseline] (10.776 s) : 0, 10775982
Agent [candidate] (1.025 s) : 0, 1025044
Total [candidate] (10.82 s) : 0, 10820080
section appsec
Agent [baseline] (1.195 s) : 0, 1194836
Total [baseline] (11.077 s) : 0, 11077018
Agent [candidate] (1.196 s) : 0, 1196101
Total [candidate] (11.103 s) : 0, 11102788
section iast
Agent [baseline] (1.161 s) : 0, 1160768
Total [baseline] (10.974 s) : 0, 10974365
Agent [candidate] (1.153 s) : 0, 1153424
Total [candidate] (10.925 s) : 0, 10925306
section profiling
Agent [baseline] (1.172 s) : 0, 1171985
Total [baseline] (11.081 s) : 0, 11081278
Agent [candidate] (1.17 s) : 0, 1169615
Total [candidate] (11.096 s) : 0, 11096282
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~99d81a88a2, baseline=1.54.0-SNAPSHOT~70b85a8492
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (694.895 ms) : 0, 694895
BytebuddyAgent [candidate] (697.865 ms) : 0, 697865
GlobalTracer [baseline] (243.593 ms) : 0, 243593
GlobalTracer [candidate] (244.675 ms) : 0, 244675
AppSec [baseline] (32.987 ms) : 0, 32987
AppSec [candidate] (32.896 ms) : 0, 32896
Debugger [baseline] (6.415 ms) : 0, 6415
Debugger [candidate] (6.447 ms) : 0, 6447
Remote Config [baseline] (710.811 µs) : 0, 711
Remote Config [candidate] (673.132 µs) : 0, 673
Telemetry [baseline] (9.373 ms) : 0, 9373
Telemetry [candidate] (9.268 ms) : 0, 9268
Flare Poller [baseline] (9.468 ms) : 0, 9468
Flare Poller [candidate] (10.424 ms) : 0, 10424
section appsec
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (717.602 ms) : 0, 717602
BytebuddyAgent [candidate] (718.03 ms) : 0, 718030
GlobalTracer [baseline] (235.932 ms) : 0, 235932
GlobalTracer [candidate] (235.829 ms) : 0, 235829
IAST [baseline] (25.002 ms) : 0, 25002
IAST [candidate] (24.954 ms) : 0, 24954
AppSec [baseline] (173.547 ms) : 0, 173547
AppSec [candidate] (175.275 ms) : 0, 175275
Debugger [baseline] (6.083 ms) : 0, 6083
Debugger [candidate] (6.116 ms) : 0, 6116
Remote Config [baseline] (653.698 µs) : 0, 654
Remote Config [candidate] (649.347 µs) : 0, 649
Telemetry [baseline] (8.617 ms) : 0, 8617
Telemetry [candidate] (8.617 ms) : 0, 8617
Flare Poller [baseline] (4.745 ms) : 0, 4745
Flare Poller [candidate] (3.962 ms) : 0, 3962
section iast
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (821.252 ms) : 0, 821252
BytebuddyAgent [candidate] (816.495 ms) : 0, 816495
GlobalTracer [baseline] (235.041 ms) : 0, 235041
GlobalTracer [candidate] (233.153 ms) : 0, 233153
IAST [baseline] (26.519 ms) : 0, 26519
IAST [candidate] (27.227 ms) : 0, 27227
AppSec [baseline] (35.448 ms) : 0, 35448
AppSec [candidate] (34.361 ms) : 0, 34361
Debugger [baseline] (6.14 ms) : 0, 6140
Debugger [candidate] (6.164 ms) : 0, 6164
Remote Config [baseline] (590.937 µs) : 0, 591
Remote Config [candidate] (599.158 µs) : 0, 599
Telemetry [baseline] (8.559 ms) : 0, 8559
Telemetry [candidate] (8.491 ms) : 0, 8491
Flare Poller [baseline] (4.236 ms) : 0, 4236
Flare Poller [candidate] (4.187 ms) : 0, 4187
section profiling
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.42 ms) : 0, 1420
BytebuddyAgent [baseline] (727.008 ms) : 0, 727008
BytebuddyAgent [candidate] (725.79 ms) : 0, 725790
GlobalTracer [baseline] (220.543 ms) : 0, 220543
GlobalTracer [candidate] (219.746 ms) : 0, 219746
AppSec [baseline] (33.123 ms) : 0, 33123
AppSec [candidate] (32.966 ms) : 0, 32966
Debugger [baseline] (7.386 ms) : 0, 7386
Debugger [candidate] (7.373 ms) : 0, 7373
Remote Config [baseline] (851.644 µs) : 0, 852
Remote Config [candidate] (769.112 µs) : 0, 769
Telemetry [baseline] (15.877 ms) : 0, 15877
Telemetry [candidate] (16.259 ms) : 0, 16259
Flare Poller [baseline] (4.116 ms) : 0, 4116
Flare Poller [candidate] (4.149 ms) : 0, 4149
ProfilingAgent [baseline] (108.486 ms) : 0, 108486
ProfilingAgent [candidate] (108.293 ms) : 0, 108293
Profiling [baseline] (109.427 ms) : 0, 109427
Profiling [candidate] (109.239 ms) : 0, 109239
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~99d81a88a2, baseline=1.54.0-SNAPSHOT~70b85a8492
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.037 s) : 0, 1037065
Total [baseline] (8.68 s) : 0, 8679893
Agent [candidate] (1.024 s) : 0, 1023637
Total [candidate] (8.668 s) : 0, 8668210
section iast
Agent [baseline] (1.154 s) : 0, 1153689
Total [baseline] (9.241 s) : 0, 9241329
Agent [candidate] (1.152 s) : 0, 1151832
Total [candidate] (9.281 s) : 0, 9281441
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~99d81a88a2, baseline=1.54.0-SNAPSHOT~70b85a8492
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.498 ms) : 0, 1498
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (707.155 ms) : 0, 707155
BytebuddyAgent [candidate] (696.025 ms) : 0, 696025
GlobalTracer [baseline] (246.044 ms) : 0, 246044
GlobalTracer [candidate] (244.23 ms) : 0, 244230
AppSec [baseline] (33.259 ms) : 0, 33259
AppSec [candidate] (32.622 ms) : 0, 32622
Debugger [baseline] (6.48 ms) : 0, 6480
Debugger [candidate] (6.354 ms) : 0, 6354
Remote Config [baseline] (690.993 µs) : 0, 691
Remote Config [candidate] (673.526 µs) : 0, 674
Telemetry [baseline] (9.383 ms) : 0, 9383
Telemetry [candidate] (9.383 ms) : 0, 9383
Flare Poller [baseline] (11.074 ms) : 0, 11074
Flare Poller [candidate] (11.695 ms) : 0, 11695
section iast
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (815.855 ms) : 0, 815855
BytebuddyAgent [candidate] (814.66 ms) : 0, 814660
GlobalTracer [baseline] (233.928 ms) : 0, 233928
GlobalTracer [candidate] (233.53 ms) : 0, 233530
AppSec [baseline] (35.305 ms) : 0, 35305
AppSec [candidate] (35.108 ms) : 0, 35108
Debugger [baseline] (6.173 ms) : 0, 6173
Debugger [candidate] (6.117 ms) : 0, 6117
Remote Config [baseline] (595.628 µs) : 0, 596
Remote Config [candidate] (587.2 µs) : 0, 587
Telemetry [baseline] (8.511 ms) : 0, 8511
Telemetry [candidate] (8.503 ms) : 0, 8503
Flare Poller [baseline] (4.224 ms) : 0, 4224
Flare Poller [candidate] (4.195 ms) : 0, 4195
IAST [baseline] (26.358 ms) : 0, 26358
IAST [candidate] (26.404 ms) : 0, 26404
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 1 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~99d81a88a2, baseline=1.54.0-SNAPSHOT~70b85a8492
dateFormat X
axisFormat %s
section baseline
no_agent (37.589 ms) : 37286, 37892
. : milestone, 37589,
appsec (47.141 ms) : 46731, 47551
. : milestone, 47141,
code_origins (45.942 ms) : 45538, 46345
. : milestone, 45942,
iast (45.183 ms) : 44793, 45573
. : milestone, 45183,
profiling (47.608 ms) : 47185, 48031
. : milestone, 47608,
tracing (45.167 ms) : 44768, 45566
. : milestone, 45167,
section candidate
no_agent (36.328 ms) : 36039, 36617
. : milestone, 36328,
appsec (48.153 ms) : 47744, 48561
. : milestone, 48153,
code_origins (44.416 ms) : 44046, 44787
. : milestone, 44416,
iast (45.092 ms) : 44713, 45471
. : milestone, 45092,
profiling (49.162 ms) : 48697, 49627
. : milestone, 49162,
tracing (44.821 ms) : 44437, 45206
. : milestone, 44821,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~99d81a88a2, baseline=1.54.0-SNAPSHOT~70b85a8492
dateFormat X
axisFormat %s
section baseline
no_agent (4.405 ms) : 4354, 4455
. : milestone, 4405,
iast (10.437 ms) : 10259, 10615
. : milestone, 10437,
iast_FULL (14.701 ms) : 14406, 14996
. : milestone, 14701,
iast_GLOBAL (11.119 ms) : 10920, 11317
. : milestone, 11119,
profiling (8.828 ms) : 8694, 8961
. : milestone, 8828,
tracing (7.896 ms) : 7773, 8018
. : milestone, 7896,
section candidate
no_agent (4.465 ms) : 4408, 4522
. : milestone, 4465,
iast (9.821 ms) : 9654, 9987
. : milestone, 9821,
iast_FULL (14.011 ms) : 13732, 14289
. : milestone, 14011,
iast_GLOBAL (10.721 ms) : 10530, 10913
. : milestone, 10721,
profiling (8.892 ms) : 8753, 9031
. : milestone, 8892,
tracing (7.796 ms) : 7681, 7910
. : milestone, 7796,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~99d81a88a2, baseline=1.54.0-SNAPSHOT~70b85a8492
dateFormat X
axisFormat %s
section baseline
no_agent (1.485 ms) : 1474, 1497
. : milestone, 1485,
appsec (3.701 ms) : 3483, 3919
. : milestone, 3701,
iast (2.213 ms) : 2150, 2277
. : milestone, 2213,
iast_GLOBAL (2.258 ms) : 2195, 2322
. : milestone, 2258,
profiling (2.055 ms) : 2004, 2106
. : milestone, 2055,
tracing (2.03 ms) : 1981, 2080
. : milestone, 2030,
section candidate
no_agent (1.477 ms) : 1465, 1489
. : milestone, 1477,
appsec (3.759 ms) : 3541, 3977
. : milestone, 3759,
iast (2.223 ms) : 2159, 2287
. : milestone, 2223,
iast_GLOBAL (2.25 ms) : 2186, 2314
. : milestone, 2250,
profiling (2.091 ms) : 2026, 2157
. : milestone, 2091,
tracing (2.042 ms) : 1992, 2092
. : milestone, 2042,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~99d81a88a2, baseline=1.54.0-SNAPSHOT~70b85a8492
dateFormat X
axisFormat %s
section baseline
no_agent (14.936 s) : 14936000, 14936000
. : milestone, 14936000,
appsec (15.031 s) : 15031000, 15031000
. : milestone, 15031000,
iast (18.67 s) : 18670000, 18670000
. : milestone, 18670000,
iast_GLOBAL (18.086 s) : 18086000, 18086000
. : milestone, 18086000,
profiling (15.973 s) : 15973000, 15973000
. : milestone, 15973000,
tracing (15.33 s) : 15330000, 15330000
. : milestone, 15330000,
section candidate
no_agent (15.515 s) : 15515000, 15515000
. : milestone, 15515000,
appsec (15.063 s) : 15063000, 15063000
. : milestone, 15063000,
iast (18.688 s) : 18688000, 18688000
. : milestone, 18688000,
iast_GLOBAL (17.917 s) : 17917000, 17917000
. : milestone, 17917000,
profiling (15.199 s) : 15199000, 15199000
. : milestone, 15199000,
tracing (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
|
What Does This Do
Add akka repository token to be used by Gradle and revert akka downgrade (see #9631).
Motivation
Green CI.
Additional Notes
Akka locked down their repository so that requests without the token are blocked. This mirrors the change in gitlab