-
Couldn't load subscription status.
- Fork 315
Update telemetry tags in API10 #9708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 9c26f53 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~9c26f53baa, baseline=1.55.0-SNAPSHOT~baf05d8034
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1027153
Total [baseline] (8.682 s) : 0, 8681752
Agent [candidate] (1.017 s) : 0, 1016649
Total [candidate] (8.682 s) : 0, 8682163
section iast
Agent [baseline] (1.161 s) : 0, 1161126
Total [baseline] (9.367 s) : 0, 9367062
Agent [candidate] (1.157 s) : 0, 1156876
Total [candidate] (9.296 s) : 0, 9295544
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~9c26f53baa, baseline=1.55.0-SNAPSHOT~baf05d8034
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.493 ms) : 0, 1493
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (702.514 ms) : 0, 702514
BytebuddyAgent [candidate] (693.274 ms) : 0, 693274
GlobalTracer [baseline] (242.663 ms) : 0, 242663
GlobalTracer [candidate] (242.078 ms) : 0, 242078
AppSec [baseline] (32.337 ms) : 0, 32337
AppSec [candidate] (32.116 ms) : 0, 32116
Debugger [baseline] (6.466 ms) : 0, 6466
Debugger [candidate] (6.406 ms) : 0, 6406
Remote Config [baseline] (715.854 µs) : 0, 716
Remote Config [candidate] (706.286 µs) : 0, 706
Telemetry [baseline] (9.356 ms) : 0, 9356
Telemetry [candidate] (9.358 ms) : 0, 9358
Flare Poller [baseline] (10.215 ms) : 0, 10215
Flare Poller [candidate] (10.096 ms) : 0, 10096
section iast
crashtracking [baseline] (1.494 ms) : 0, 1494
crashtracking [candidate] (1.49 ms) : 0, 1490
BytebuddyAgent [baseline] (823.081 ms) : 0, 823081
BytebuddyAgent [candidate] (819.947 ms) : 0, 819947
GlobalTracer [baseline] (232.976 ms) : 0, 232976
GlobalTracer [candidate] (232.44 ms) : 0, 232440
AppSec [baseline] (35.456 ms) : 0, 35456
AppSec [candidate] (35.039 ms) : 0, 35039
Debugger [baseline] (6.218 ms) : 0, 6218
Debugger [candidate] (6.132 ms) : 0, 6132
Remote Config [baseline] (615.445 µs) : 0, 615
Remote Config [candidate] (607.653 µs) : 0, 608
Telemetry [baseline] (8.688 ms) : 0, 8688
Telemetry [candidate] (8.666 ms) : 0, 8666
Flare Poller [baseline] (4.223 ms) : 0, 4223
Flare Poller [candidate] (4.274 ms) : 0, 4274
IAST [baseline] (26.71 ms) : 0, 26710
IAST [candidate] (26.624 ms) : 0, 26624
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~9c26f53baa, baseline=1.55.0-SNAPSHOT~baf05d8034
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1021724
Total [baseline] (10.672 s) : 0, 10672063
Agent [candidate] (1.019 s) : 0, 1018606
Total [candidate] (10.713 s) : 0, 10712831
section appsec
Agent [baseline] (1.21 s) : 0, 1209933
Total [baseline] (11.076 s) : 0, 11076237
Agent [candidate] (1.199 s) : 0, 1198704
Total [candidate] (11.061 s) : 0, 11061266
section iast
Agent [baseline] (1.16 s) : 0, 1159605
Total [baseline] (11.017 s) : 0, 11017382
Agent [candidate] (1.152 s) : 0, 1151702
Total [candidate] (11.018 s) : 0, 11017910
section profiling
Agent [baseline] (1.17 s) : 0, 1169834
Total [baseline] (11.052 s) : 0, 11051586
Agent [candidate] (1.161 s) : 0, 1161323
Total [candidate] (11.112 s) : 0, 11111827
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~9c26f53baa, baseline=1.55.0-SNAPSHOT~baf05d8034
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (696.173 ms) : 0, 696173
BytebuddyAgent [candidate] (694.108 ms) : 0, 694108
GlobalTracer [baseline] (242.696 ms) : 0, 242696
GlobalTracer [candidate] (242.3 ms) : 0, 242300
AppSec [baseline] (32.189 ms) : 0, 32189
AppSec [candidate] (32.588 ms) : 0, 32588
Debugger [baseline] (6.387 ms) : 0, 6387
Debugger [candidate] (6.416 ms) : 0, 6416
Remote Config [baseline] (711.882 µs) : 0, 712
Remote Config [candidate] (698.931 µs) : 0, 699
Telemetry [baseline] (9.258 ms) : 0, 9258
Telemetry [candidate] (9.459 ms) : 0, 9459
Flare Poller [baseline] (11.564 ms) : 0, 11564
Flare Poller [candidate] (10.328 ms) : 0, 10328
section appsec
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (727.789 ms) : 0, 727789
BytebuddyAgent [candidate] (720.805 ms) : 0, 720805
GlobalTracer [baseline] (237.623 ms) : 0, 237623
GlobalTracer [candidate] (235.427 ms) : 0, 235427
AppSec [baseline] (176.929 ms) : 0, 176929
AppSec [candidate] (175.757 ms) : 0, 175757
Debugger [baseline] (6.27 ms) : 0, 6270
Debugger [candidate] (6.178 ms) : 0, 6178
Remote Config [baseline] (642.029 µs) : 0, 642
Remote Config [candidate] (631.742 µs) : 0, 632
Telemetry [baseline] (8.63 ms) : 0, 8630
Telemetry [candidate] (8.512 ms) : 0, 8512
Flare Poller [baseline] (4.014 ms) : 0, 4014
Flare Poller [candidate] (3.953 ms) : 0, 3953
IAST [baseline] (25.132 ms) : 0, 25132
IAST [candidate] (24.757 ms) : 0, 24757
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (822.103 ms) : 0, 822103
BytebuddyAgent [candidate] (815.692 ms) : 0, 815692
GlobalTracer [baseline] (232.799 ms) : 0, 232799
GlobalTracer [candidate] (231.371 ms) : 0, 231371
AppSec [baseline] (35.211 ms) : 0, 35211
AppSec [candidate] (35.6 ms) : 0, 35600
Debugger [baseline] (6.157 ms) : 0, 6157
Debugger [candidate] (6.09 ms) : 0, 6090
Remote Config [baseline] (616.13 µs) : 0, 616
Remote Config [candidate] (613.545 µs) : 0, 614
Telemetry [baseline] (8.707 ms) : 0, 8707
Telemetry [candidate] (8.576 ms) : 0, 8576
Flare Poller [baseline] (4.318 ms) : 0, 4318
Flare Poller [candidate] (4.27 ms) : 0, 4270
IAST [baseline] (26.587 ms) : 0, 26587
IAST [candidate] (26.399 ms) : 0, 26399
section profiling
ProfilingAgent [baseline] (107.704 ms) : 0, 107704
ProfilingAgent [candidate] (108.194 ms) : 0, 108194
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (726.32 ms) : 0, 726320
BytebuddyAgent [candidate] (720.441 ms) : 0, 720441
GlobalTracer [baseline] (219.638 ms) : 0, 219638
GlobalTracer [candidate] (217.584 ms) : 0, 217584
AppSec [baseline] (32.723 ms) : 0, 32723
AppSec [candidate] (32.439 ms) : 0, 32439
Debugger [baseline] (7.272 ms) : 0, 7272
Debugger [candidate] (6.543 ms) : 0, 6543
Remote Config [baseline] (789.511 µs) : 0, 790
Remote Config [candidate] (824.082 µs) : 0, 824
Telemetry [baseline] (15.165 ms) : 0, 15165
Telemetry [candidate] (16.192 ms) : 0, 16192
Flare Poller [baseline] (4.147 ms) : 0, 4147
Flare Poller [candidate] (4.177 ms) : 0, 4177
Profiling [baseline] (109.823 ms) : 0, 109823
Profiling [candidate] (109.757 ms) : 0, 109757
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 4 performance regressions! Performance is the same for 4 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~9c26f53baa, baseline=1.55.0-SNAPSHOT~baf05d8034
dateFormat X
axisFormat %s
section baseline
no_agent (4.293 ms) : 4238, 4347
. : milestone, 4293,
iast (10.071 ms) : 9900, 10242
. : milestone, 10071,
iast_FULL (14.79 ms) : 14491, 15090
. : milestone, 14790,
iast_GLOBAL (10.836 ms) : 10644, 11029
. : milestone, 10836,
profiling (9.116 ms) : 8974, 9259
. : milestone, 9116,
tracing (7.486 ms) : 7381, 7591
. : milestone, 7486,
section candidate
no_agent (4.458 ms) : 4406, 4509
. : milestone, 4458,
iast (9.619 ms) : 9455, 9783
. : milestone, 9619,
iast_FULL (15.037 ms) : 14737, 15338
. : milestone, 15037,
iast_GLOBAL (10.375 ms) : 10195, 10556
. : milestone, 10375,
profiling (8.698 ms) : 8560, 8836
. : milestone, 8698,
tracing (7.862 ms) : 7751, 7972
. : milestone, 7862,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~9c26f53baa, baseline=1.55.0-SNAPSHOT~baf05d8034
dateFormat X
axisFormat %s
section baseline
no_agent (36.553 ms) : 36259, 36848
. : milestone, 36553,
appsec (47.182 ms) : 46770, 47594
. : milestone, 47182,
code_origins (41.982 ms) : 41620, 42344
. : milestone, 41982,
iast (43.823 ms) : 43444, 44202
. : milestone, 43823,
profiling (49.223 ms) : 48728, 49719
. : milestone, 49223,
tracing (46.3 ms) : 45895, 46704
. : milestone, 46300,
section candidate
no_agent (37.096 ms) : 36801, 37390
. : milestone, 37096,
appsec (48.229 ms) : 47812, 48647
. : milestone, 48229,
code_origins (44.415 ms) : 44020, 44811
. : milestone, 44415,
iast (47.325 ms) : 46905, 47746
. : milestone, 47325,
profiling (48.451 ms) : 47988, 48915
. : milestone, 48451,
tracing (44.807 ms) : 44426, 45187
. : milestone, 44807,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~9c26f53baa, baseline=1.55.0-SNAPSHOT~baf05d8034
dateFormat X
axisFormat %s
section baseline
no_agent (15.623 s) : 15623000, 15623000
. : milestone, 15623000,
appsec (15.024 s) : 15024000, 15024000
. : milestone, 15024000,
iast (18.483 s) : 18483000, 18483000
. : milestone, 18483000,
iast_GLOBAL (18.25 s) : 18250000, 18250000
. : milestone, 18250000,
profiling (14.958 s) : 14958000, 14958000
. : milestone, 14958000,
tracing (15.079 s) : 15079000, 15079000
. : milestone, 15079000,
section candidate
no_agent (15.351 s) : 15351000, 15351000
. : milestone, 15351000,
appsec (15.231 s) : 15231000, 15231000
. : milestone, 15231000,
iast (18.674 s) : 18674000, 18674000
. : milestone, 18674000,
iast_GLOBAL (18.054 s) : 18054000, 18054000
. : milestone, 18054000,
profiling (15.285 s) : 15285000, 15285000
. : milestone, 15285000,
tracing (14.918 s) : 14918000, 14918000
. : milestone, 14918000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~9c26f53baa, baseline=1.55.0-SNAPSHOT~baf05d8034
dateFormat X
axisFormat %s
section baseline
no_agent (1.491 ms) : 1479, 1502
. : milestone, 1491,
appsec (3.732 ms) : 3514, 3950
. : milestone, 3732,
iast (2.23 ms) : 2166, 2294
. : milestone, 2230,
iast_GLOBAL (2.263 ms) : 2198, 2328
. : milestone, 2263,
profiling (2.091 ms) : 2039, 2144
. : milestone, 2091,
tracing (2.043 ms) : 1994, 2093
. : milestone, 2043,
section candidate
no_agent (1.483 ms) : 1471, 1495
. : milestone, 1483,
appsec (3.75 ms) : 3530, 3971
. : milestone, 3750,
iast (2.234 ms) : 2170, 2297
. : milestone, 2234,
iast_GLOBAL (2.276 ms) : 2212, 2340
. : milestone, 2276,
profiling (2.098 ms) : 2044, 2152
. : milestone, 2098,
tracing (2.035 ms) : 1985, 2085
. : milestone, 2035,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
108528d to
cd31d17
Compare
cd31d17 to
9c26f53
Compare
What Does This Do
Adds the
rule_varianttag toSSRFRASP telemetry metrics.Motivation
Additional Notes
RFC
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]