-
Notifications
You must be signed in to change notification settings - Fork 314
Add support for Guava and FastUtil #9727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Consider guava and fastutil collections and maps as safe so they can be treated as regular collections and maps and use in expression and captured as well
|
🎯 Code Coverage 🔗 Commit SHA: fd45ccd | Docs | Was this helpful? Give us feedback! |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (323.86 µs) : 267, 381
. : milestone, 324,
basic (271.974 µs) : 265, 279
. : milestone, 272,
loop (8.957 ms) : 8952, 8961
. : milestone, 8957,
section candidate
noprobe (315.52 µs) : 294, 337
. : milestone, 316,
basic (284.789 µs) : 271, 298
. : milestone, 285,
loop (8.962 ms) : 8932, 8993
. : milestone, 8962,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~fd45ccd8a6, baseline=1.55.0-SNAPSHOT~4589cb2f7d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1021697
Total [baseline] (8.723 s) : 0, 8723116
Agent [candidate] (1.016 s) : 0, 1016236
Total [candidate] (8.673 s) : 0, 8672617
section iast
Agent [baseline] (1.153 s) : 0, 1153381
Total [baseline] (9.349 s) : 0, 9349322
Agent [candidate] (1.157 s) : 0, 1157060
Total [candidate] (9.296 s) : 0, 9296051
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~fd45ccd8a6, baseline=1.55.0-SNAPSHOT~4589cb2f7d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (696.415 ms) : 0, 696415
BytebuddyAgent [candidate] (692.759 ms) : 0, 692759
GlobalTracer [baseline] (243.097 ms) : 0, 243097
GlobalTracer [candidate] (241.84 ms) : 0, 241840
AppSec [baseline] (32.682 ms) : 0, 32682
AppSec [candidate] (32.459 ms) : 0, 32459
Debugger [baseline] (6.521 ms) : 0, 6521
Debugger [candidate] (6.423 ms) : 0, 6423
Remote Config [baseline] (712.747 µs) : 0, 713
Remote Config [candidate] (699.227 µs) : 0, 699
Telemetry [baseline] (9.389 ms) : 0, 9389
Telemetry [candidate] (9.402 ms) : 0, 9402
Flare Poller [baseline] (10.162 ms) : 0, 10162
Flare Poller [candidate] (10.078 ms) : 0, 10078
section iast
crashtracking [baseline] (1.502 ms) : 0, 1502
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (816.363 ms) : 0, 816363
BytebuddyAgent [candidate] (819.313 ms) : 0, 819313
GlobalTracer [baseline] (232.102 ms) : 0, 232102
GlobalTracer [candidate] (232.814 ms) : 0, 232814
IAST [baseline] (27.553 ms) : 0, 27553
IAST [candidate] (26.753 ms) : 0, 26753
AppSec [baseline] (34.555 ms) : 0, 34555
AppSec [candidate] (35.435 ms) : 0, 35435
Debugger [baseline] (6.174 ms) : 0, 6174
Debugger [candidate] (6.209 ms) : 0, 6209
Remote Config [baseline] (636.772 µs) : 0, 637
Remote Config [candidate] (621.476 µs) : 0, 621
Telemetry [baseline] (8.781 ms) : 0, 8781
Telemetry [candidate] (8.801 ms) : 0, 8801
Flare Poller [baseline] (4.204 ms) : 0, 4204
Flare Poller [candidate] (4.216 ms) : 0, 4216
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~fd45ccd8a6, baseline=1.55.0-SNAPSHOT~4589cb2f7d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1021572
Total [baseline] (10.636 s) : 0, 10635830
Agent [candidate] (1.016 s) : 0, 1015768
Total [candidate] (10.661 s) : 0, 10660776
section appsec
Agent [baseline] (1.193 s) : 0, 1192568
Total [baseline] (11.088 s) : 0, 11088078
Agent [candidate] (1.195 s) : 0, 1194905
Total [candidate] (11.01 s) : 0, 11010479
section iast
Agent [baseline] (1.16 s) : 0, 1160125
Total [baseline] (10.923 s) : 0, 10923123
Agent [candidate] (1.152 s) : 0, 1152177
Total [candidate] (11.008 s) : 0, 11008058
section profiling
Agent [baseline] (1.161 s) : 0, 1161047
Total [baseline] (11.126 s) : 0, 11126240
Agent [candidate] (1.169 s) : 0, 1168545
Total [candidate] (11.052 s) : 0, 11051775
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~fd45ccd8a6, baseline=1.55.0-SNAPSHOT~4589cb2f7d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.481 ms) : 0, 1481
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (697.782 ms) : 0, 697782
BytebuddyAgent [candidate] (692.613 ms) : 0, 692613
GlobalTracer [baseline] (242.118 ms) : 0, 242118
GlobalTracer [candidate] (241.357 ms) : 0, 241357
AppSec [baseline] (32.716 ms) : 0, 32716
AppSec [candidate] (32.027 ms) : 0, 32027
Debugger [baseline] (6.414 ms) : 0, 6414
Debugger [candidate] (6.387 ms) : 0, 6387
Remote Config [baseline] (710.435 µs) : 0, 710
Remote Config [candidate] (705.481 µs) : 0, 705
Telemetry [baseline] (9.41 ms) : 0, 9410
Telemetry [candidate] (9.152 ms) : 0, 9152
Flare Poller [baseline] (9.487 ms) : 0, 9487
Flare Poller [candidate] (10.878 ms) : 0, 10878
section appsec
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (716.645 ms) : 0, 716645
BytebuddyAgent [candidate] (718.367 ms) : 0, 718367
GlobalTracer [baseline] (234.171 ms) : 0, 234171
GlobalTracer [candidate] (234.886 ms) : 0, 234886
IAST [baseline] (24.636 ms) : 0, 24636
IAST [candidate] (24.762 ms) : 0, 24762
AppSec [baseline] (175.465 ms) : 0, 175465
AppSec [candidate] (175.461 ms) : 0, 175461
Debugger [baseline] (6.137 ms) : 0, 6137
Debugger [candidate] (6.012 ms) : 0, 6012
Remote Config [baseline] (637.157 µs) : 0, 637
Remote Config [candidate] (627.453 µs) : 0, 627
Telemetry [baseline] (8.409 ms) : 0, 8409
Telemetry [candidate] (8.35 ms) : 0, 8350
Flare Poller [baseline] (3.939 ms) : 0, 3939
Flare Poller [candidate] (3.894 ms) : 0, 3894
section iast
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (822.136 ms) : 0, 822136
BytebuddyAgent [candidate] (815.764 ms) : 0, 815764
GlobalTracer [baseline] (232.616 ms) : 0, 232616
GlobalTracer [candidate] (231.985 ms) : 0, 231985
IAST [baseline] (26.92 ms) : 0, 26920
IAST [candidate] (26.531 ms) : 0, 26531
AppSec [baseline] (35.376 ms) : 0, 35376
AppSec [candidate] (35.59 ms) : 0, 35590
Debugger [baseline] (6.227 ms) : 0, 6227
Debugger [candidate] (6.072 ms) : 0, 6072
Remote Config [baseline] (625.102 µs) : 0, 625
Remote Config [candidate] (607.917 µs) : 0, 608
Telemetry [baseline] (8.759 ms) : 0, 8759
Telemetry [candidate] (8.548 ms) : 0, 8548
Flare Poller [baseline] (4.27 ms) : 0, 4270
Flare Poller [candidate] (4.178 ms) : 0, 4178
section profiling
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (720.316 ms) : 0, 720316
BytebuddyAgent [candidate] (725.66 ms) : 0, 725660
GlobalTracer [baseline] (217.656 ms) : 0, 217656
GlobalTracer [candidate] (218.89 ms) : 0, 218890
AppSec [baseline] (32.335 ms) : 0, 32335
AppSec [candidate] (32.946 ms) : 0, 32946
Debugger [baseline] (6.444 ms) : 0, 6444
Debugger [candidate] (6.496 ms) : 0, 6496
Remote Config [baseline] (798.448 µs) : 0, 798
Remote Config [candidate] (695.578 µs) : 0, 696
Telemetry [baseline] (16.118 ms) : 0, 16118
Telemetry [candidate] (15.809 ms) : 0, 15809
Flare Poller [baseline] (4.102 ms) : 0, 4102
Flare Poller [candidate] (5.022 ms) : 0, 5022
ProfilingAgent [baseline] (108.21 ms) : 0, 108210
ProfilingAgent [candidate] (108.504 ms) : 0, 108504
Profiling [baseline] (109.757 ms) : 0, 109757
Profiling [candidate] (109.233 ms) : 0, 109233
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~fd45ccd8a6, baseline=1.55.0-SNAPSHOT~4589cb2f7d
dateFormat X
axisFormat %s
section baseline
no_agent (36.347 ms) : 36054, 36639
. : milestone, 36347,
appsec (49.47 ms) : 49020, 49919
. : milestone, 49470,
code_origins (44.324 ms) : 43942, 44707
. : milestone, 44324,
iast (46.351 ms) : 45955, 46747
. : milestone, 46351,
profiling (46.854 ms) : 46424, 47284
. : milestone, 46854,
tracing (44.624 ms) : 44235, 45013
. : milestone, 44624,
section candidate
no_agent (35.795 ms) : 35499, 36091
. : milestone, 35795,
appsec (48.089 ms) : 47656, 48523
. : milestone, 48089,
code_origins (45.401 ms) : 45011, 45791
. : milestone, 45401,
iast (45.877 ms) : 45463, 46291
. : milestone, 45877,
profiling (47.686 ms) : 47246, 48127
. : milestone, 47686,
tracing (43.165 ms) : 42799, 43530
. : milestone, 43165,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~fd45ccd8a6, baseline=1.55.0-SNAPSHOT~4589cb2f7d
dateFormat X
axisFormat %s
section baseline
no_agent (4.353 ms) : 4297, 4409
. : milestone, 4353,
iast (9.844 ms) : 9682, 10006
. : milestone, 9844,
iast_FULL (13.626 ms) : 13355, 13897
. : milestone, 13626,
iast_GLOBAL (10.845 ms) : 10649, 11040
. : milestone, 10845,
profiling (8.647 ms) : 8515, 8779
. : milestone, 8647,
tracing (8.283 ms) : 8162, 8405
. : milestone, 8283,
section candidate
no_agent (4.348 ms) : 4297, 4398
. : milestone, 4348,
iast (9.684 ms) : 9522, 9845
. : milestone, 9684,
iast_FULL (13.667 ms) : 13394, 13940
. : milestone, 13667,
iast_GLOBAL (10.223 ms) : 10043, 10403
. : milestone, 10223,
profiling (8.992 ms) : 8853, 9131
. : milestone, 8992,
tracing (8.263 ms) : 8143, 8383
. : milestone, 8263,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~fd45ccd8a6, baseline=1.55.0-SNAPSHOT~4589cb2f7d
dateFormat X
axisFormat %s
section baseline
no_agent (15.001 s) : 15001000, 15001000
. : milestone, 15001000,
appsec (15.226 s) : 15226000, 15226000
. : milestone, 15226000,
iast (18.437 s) : 18437000, 18437000
. : milestone, 18437000,
iast_GLOBAL (18.183 s) : 18183000, 18183000
. : milestone, 18183000,
profiling (15.456 s) : 15456000, 15456000
. : milestone, 15456000,
tracing (15.075 s) : 15075000, 15075000
. : milestone, 15075000,
section candidate
no_agent (15.67 s) : 15670000, 15670000
. : milestone, 15670000,
appsec (15.246 s) : 15246000, 15246000
. : milestone, 15246000,
iast (18.47 s) : 18470000, 18470000
. : milestone, 18470000,
iast_GLOBAL (18.254 s) : 18254000, 18254000
. : milestone, 18254000,
profiling (15.183 s) : 15183000, 15183000
. : milestone, 15183000,
tracing (15.058 s) : 15058000, 15058000
. : milestone, 15058000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~fd45ccd8a6, baseline=1.55.0-SNAPSHOT~4589cb2f7d
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.716 ms) : 3497, 3935
. : milestone, 3716,
iast (2.22 ms) : 2156, 2284
. : milestone, 2220,
iast_GLOBAL (2.258 ms) : 2195, 2322
. : milestone, 2258,
profiling (2.084 ms) : 2031, 2137
. : milestone, 2084,
tracing (2.038 ms) : 1988, 2088
. : milestone, 2038,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.714 ms) : 3495, 3933
. : milestone, 3714,
iast (2.22 ms) : 2156, 2284
. : milestone, 2220,
iast_GLOBAL (2.258 ms) : 2194, 2322
. : milestone, 2258,
profiling (2.079 ms) : 2026, 2132
. : milestone, 2079,
tracing (2.045 ms) : 1996, 2095
. : milestone, 2045,
|
| // All Collection implementations from Google ProtoBuf are considered as safe | ||
| return true; | ||
| } | ||
| if (className.startsWith("com.google.common.collect.")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe collect these packages in a list and iterate so we're not duplicating so much now that the list is growing. otherwise 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
What Does This Do
Consider guava and fastutil collections and maps as safe so they can be treated as regular collections and maps and use in expression and captured as well
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-4576