-
Notifications
You must be signed in to change notification settings - Fork 314
Minor code cleanup. #9750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor code cleanup. #9750
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 5a8b7b0 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~5a8b7b0a54, baseline=1.55.0-SNAPSHOT~baf05d8034
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1025769
Total [baseline] (8.673 s) : 0, 8673146
Agent [candidate] (1.024 s) : 0, 1023913
Total [candidate] (8.715 s) : 0, 8715354
section iast
Agent [baseline] (1.166 s) : 0, 1166051
Total [baseline] (9.309 s) : 0, 9308796
Agent [candidate] (1.151 s) : 0, 1151194
Total [candidate] (9.316 s) : 0, 9315512
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~5a8b7b0a54, baseline=1.55.0-SNAPSHOT~baf05d8034
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (698.971 ms) : 0, 698971
BytebuddyAgent [candidate] (698.426 ms) : 0, 698426
GlobalTracer [baseline] (243.533 ms) : 0, 243533
GlobalTracer [candidate] (243.874 ms) : 0, 243874
AppSec [baseline] (32.61 ms) : 0, 32610
AppSec [candidate] (32.71 ms) : 0, 32710
Debugger [baseline] (6.499 ms) : 0, 6499
Debugger [candidate] (6.414 ms) : 0, 6414
Remote Config [baseline] (737.952 µs) : 0, 738
Remote Config [candidate] (704.478 µs) : 0, 704
Telemetry [baseline] (9.518 ms) : 0, 9518
Telemetry [candidate] (9.389 ms) : 0, 9389
Flare Poller [baseline] (11.065 ms) : 0, 11065
Flare Poller [candidate] (9.656 ms) : 0, 9656
section iast
crashtracking [baseline] (1.514 ms) : 0, 1514
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (827.781 ms) : 0, 827781
BytebuddyAgent [candidate] (815.171 ms) : 0, 815171
GlobalTracer [baseline] (233.02 ms) : 0, 233020
GlobalTracer [candidate] (231.679 ms) : 0, 231679
AppSec [baseline] (35.498 ms) : 0, 35498
AppSec [candidate] (35.406 ms) : 0, 35406
Debugger [baseline] (6.189 ms) : 0, 6189
Debugger [candidate] (6.091 ms) : 0, 6091
Remote Config [baseline] (621.847 µs) : 0, 622
Remote Config [candidate] (609.11 µs) : 0, 609
Telemetry [baseline] (8.707 ms) : 0, 8707
Telemetry [candidate] (8.636 ms) : 0, 8636
Flare Poller [baseline] (4.285 ms) : 0, 4285
Flare Poller [candidate] (4.214 ms) : 0, 4214
IAST [baseline] (26.702 ms) : 0, 26702
IAST [candidate] (26.451 ms) : 0, 26451
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~5a8b7b0a54, baseline=1.55.0-SNAPSHOT~baf05d8034
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.015 s) : 0, 1015014
Total [baseline] (10.742 s) : 0, 10742406
Agent [candidate] (1.021 s) : 0, 1021050
Total [candidate] (10.741 s) : 0, 10740538
section appsec
Agent [baseline] (1.197 s) : 0, 1196758
Total [baseline] (11.096 s) : 0, 11096354
Agent [candidate] (1.203 s) : 0, 1202984
Total [candidate] (11.027 s) : 0, 11026961
section iast
Agent [baseline] (1.155 s) : 0, 1155490
Total [baseline] (11.063 s) : 0, 11063479
Agent [candidate] (1.151 s) : 0, 1150824
Total [candidate] (11.005 s) : 0, 11005478
section profiling
Agent [baseline] (1.161 s) : 0, 1161302
Total [baseline] (11.019 s) : 0, 11019486
Agent [candidate] (1.165 s) : 0, 1164810
Total [candidate] (11.088 s) : 0, 11088138
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~5a8b7b0a54, baseline=1.55.0-SNAPSHOT~baf05d8034
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (690.762 ms) : 0, 690762
BytebuddyAgent [candidate] (696.87 ms) : 0, 696870
GlobalTracer [baseline] (241.797 ms) : 0, 241797
GlobalTracer [candidate] (243.042 ms) : 0, 243042
AppSec [baseline] (32.33 ms) : 0, 32330
AppSec [candidate] (32.52 ms) : 0, 32520
Debugger [baseline] (6.362 ms) : 0, 6362
Debugger [candidate] (6.43 ms) : 0, 6430
Remote Config [baseline] (715.36 µs) : 0, 715
Remote Config [candidate] (703.842 µs) : 0, 704
Telemetry [baseline] (9.289 ms) : 0, 9289
Telemetry [candidate] (9.349 ms) : 0, 9349
Flare Poller [baseline] (11.123 ms) : 0, 11123
Flare Poller [candidate] (9.361 ms) : 0, 9361
section appsec
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (719.539 ms) : 0, 719539
BytebuddyAgent [candidate] (724.009 ms) : 0, 724009
GlobalTracer [baseline] (234.675 ms) : 0, 234675
GlobalTracer [candidate] (236.095 ms) : 0, 236095
AppSec [baseline] (175.947 ms) : 0, 175947
AppSec [candidate] (175.683 ms) : 0, 175683
Debugger [baseline] (6.156 ms) : 0, 6156
Debugger [candidate] (6.196 ms) : 0, 6196
Remote Config [baseline] (627.57 µs) : 0, 628
Remote Config [candidate] (657.029 µs) : 0, 657
Telemetry [baseline] (8.428 ms) : 0, 8428
Telemetry [candidate] (8.615 ms) : 0, 8615
Flare Poller [baseline] (3.937 ms) : 0, 3937
Flare Poller [candidate] (4.073 ms) : 0, 4073
IAST [baseline] (24.803 ms) : 0, 24803
IAST [candidate] (24.89 ms) : 0, 24890
section iast
crashtracking [baseline] (1.497 ms) : 0, 1497
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (818.358 ms) : 0, 818358
BytebuddyAgent [candidate] (814.999 ms) : 0, 814999
GlobalTracer [baseline] (232.102 ms) : 0, 232102
GlobalTracer [candidate] (231.371 ms) : 0, 231371
AppSec [baseline] (35.356 ms) : 0, 35356
AppSec [candidate] (35.313 ms) : 0, 35313
Debugger [baseline] (6.147 ms) : 0, 6147
Debugger [candidate] (6.133 ms) : 0, 6133
Remote Config [baseline] (618.802 µs) : 0, 619
Remote Config [candidate] (610.408 µs) : 0, 610
Telemetry [baseline] (8.789 ms) : 0, 8789
Telemetry [candidate] (8.812 ms) : 0, 8812
Flare Poller [baseline] (4.277 ms) : 0, 4277
Flare Poller [candidate] (4.191 ms) : 0, 4191
IAST [baseline] (26.657 ms) : 0, 26657
IAST [candidate] (26.391 ms) : 0, 26391
section profiling
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (720.779 ms) : 0, 720779
BytebuddyAgent [candidate] (723.159 ms) : 0, 723159
GlobalTracer [baseline] (217.276 ms) : 0, 217276
GlobalTracer [candidate] (218.189 ms) : 0, 218189
AppSec [baseline] (32.458 ms) : 0, 32458
AppSec [candidate] (32.476 ms) : 0, 32476
Debugger [baseline] (6.45 ms) : 0, 6450
Debugger [candidate] (7.279 ms) : 0, 7279
Remote Config [baseline] (795.304 µs) : 0, 795
Remote Config [candidate] (1.593 ms) : 0, 1593
Telemetry [baseline] (15.424 ms) : 0, 15424
Telemetry [candidate] (14.748 ms) : 0, 14748
Flare Poller [baseline] (4.981 ms) : 0, 4981
Flare Poller [candidate] (4.125 ms) : 0, 4125
ProfilingAgent [baseline] (108.506 ms) : 0, 108506
ProfilingAgent [candidate] (107.765 ms) : 0, 107765
Profiling [baseline] (109.607 ms) : 0, 109607
Profiling [candidate] (109.44 ms) : 0, 109440
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~5a8b7b0a54, baseline=1.55.0-SNAPSHOT~baf05d8034
dateFormat X
axisFormat %s
section baseline
no_agent (4.452 ms) : 4402, 4502
. : milestone, 4452,
iast (9.827 ms) : 9663, 9992
. : milestone, 9827,
iast_FULL (14.911 ms) : 14614, 15208
. : milestone, 14911,
iast_GLOBAL (10.733 ms) : 10543, 10923
. : milestone, 10733,
profiling (9.036 ms) : 8885, 9186
. : milestone, 9036,
tracing (8.116 ms) : 7995, 8236
. : milestone, 8116,
section candidate
no_agent (4.451 ms) : 4401, 4502
. : milestone, 4451,
iast (10.149 ms) : 9975, 10323
. : milestone, 10149,
iast_FULL (14.595 ms) : 14298, 14891
. : milestone, 14595,
iast_GLOBAL (10.617 ms) : 10430, 10804
. : milestone, 10617,
profiling (9.703 ms) : 9551, 9855
. : milestone, 9703,
tracing (8.118 ms) : 7990, 8246
. : milestone, 8118,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~5a8b7b0a54, baseline=1.55.0-SNAPSHOT~baf05d8034
dateFormat X
axisFormat %s
section baseline
no_agent (37.719 ms) : 37418, 38020
. : milestone, 37719,
appsec (49.542 ms) : 49110, 49973
. : milestone, 49542,
code_origins (43.411 ms) : 43045, 43778
. : milestone, 43411,
iast (47.559 ms) : 47157, 47962
. : milestone, 47559,
profiling (49.219 ms) : 48740, 49698
. : milestone, 49219,
tracing (43.297 ms) : 42918, 43675
. : milestone, 43297,
section candidate
no_agent (37.616 ms) : 37313, 37918
. : milestone, 37616,
appsec (49.127 ms) : 48694, 49560
. : milestone, 49127,
code_origins (42.679 ms) : 42315, 43042
. : milestone, 42679,
iast (45.282 ms) : 44894, 45671
. : milestone, 45282,
profiling (50.694 ms) : 50253, 51135
. : milestone, 50694,
tracing (44.837 ms) : 44452, 45222
. : milestone, 44837,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~5a8b7b0a54, baseline=1.55.0-SNAPSHOT~baf05d8034
dateFormat X
axisFormat %s
section baseline
no_agent (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
appsec (14.959 s) : 14959000, 14959000
. : milestone, 14959000,
iast (18.718 s) : 18718000, 18718000
. : milestone, 18718000,
iast_GLOBAL (18.129 s) : 18129000, 18129000
. : milestone, 18129000,
profiling (15.384 s) : 15384000, 15384000
. : milestone, 15384000,
tracing (15.143 s) : 15143000, 15143000
. : milestone, 15143000,
section candidate
no_agent (15.308 s) : 15308000, 15308000
. : milestone, 15308000,
appsec (15.073 s) : 15073000, 15073000
. : milestone, 15073000,
iast (18.251 s) : 18251000, 18251000
. : milestone, 18251000,
iast_GLOBAL (17.983 s) : 17983000, 17983000
. : milestone, 17983000,
profiling (15.344 s) : 15344000, 15344000
. : milestone, 15344000,
tracing (15.217 s) : 15217000, 15217000
. : milestone, 15217000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~5a8b7b0a54, baseline=1.55.0-SNAPSHOT~baf05d8034
dateFormat X
axisFormat %s
section baseline
no_agent (1.484 ms) : 1473, 1496
. : milestone, 1484,
appsec (3.707 ms) : 3490, 3924
. : milestone, 3707,
iast (2.214 ms) : 2151, 2278
. : milestone, 2214,
iast_GLOBAL (2.261 ms) : 2197, 2324
. : milestone, 2261,
profiling (2.073 ms) : 2020, 2126
. : milestone, 2073,
tracing (2.031 ms) : 1982, 2081
. : milestone, 2031,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.651 ms) : 3434, 3869
. : milestone, 3651,
iast (2.22 ms) : 2156, 2284
. : milestone, 2220,
iast_GLOBAL (2.258 ms) : 2195, 2321
. : milestone, 2258,
profiling (2.088 ms) : 2034, 2141
. : milestone, 2088,
tracing (2.031 ms) : 1981, 2080
. : milestone, 2031,
|
What Does This Do
Minor code cleanup.
Motivation
Idiomatic code.