Remove instrumentation afterEvaluate

[bric3]

What Does This Do

Removes instrumentation module's afterEvaluate.

This looks like it is reducing sync time to ~1min on my M1

Motivation

Using afterEvaluate is a bad practice and has tighter restriction in Gradle 9+.

https://docs.gradle.org/9.1.0/userguide/task_configuration_avoidance.html#8_some_apis_may_be_disallowed_if_you_try_to_access_them_from_the_new_apis_configuration_blocks

It introduces subtle ordering issues which can be very challenging to debug.

From my notes:

1. Anyone wanting to use code in an afterEvaluate {} now also needs to use afterEvaluate {} all the way down.
2. It becomes even more complicated as more plugins/scripts are involved
3. More generally, it makes dependencies between plugins/scripts implicit and error prone

Abusing afterEvaluate causes many things that will try to run later and later after each other when order is not guaranteed. In almost all situations, afterEvaluate is a work-around that introduces timing problems and race conditions and just treats symptoms.

Usually, afterEvaluate {} is good in this occasion:

• consistency checks, i.e. ensure that something is not misconfigured.

Additional Notes

Contributor Checklist

• Format the title according the contribution guidelines
• Assign the type: and (comp: or inst:) labels in addition to any useful labels
• Don't use close, fix or any linking keywords when referencing an issue.
  Use solves instead, and assign the PR milestone to the issue
• Update the CODEOWNERS file on source file addition, move, or deletion
• Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]